From patchwork Wed May 26 11:06:07 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Mehnert X-Patchwork-Id: 53608 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B580BB7D12 for ; Wed, 26 May 2010 21:08:12 +1000 (EST) Received: from localhost ([127.0.0.1]:50777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHET2-00005a-Mp for incoming@patchwork.ozlabs.org; Wed, 26 May 2010 07:08:08 -0400 Received: from [140.186.70.92] (port=43061 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHERb-0007zg-TM for qemu-devel@nongnu.org; Wed, 26 May 2010 07:06:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHERa-0007YP-Jh for qemu-devel@nongnu.org; Wed, 26 May 2010 07:06:39 -0400 Received: from gmp-eb-inf-2.sun.com ([192.18.6.24]:42690) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHERa-0007Y8-BM for qemu-devel@nongnu.org; Wed, 26 May 2010 07:06:38 -0400 Received: from fe-emea-13.sun.com (gmp-eb-lb-1-fe1.eu.sun.com [192.18.6.7] (may be forged)) by gmp-eb-inf-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id o4QB6aAw004769 for ; Wed, 26 May 2010 11:06:36 GMT MIME-version: 1.0 Received: from conversion-daemon.fe-emea-13.sun.com by fe-emea-13.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) id <0L3000700X8ZJH00@fe-emea-13.sun.com> for qemu-devel@nongnu.org; Wed, 26 May 2010 12:06:11 +0100 (BST) Received: from vpn-129-150-124-102.germany.sun.com ([unknown] [129.150.124.102]) by fe-emea-13.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTPSA id <0L300079HXIBHZ30@fe-emea-13.sun.com> for qemu-devel@nongnu.org; Wed, 26 May 2010 12:06:11 +0100 (BST) Date: Wed, 26 May 2010 13:06:07 +0200 From: Frank Mehnert Subject: Re: [Qemu-devel] Re: hw/serial.c: Xmit fifo never used In-reply-to: <4BFCF8AF.8030300@siemens.com> To: qemu-devel@nongnu.org Message-id: <201005261306.07673.frank.mehnert@sun.com> Organization: Sun Microsystems Content-type: multipart/signed; boundary=nextPart5498745.2xa8RtzVjO; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-transfer-encoding: 7bit References: <201005261207.31310.frank.mehnert@sun.com> <4BFCF8AF.8030300@siemens.com> User-Agent: KMail/1.9.9 X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Wednesday 26 May 2010, Jan Kiszka wrote: > Frank Mehnert wrote: > > I assume the correct condition would be '>= 0', that is > > > > ... > > if ((s->tsr_retry >= 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) { > > s->tsr_retry++; > > ... > > Makes sense, patch welcome. Attached. Kind regards, Frank diff --git a/hw/serial.c b/hw/serial.c index 9102edb..0b1550b 100644 --- a/hw/serial.c +++ b/hw/serial.c @@ -327,7 +327,7 @@ static void serial_xmit(void *opaque) /* in loopback mode, say that we just received a char */ serial_receive1(s, &s->tsr, 1); } else if (qemu_chr_write(s->chr, &s->tsr, 1) != 1) { - if ((s->tsr_retry > 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) { + if ((s->tsr_retry >= 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) { s->tsr_retry++; qemu_mod_timer(s->transmit_timer, new_xmit_ts + s->char_transmit_time); return;