| Message ID | d08375d1ada6279f93cf2294a7adc3ecd50a3735.1445862541.git.maitysanchayan@gmail.com |
|---|---|
| State | Accepted |
| Commit | 6089f751411e9295ef88c5821fc37889d265dd0a |
| Delegated to: | Marek Vasut |
| Headers | show |
On Monday, October 26, 2015 at 01:58:49 PM, Sanchayan Maity wrote: > The current ehci-vf USB driver for Vybrid hardcodes the USB host > and client functionality. Remove this. > > Reported-by: Santhosh Kumar Janardhanam <santhosh.kj@hcl.com> > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com> Is this a V2 or why did I receive this patchset twice ? Looks OK though. Best regards, Marek Vasut
Hello, On 15-10-26 20:19:42, Marek Vasut wrote: > On Monday, October 26, 2015 at 01:58:49 PM, Sanchayan Maity wrote: > > The current ehci-vf USB driver for Vybrid hardcodes the USB host > > and client functionality. Remove this. > > > > Reported-by: Santhosh Kumar Janardhanam <santhosh.kj@hcl.com> > > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com> > > Is this a V2 or why did I receive this patchset twice ? Yes sorry about that. I specified the uboot mailing list address wrong in my first patchset mail. Had to resend but then missed adding RESEND. - Sanchayan. > > Looks OK though. > > Best regards, > Marek Vasut
Hello Stefano / Marek, Can you pick this up? - Sanchayan. On 15-10-26 18:28:49, Sanchayan Maity wrote: > The current ehci-vf USB driver for Vybrid hardcodes the USB host > and client functionality. Remove this. > > Reported-by: Santhosh Kumar Janardhanam <santhosh.kj@hcl.com> > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com> > --- > drivers/usb/host/ehci-vf.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/usb/host/ehci-vf.c b/drivers/usb/host/ehci-vf.c > index 98e0fc6..351e0fb 100644 > --- a/drivers/usb/host/ehci-vf.c > +++ b/drivers/usb/host/ehci-vf.c > @@ -134,11 +134,6 @@ int ehci_hcd_init(int index, enum usb_init_type init, > if (index >= ARRAY_SIZE(nc_reg_bases)) > return -EINVAL; > > - if (init == USB_INIT_DEVICE && index == 1) > - return -ENODEV; > - if (init == USB_INIT_HOST && index == 0) > - return -ENODEV; > - > ehci = (struct usb_ehci *)nc_reg_bases[index]; > > /* Do board specific initialisation */ > -- > 2.6.2 >
On Friday, January 08, 2016 at 01:20:23 PM, maitysanchayan@gmail.com wrote: > Hello Stefano / Marek, > > Can you pick this up? I can, but only for next. Is that fine ? > - Sanchayan. > > On 15-10-26 18:28:49, Sanchayan Maity wrote: > > The current ehci-vf USB driver for Vybrid hardcodes the USB host > > and client functionality. Remove this. > > > > Reported-by: Santhosh Kumar Janardhanam <santhosh.kj@hcl.com> > > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com> > > --- > > > > drivers/usb/host/ehci-vf.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/usb/host/ehci-vf.c b/drivers/usb/host/ehci-vf.c > > index 98e0fc6..351e0fb 100644 > > --- a/drivers/usb/host/ehci-vf.c > > +++ b/drivers/usb/host/ehci-vf.c > > @@ -134,11 +134,6 @@ int ehci_hcd_init(int index, enum usb_init_type > > init, > > > > if (index >= ARRAY_SIZE(nc_reg_bases)) > > > > return -EINVAL; > > > > - if (init == USB_INIT_DEVICE && index == 1) > > - return -ENODEV; > > - if (init == USB_INIT_HOST && index == 0) > > - return -ENODEV; > > - > > > > ehci = (struct usb_ehci *)nc_reg_bases[index]; > > > > /* Do board specific initialisation */ Best regards, Marek Vasut
Hello Marek, On 16-01-08 13:26:32, Marek Vasut wrote: > On Friday, January 08, 2016 at 01:20:23 PM, maitysanchayan@gmail.com wrote: > > Hello Stefano / Marek, > > > > Can you pick this up? > > I can, but only for next. Is that fine ? Yes it's fine. Thank you. - Sanchayan. > > > > On 15-10-26 18:28:49, Sanchayan Maity wrote: > > > The current ehci-vf USB driver for Vybrid hardcodes the USB host > > > and client functionality. Remove this. > > > > > > Reported-by: Santhosh Kumar Janardhanam <santhosh.kj@hcl.com> > > > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com> > > > --- > > > > > > drivers/usb/host/ehci-vf.c | 5 ----- > > > 1 file changed, 5 deletions(-) > > > > > > diff --git a/drivers/usb/host/ehci-vf.c b/drivers/usb/host/ehci-vf.c > > > index 98e0fc6..351e0fb 100644 > > > --- a/drivers/usb/host/ehci-vf.c > > > +++ b/drivers/usb/host/ehci-vf.c > > > @@ -134,11 +134,6 @@ int ehci_hcd_init(int index, enum usb_init_type > > > init, > > > > > > if (index >= ARRAY_SIZE(nc_reg_bases)) > > > > > > return -EINVAL; > > > > > > - if (init == USB_INIT_DEVICE && index == 1) > > > - return -ENODEV; > > > - if (init == USB_INIT_HOST && index == 0) > > > - return -ENODEV; > > > - > > > > > > ehci = (struct usb_ehci *)nc_reg_bases[index]; > > > > > > /* Do board specific initialisation */ > > Best regards, > Marek Vasut
On Friday, January 08, 2016 at 01:20:23 PM, maitysanchayan@gmail.com wrote: > Hello Stefano / Marek, > > Can you pick this up? > Applied, will be in next MW. Best regards, Marek Vasut
diff --git a/drivers/usb/host/ehci-vf.c b/drivers/usb/host/ehci-vf.c index 98e0fc6..351e0fb 100644 --- a/drivers/usb/host/ehci-vf.c +++ b/drivers/usb/host/ehci-vf.c @@ -134,11 +134,6 @@ int ehci_hcd_init(int index, enum usb_init_type init, if (index >= ARRAY_SIZE(nc_reg_bases)) return -EINVAL; - if (init == USB_INIT_DEVICE && index == 1) - return -ENODEV; - if (init == USB_INIT_HOST && index == 0) - return -ENODEV; - ehci = (struct usb_ehci *)nc_reg_bases[index]; /* Do board specific initialisation */
The current ehci-vf USB driver for Vybrid hardcodes the USB host and client functionality. Remove this. Reported-by: Santhosh Kumar Janardhanam <santhosh.kj@hcl.com> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com> --- drivers/usb/host/ehci-vf.c | 5 ----- 1 file changed, 5 deletions(-)