From patchwork Tue May 25 23:19:29 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 53578 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 55B8DB7D1E for ; Wed, 26 May 2010 09:19:42 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933008Ab0EYXTU (ORCPT ); Tue, 25 May 2010 19:19:20 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:36796 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932617Ab0EYXTT (ORCPT ); Tue, 25 May 2010 19:19:19 -0400 Received: from localhost (localhost [127.0.0.1]) by sunset.davemloft.net (Postfix) with ESMTP id A187124C08E; Tue, 25 May 2010 16:19:29 -0700 (PDT) Date: Tue, 25 May 2010 16:19:29 -0700 (PDT) Message-Id: <20100525.161929.112591425.davem@davemloft.net> To: sfr@canb.auug.org.au Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, NeilJay@gmail.com Subject: Re: linux-next: build warning in Linus' tree From: David Miller In-Reply-To: <20100524.215822.13254177.davem@davemloft.net> References: <20100525114614.fd61d822.sfr@canb.auug.org.au> <20100524.215822.13254177.davem@davemloft.net> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Miller Date: Mon, 24 May 2010 21:58:22 -0700 (PDT) > From: Stephen Rothwell > Date: Tue, 25 May 2010 11:46:14 +1000 > >> Hi Dave, >> >> Today's linux-next build (x86_64 allmodconfig) produced this warning: >> >> drivers/net/usb/asix.c: In function 'asix_rx_fixup': >> drivers/net/usb/asix.c:325: warning: cast from pointer to integer of different size >> drivers/net/usb/asix.c:354: warning: cast from pointer to integer of different size >> >> Introduced by commit 3f78d1f210ff89af77f042ab7f4a8fee39feb1c9 >> ("drivers/net/usb/asix.c: Fix unaligned accesses"). This commit casts >> skb->data to u32. > > Thanks I'll look into this. Here is how I fixed this: -------------------- drivers/net/usb/asix.c: Fix pointer cast. Stephen Rothwell reports the following new warning: drivers/net/usb/asix.c: In function 'asix_rx_fixup': drivers/net/usb/asix.c:325: warning: cast from pointer to integer of different size drivers/net/usb/asix.c:354: warning: cast from pointer to integer of different size The code just cares about the low alignment bits, so use an "unsigned long" cast instead of one to "u32". Signed-off-by: David S. Miller --- drivers/net/usb/asix.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c index 31b7331..ea75f47 100644 --- a/drivers/net/usb/asix.c +++ b/drivers/net/usb/asix.c @@ -322,7 +322,7 @@ static int asix_rx_fixup(struct usbnet *dev, struct sk_buff *skb) size = (u16) (header & 0x0000ffff); if ((skb->len) - ((size + 1) & 0xfffe) == 0) { - u8 alignment = (u32)skb->data & 0x3; + u8 alignment = (unsigned long)skb->data & 0x3; if (alignment != 0x2) { /* * not 16bit aligned so use the room provided by