diff mbox

[U-Boot,2/5] driver: dwmmc: Fix pointer conversion warnings for hikey

Message ID 1445759305-26256-1-git-send-email-prabhakar@freescale.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Prabhakar Kushwaha Oct. 25, 2015, 7:48 a.m. UTC
Fix below compilation warings happening for hikey_defconfig

drivers/mmc/dw_mmc.c: In function ‘dwmci_set_idma_desc’:
drivers/mmc/dw_mmc.c:43:20: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
  desc->next_addr = (unsigned int)desc + sizeof(struct dwmci_idmac);
                    ^
drivers/mmc/dw_mmc.c: In function ‘dwmci_prepare_data’:
drivers/mmc/dw_mmc.c:61:35: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
  dwmci_writel(host, DWMCI_DBADDR, (unsigned int)cur_idmac);
                                   ^
drivers/mmc/dw_mmc.c:73:9: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
         (u32)bounce_buffer + (i * PAGE_SIZE));
         ^
  CC      drivers/mmc/hi6220_dw_mmc.o
drivers/mmc/hi6220_dw_mmc.c: In function ‘hi6220_dwmci_add_port’:
drivers/mmc/hi6220_dw_mmc.c:51:17: warning: cast to pointer from integer
of different size [-Wint-to-pointer-cast]
  host->ioaddr = (void *)regbase;

Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
 drivers/mmc/dw_mmc.c        | 6 +++---
 drivers/mmc/hi6220_dw_mmc.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Tom Rini Nov. 13, 2015, 1:28 a.m. UTC | #1
On Sun, Oct 25, 2015 at 01:18:25PM +0530, Prabhakar Kushwaha wrote:

> Fix below compilation warings happening for hikey_defconfig
> 
> drivers/mmc/dw_mmc.c: In function ‘dwmci_set_idma_desc’:
> drivers/mmc/dw_mmc.c:43:20: warning: cast from pointer to integer
> of different size [-Wpointer-to-int-cast]
>   desc->next_addr = (unsigned int)desc + sizeof(struct dwmci_idmac);
>                     ^
> drivers/mmc/dw_mmc.c: In function ‘dwmci_prepare_data’:
> drivers/mmc/dw_mmc.c:61:35: warning: cast from pointer to integer
> of different size [-Wpointer-to-int-cast]
>   dwmci_writel(host, DWMCI_DBADDR, (unsigned int)cur_idmac);
>                                    ^
> drivers/mmc/dw_mmc.c:73:9: warning: cast from pointer to integer
> of different size [-Wpointer-to-int-cast]
>          (u32)bounce_buffer + (i * PAGE_SIZE));
>          ^
>   CC      drivers/mmc/hi6220_dw_mmc.o
> drivers/mmc/hi6220_dw_mmc.c: In function ‘hi6220_dwmci_add_port’:
> drivers/mmc/hi6220_dw_mmc.c:51:17: warning: cast to pointer from integer
> of different size [-Wint-to-pointer-cast]
>   host->ioaddr = (void *)regbase;
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
index 26d34ae..4375abc 100644
--- a/drivers/mmc/dw_mmc.c
+++ b/drivers/mmc/dw_mmc.c
@@ -40,7 +40,7 @@  static void dwmci_set_idma_desc(struct dwmci_idmac *idmac,
 	desc->flags = desc0;
 	desc->cnt = desc1;
 	desc->addr = desc2;
-	desc->next_addr = (unsigned int)desc + sizeof(struct dwmci_idmac);
+	desc->next_addr = (ulong)desc + sizeof(struct dwmci_idmac);
 }
 
 static void dwmci_prepare_data(struct dwmci_host *host,
@@ -58,7 +58,7 @@  static void dwmci_prepare_data(struct dwmci_host *host,
 	dwmci_wait_reset(host, DWMCI_CTRL_FIFO_RESET);
 
 	data_start = (ulong)cur_idmac;
-	dwmci_writel(host, DWMCI_DBADDR, (unsigned int)cur_idmac);
+	dwmci_writel(host, DWMCI_DBADDR, (ulong)cur_idmac);
 
 	do {
 		flags = DWMCI_IDMAC_OWN | DWMCI_IDMAC_CH ;
@@ -70,7 +70,7 @@  static void dwmci_prepare_data(struct dwmci_host *host,
 			cnt = data->blocksize * 8;
 
 		dwmci_set_idma_desc(cur_idmac, flags, cnt,
-				    (u32)bounce_buffer + (i * PAGE_SIZE));
+				    (ulong)bounce_buffer + (i * PAGE_SIZE));
 
 		if (blk_cnt <= 8)
 			break;
diff --git a/drivers/mmc/hi6220_dw_mmc.c b/drivers/mmc/hi6220_dw_mmc.c
index 731458c..b0d063c 100644
--- a/drivers/mmc/hi6220_dw_mmc.c
+++ b/drivers/mmc/hi6220_dw_mmc.c
@@ -48,7 +48,7 @@  int hi6220_dwmci_add_port(int index, u32 regbase, int bus_width)
 		return -ENOMEM;
 	}
 
-	host->ioaddr = (void *)regbase;
+	host->ioaddr = (void *)(ulong)regbase;
 	host->buswidth = bus_width;
 	host->bus_hz = MMC0_DEFAULT_FREQ;