| Message ID | 1445720476-21517-24-git-send-email-romain.naour@openwide.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
Romain, All, On 2015-10-24 23:01 +0200, Romain Naour spake thusly: > Signed-off-by: Romain Naour <romain.naour@openwide.fr> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> However, see a comment/question below... > --- > package/efl/efl.mk | 2 ++ > package/efl/libefl/libefl.mk | 3 +-- > package/efl/libelementary/libelementary.mk | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/package/efl/efl.mk b/package/efl/efl.mk > index 99e4d14..151ac28 100644 > --- a/package/efl/efl.mk > +++ b/package/efl/efl.mk > @@ -1,2 +1,4 @@ > > +EFL_VERSION = 1.15.2 > + > include $(sort $(wildcard package/efl/*/*.mk)) > diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk > index 8ddca64..6aaa08b 100644 > --- a/package/efl/libefl/libefl.mk > +++ b/package/efl/libefl/libefl.mk > @@ -4,8 +4,7 @@ > # > ################################################################################ > > -# hardcode the version here since the bump to 1.15 is not complete in Buildroot > -LIBEFL_VERSION = 1.15.2 > +LIBEFL_VERSION = $(EFL_VERSION) > LIBEFL_SOURCE = efl-$(LIBEFL_VERSION).tar.xz > LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl > LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+ > diff --git a/package/efl/libelementary/libelementary.mk b/package/efl/libelementary/libelementary.mk > index 4ba8681..c920801 100644 > --- a/package/efl/libelementary/libelementary.mk > +++ b/package/efl/libelementary/libelementary.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -LIBELEMENTARY_VERSION = 1.15.2 > +LIBELEMENTARY_VERSION = $(EFL_VERSION) Even though this is true right now, will that ever be the case? I.e. are we sure libefl and libelementary will always be released in tandem? Regards, Yann E. MORIN. > LIBELEMENTARY_SOURCE = elementary-$(LIBELEMENTARY_VERSION).tar.xz > LIBELEMENTARY_SITE = http://download.enlightenment.org/rel/libs/elementary > LIBELEMENTARY_LICENSE = LGPLv2.1 > -- > 2.4.3 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/package/efl/efl.mk b/package/efl/efl.mk index 99e4d14..151ac28 100644 --- a/package/efl/efl.mk +++ b/package/efl/efl.mk @@ -1,2 +1,4 @@ +EFL_VERSION = 1.15.2 + include $(sort $(wildcard package/efl/*/*.mk)) diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk index 8ddca64..6aaa08b 100644 --- a/package/efl/libefl/libefl.mk +++ b/package/efl/libefl/libefl.mk @@ -4,8 +4,7 @@ # ################################################################################ -# hardcode the version here since the bump to 1.15 is not complete in Buildroot -LIBEFL_VERSION = 1.15.2 +LIBEFL_VERSION = $(EFL_VERSION) LIBEFL_SOURCE = efl-$(LIBEFL_VERSION).tar.xz LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+ diff --git a/package/efl/libelementary/libelementary.mk b/package/efl/libelementary/libelementary.mk index 4ba8681..c920801 100644 --- a/package/efl/libelementary/libelementary.mk +++ b/package/efl/libelementary/libelementary.mk @@ -4,7 +4,7 @@ # ################################################################################ -LIBELEMENTARY_VERSION = 1.15.2 +LIBELEMENTARY_VERSION = $(EFL_VERSION) LIBELEMENTARY_SOURCE = elementary-$(LIBELEMENTARY_VERSION).tar.xz LIBELEMENTARY_SITE = http://download.enlightenment.org/rel/libs/elementary LIBELEMENTARY_LICENSE = LGPLv2.1
Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- package/efl/efl.mk | 2 ++ package/efl/libefl/libefl.mk | 3 +-- package/efl/libelementary/libelementary.mk | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-)