diff mbox

[1/1] Revert "package/swupdate: add patch to fix build issue with some toolchains"

Message ID 1445691845-17624-1-git-send-email-bjorn.forsman@gmail.com
State Accepted
Commit 9f3c0bc55175123853719209e3863baee7e17773
Headers show

Commit Message

Bjørn Forsman Oct. 24, 2015, 1:04 p.m. UTC
This patch caused an unfortunate regression that prevents any handlers
from being registered (runtime issue). This means swupdate cannot
perform any update. Upstream has reverted it.

See discussion:
https://groups.google.com/d/msg/swupdate/oVIhJmYPT8A/eq3uZvYVDQAJ

This reverts commit a8cc6eeec5a665db5689083312beef14a9afbafa.

Signed-off-by: Bjørn Forsman <bjorn.forsman@gmail.com>
---
 package/swupdate/swupdate.hash | 1 -
 package/swupdate/swupdate.mk   | 1 -
 2 files changed, 2 deletions(-)

Comments

Yann E. MORIN Oct. 24, 2015, 4:21 p.m. UTC | #1
Bjørn, All,

On 2015-10-24 15:04 +0200, Bjørn Forsman spake thusly:
> This patch caused an unfortunate regression that prevents any handlers
> from being registered (runtime issue). This means swupdate cannot
> perform any update. Upstream has reverted it.
> 
> See discussion:
> https://groups.google.com/d/msg/swupdate/oVIhJmYPT8A/eq3uZvYVDQAJ
> 
> This reverts commit a8cc6eeec5a665db5689083312beef14a9afbafa.
> 
> Signed-off-by: Bjørn Forsman <bjorn.forsman@gmail.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/swupdate/swupdate.hash | 1 -
>  package/swupdate/swupdate.mk   | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/package/swupdate/swupdate.hash b/package/swupdate/swupdate.hash
> index 96ebedf..eb7722c 100644
> --- a/package/swupdate/swupdate.hash
> +++ b/package/swupdate/swupdate.hash
> @@ -1,4 +1,3 @@
>  # Locally calculated
>  sha256	1410f8967aad0f4d3b4561110dbfb2c1f8e337bdc332f6b120f4995762c8bf6b  swupdate-2015.07.tar.gz
> -sha256	ec633171e6a893506fad6b96fb2b258d60a023c03be5520b968a1d5cc6bafe6e  c3467290925b2a833a68d9db12c198fdca752e32.patch
>  sha256	6cffe115cad73c0d1095f7880b6d2b97fc12b7f7871f532e5b33717e863f03d7  5a5ef5909f5da5b2070d58ffaee924bb8e6a51e1.patch
> diff --git a/package/swupdate/swupdate.mk b/package/swupdate/swupdate.mk
> index 68f6e2c..bcdc764 100644
> --- a/package/swupdate/swupdate.mk
> +++ b/package/swupdate/swupdate.mk
> @@ -9,7 +9,6 @@ SWUPDATE_SITE = $(call github,sbabic,swupdate,$(SWUPDATE_VERSION))
>  SWUPDATE_LICENSE = GPLv2+, MIT, Public Domain
>  SWUPDATE_LICENSE_FILES = COPYING
>  SWUPDATE_PATCH = \
> -	https://github.com/sbabic/swupdate/commit/c3467290925b2a833a68d9db12c198fdca752e32.patch \
>  	https://github.com/sbabic/swupdate/commit/5a5ef5909f5da5b2070d58ffaee924bb8e6a51e1.patch
>  
>  # swupdate bundles its own version of mongoose (version 3.8) and
> -- 
> 2.5.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Jörg Krause Oct. 26, 2015, 7:55 p.m. UTC | #2
On Sa, 2015-10-24 at 15:04 +0200, Bjørn Forsman wrote:
> This patch caused an unfortunate regression that prevents any
> handlers
> from being registered (runtime issue). This means swupdate cannot
> perform any update. Upstream has reverted it.
> 
> See discussion:
> https://groups.google.com/d/msg/swupdate/oVIhJmYPT8A/eq3uZvYVDQAJ
> 
> This reverts commit a8cc6eeec5a665db5689083312beef14a9afbafa.
> 
> Signed-off-by: Bjørn Forsman <bjorn.forsman@gmail.com>
> ---

Acked-by: Jörg Krause <joerg.krause@embedded.rocks>
Peter Korsgaard Oct. 26, 2015, 9:58 p.m. UTC | #3
>>>>> "Bjørn" == Bjørn Forsman <bjorn.forsman@gmail.com> writes:

 > This patch caused an unfortunate regression that prevents any handlers
 > from being registered (runtime issue). This means swupdate cannot
 > perform any update. Upstream has reverted it.

 > See discussion:
 > https://groups.google.com/d/msg/swupdate/oVIhJmYPT8A/eq3uZvYVDQAJ

 > This reverts commit a8cc6eeec5a665db5689083312beef14a9afbafa.

 > Signed-off-by: Bjørn Forsman <bjorn.forsman@gmail.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/swupdate/swupdate.hash b/package/swupdate/swupdate.hash
index 96ebedf..eb7722c 100644
--- a/package/swupdate/swupdate.hash
+++ b/package/swupdate/swupdate.hash
@@ -1,4 +1,3 @@ 
 # Locally calculated
 sha256	1410f8967aad0f4d3b4561110dbfb2c1f8e337bdc332f6b120f4995762c8bf6b  swupdate-2015.07.tar.gz
-sha256	ec633171e6a893506fad6b96fb2b258d60a023c03be5520b968a1d5cc6bafe6e  c3467290925b2a833a68d9db12c198fdca752e32.patch
 sha256	6cffe115cad73c0d1095f7880b6d2b97fc12b7f7871f532e5b33717e863f03d7  5a5ef5909f5da5b2070d58ffaee924bb8e6a51e1.patch
diff --git a/package/swupdate/swupdate.mk b/package/swupdate/swupdate.mk
index 68f6e2c..bcdc764 100644
--- a/package/swupdate/swupdate.mk
+++ b/package/swupdate/swupdate.mk
@@ -9,7 +9,6 @@  SWUPDATE_SITE = $(call github,sbabic,swupdate,$(SWUPDATE_VERSION))
 SWUPDATE_LICENSE = GPLv2+, MIT, Public Domain
 SWUPDATE_LICENSE_FILES = COPYING
 SWUPDATE_PATCH = \
-	https://github.com/sbabic/swupdate/commit/c3467290925b2a833a68d9db12c198fdca752e32.patch \
 	https://github.com/sbabic/swupdate/commit/5a5ef5909f5da5b2070d58ffaee924bb8e6a51e1.patch
 
 # swupdate bundles its own version of mongoose (version 3.8) and