| Message ID | 84027326a9f437b9c829a3a6f1e7c4616bf1ae1e.1445545973.git.yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
On 22-10-15 22:34, Yann E. MORIN wrote: > distclean is supposed to return the current directory, whether in-tree > or out-of-tree, into pristine conditions, which means we should also > forget about any br2-external tree on distclean. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: Peter Korsgaard <jacmet@uclibc.org> > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> > Cc: Arnout Vandecappelle <arnout@mind.be> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> That said: why don't we just remove $(O) unconditionally? Note that this can be applied independently of the rest of the series. Regards, Arnout > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 052f58a..0e25bd1 100644 > --- a/Makefile > +++ b/Makefile > @@ -839,7 +839,7 @@ ifeq ($(O),output) > rm -rf $(O) > endif > rm -rf $(BR2_CONFIG) $(CONFIG_DIR)/.config.old $(CONFIG_DIR)/..config.tmp \ > - $(CONFIG_DIR)/.auto.deps > + $(CONFIG_DIR)/.auto.deps $(BR2_EXTERNAL_FILE) > > help: > @echo 'Cleaning:' >
Dear Yann E. MORIN, On Thu, 22 Oct 2015 22:34:00 +0200, Yann E. MORIN wrote: > distclean is supposed to return the current directory, whether in-tree > or out-of-tree, into pristine conditions, which means we should also > forget about any br2-external tree on distclean. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: Peter Korsgaard <jacmet@uclibc.org> > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> > Cc: Arnout Vandecappelle <arnout@mind.be> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Thomas
diff --git a/Makefile b/Makefile index 052f58a..0e25bd1 100644 --- a/Makefile +++ b/Makefile @@ -839,7 +839,7 @@ ifeq ($(O),output) rm -rf $(O) endif rm -rf $(BR2_CONFIG) $(CONFIG_DIR)/.config.old $(CONFIG_DIR)/..config.tmp \ - $(CONFIG_DIR)/.auto.deps + $(CONFIG_DIR)/.auto.deps $(BR2_EXTERNAL_FILE) help: @echo 'Cleaning:'
distclean is supposed to return the current directory, whether in-tree or out-of-tree, into pristine conditions, which means we should also forget about any br2-external tree on distclean. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Peter Korsgaard <jacmet@uclibc.org> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> Cc: Arnout Vandecappelle <arnout@mind.be> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)