diff mbox

[net-next] net: encx24j600: Fix mask to update LED configuration

Message ID 1445540944-13894-1-git-send-email-jon@ringle.org
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Jon Ringle Oct. 22, 2015, 7:09 p.m. UTC
From: Jon Ringle <jringle@gridpoint.com>

This fixes the mask used to update the LED configuration so that it clears
the necessary bits as well as setting the bits according to the mask.
Also reverse the LED configuration to show the Link state + collisions in
LEDA and the Link state + TX/RX events in LEDB.

Signed-off-by: Jon Ringle <jringle@gridpoint.com>
---
 drivers/net/ethernet/microchip/encx24j600.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

David Miller Oct. 26, 2015, 1:24 a.m. UTC | #1
From: jon@ringle.org
Date: Thu, 22 Oct 2015 15:09:04 -0400

> From: Jon Ringle <jringle@gridpoint.com>
> 
> This fixes the mask used to update the LED configuration so that it clears
> the necessary bits as well as setting the bits according to the mask.
> Also reverse the LED configuration to show the Link state + collisions in
> LEDA and the Link state + TX/RX events in LEDB.
> 
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/microchip/encx24j600.c b/drivers/net/ethernet/microchip/encx24j600.c
index e1329d9..bf08ce2 100644
--- a/drivers/net/ethernet/microchip/encx24j600.c
+++ b/drivers/net/ethernet/microchip/encx24j600.c
@@ -617,10 +617,10 @@  static int encx24j600_hw_init(struct encx24j600_priv *priv)
 		   (eidled & REVID_MASK) >> REVID_SHIFT);
 
 	/* PHY Leds: link status,
-	 * LEDA: Link + transmit/receive events
-	 * LEDB: Link State + colision events
+	 * LEDA: Link State + collision events
+	 * LEDB: Link State + transmit/receive events
 	 */
-	encx24j600_update_reg(priv, EIDLED, 0xbc00, 0xbc00);
+	encx24j600_update_reg(priv, EIDLED, 0xff00, 0xcb00);
 
 	/* Loopback disabled */
 	encx24j600_write_reg(priv, MACON1, 0x9);