From patchwork Mon May 24 14:55:39 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: C de-Avillez X-Patchwork-Id: 53427 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0636AB7D17 for ; Tue, 25 May 2010 01:06:33 +1000 (EST) Received: from localhost ([127.0.0.1]:49930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGZEb-0000ud-C7 for incoming@patchwork.ozlabs.org; Mon, 24 May 2010 11:06:29 -0400 Received: from [140.186.70.92] (port=39301 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGZDr-0000tg-N2 for qemu-devel@nongnu.org; Mon, 24 May 2010 11:05:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGZDp-0006rx-Ip for qemu-devel@nongnu.org; Mon, 24 May 2010 11:05:43 -0400 Received: from adelie.canonical.com ([91.189.90.139]:59167) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGZDp-0006re-BL for qemu-devel@nongnu.org; Mon, 24 May 2010 11:05:41 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1OGZDn-0001Rb-Gu for ; Mon, 24 May 2010 16:05:39 +0100 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 607272E840F for ; Mon, 24 May 2010 16:05:38 +0100 (BST) MIME-Version: 1.0 Date: Mon, 24 May 2010 14:55:39 -0000 From: C de-Avillez To: qemu-devel@nongnu.org X-Launchpad-Bug: product=qemu; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug: distribution=ubuntu; sourcepackage=qemu-kvm; component=main; status=Triaged; importance=Medium; assignee=None; X-Launchpad-Bug: distribution=ubuntu; distroseries=lucid; sourcepackage=qemu-kvm; component=main; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug: distribution=debian; sourcepackage=qemu-kvm; component=None; status=Unknown; importance=Unknown; assignee=None; X-Launchpad-Bug-Tags: patch X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: hggdh2 lool mjt+launchpad-tls References: <20100522092104.29268.17427.malonedeb@soybean.canonical.com> Message-Id: <20100524145540.2991.38177.malone@palladium.canonical.com> X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="None"; Instance="initZopeless config overlay" X-Launchpad-Hash: eb21683cb3dd76a9faffcce7daeb2a5a3072ee43 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: [Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Reply-To: Bug 584143 <584143@bugs.launchpad.net> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Marking Triaged/Medium. Debian has accepted the patch, and a new (patched) package is in Unstable. May be considered for SRU-ing into 10.04 LTS, so nominating. ** Changed in: qemu-kvm (Ubuntu) Importance: Undecided => Medium ** Changed in: qemu-kvm (Ubuntu) Status: New => Triaged ** Also affects: qemu-kvm (Ubuntu Lucid) Importance: Undecided Status: New --- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900 +++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900 @@ -2397,7 +2397,7 @@ dinfo->on_write_error = on_write_error; dinfo->opts = opts; if (serial) - strncpy(dinfo->serial, serial, sizeof(serial)); + strncpy(dinfo->serial, serial, sizeof(dinfo->serial)); QTAILQ_INSERT_TAIL(&drives, dinfo, next); if (is_extboot) { extboot_drive = dinfo;