Patchwork [LUCID,3/6] HID: ntrig: explain firmware quirk

login
register
mail settings
Submitter Chase Douglas
Date May 24, 2010, 1:54 p.m.
Message ID <1274709274-1731-4-git-send-email-chase.douglas@canonical.com>
Download mbox | patch
Permalink /patch/53420/
State Accepted
Delegated to: Stefan Bader
Headers show

Comments

Chase Douglas - May 24, 2010, 1:54 p.m.
From: Jiri Kosina <jkosina@suse.cz>

Commit 6549981bc54777c ("HID: fix N-trig touch panel with recent firmware")
adds a quirk that is needed for devices with more recent firmware so that
they become operational.

As it's not directly obvious from the code why is it needed, a comment
is worthwile.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit c0858552c088616c18879c347d9e0daa98cf2b15)

BugLink: http://bugs.launchpad.net/bugs/583531

Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
 drivers/hid/hid-ntrig.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Patch

diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
index 74b3d98..f60454a 100644
--- a/drivers/hid/hid-ntrig.c
+++ b/drivers/hid/hid-ntrig.c
@@ -351,7 +351,8 @@  static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id)
 		}
 	}
 
-	report = hdev->report_enum[HID_FEATURE_REPORT].report_id_hash[0x0a]; 
+	/* This is needed for devices with more recent firmware versions */
+	report = hdev->report_enum[HID_FEATURE_REPORT].report_id_hash[0x0a];
 	if (report)
 		usbhid_submit_report(hdev, report, USB_DIR_OUT);