Patchwork [LUCID,1/6] HID: remove MODULE_VERSION from new drivers

login
register
mail settings
Submitter Chase Douglas
Date May 24, 2010, 1:54 p.m.
Message ID <1274709274-1731-2-git-send-email-chase.douglas@canonical.com>
Download mbox | patch
Permalink /patch/53419/
State Accepted
Delegated to: Stefan Bader
Headers show

Comments

Chase Douglas - May 24, 2010, 1:54 p.m.
From: Jiri Kosina <jkosina@suse.cz>

MODULE_VERSION doesn't make too much sense for drivers merged
into main tree, as git is much better tracking revisions than
any developer might ever be.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit c8a8602b76b6703df1243e31be01cf0e4451e4a6)

BugLink: http://bugs.launchpad.net/bugs/583531

Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
 drivers/hid/hid-3m-pct.c  |    1 -
 drivers/hid/hid-mosart.c  |    1 -
 drivers/hid/hid-quanta.c  |    1 -
 drivers/hid/hid-stantum.c |    1 -
 4 files changed, 0 insertions(+), 4 deletions(-)

Patch

diff --git a/drivers/hid/hid-3m-pct.c b/drivers/hid/hid-3m-pct.c
index 6d11e3d..2370aef 100644
--- a/drivers/hid/hid-3m-pct.c
+++ b/drivers/hid/hid-3m-pct.c
@@ -17,7 +17,6 @@ 
 #include <linux/module.h>
 #include <linux/usb.h>
 
-MODULE_VERSION("0.6");
 MODULE_AUTHOR("Stephane Chatty <chatty@enac.fr>");
 MODULE_DESCRIPTION("3M PCT multitouch panels");
 MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-mosart.c b/drivers/hid/hid-mosart.c
index f6ec4f1..c871816 100644
--- a/drivers/hid/hid-mosart.c
+++ b/drivers/hid/hid-mosart.c
@@ -19,7 +19,6 @@ 
 #include <linux/usb.h>
 #include "usbhid/usbhid.h"
 
-MODULE_VERSION("1.00");
 MODULE_AUTHOR("Stephane Chatty <chatty@enac.fr>");
 MODULE_DESCRIPTION("MosArt dual-touch panel");
 MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-quanta.c b/drivers/hid/hid-quanta.c
index 9ac4928..01dd51c 100644
--- a/drivers/hid/hid-quanta.c
+++ b/drivers/hid/hid-quanta.c
@@ -16,7 +16,6 @@ 
 #include <linux/hid.h>
 #include <linux/module.h>
 
-MODULE_VERSION("1.00");
 MODULE_AUTHOR("Stephane Chatty <chatty@enac.fr>");
 MODULE_DESCRIPTION("Quanta dual-touch panel");
 MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-stantum.c b/drivers/hid/hid-stantum.c
index 04b0b98..2e592a0 100644
--- a/drivers/hid/hid-stantum.c
+++ b/drivers/hid/hid-stantum.c
@@ -16,7 +16,6 @@ 
 #include <linux/hid.h>
 #include <linux/module.h>
 
-MODULE_VERSION("0.6");
 MODULE_AUTHOR("Stephane Chatty <chatty@enac.fr>");
 MODULE_DESCRIPTION("Stantum HID multitouch panels");
 MODULE_LICENSE("GPL");