| Message ID | 1445437773-23261-1-git-send-email-linux@roeck-us.net |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Guenter Roeck <linux@roeck-us.net> Date: Wed, 21 Oct 2015 07:29:33 -0700 > The Hisilicon network driver does not build for Sparc. Enabling > COMPILE_TEST for it causes Sparc allmodconfig/allyesconfig builds > to fail with > > drivers/net/ethernet/hisilicon/hns_mdio.c: In function 'hns_mdio_bus_name': > drivers/net/ethernet/hisilicon/hns_mdio.c:409:3: error: > implicit declaration of function 'of_translate_address' > > Fixes: 876133d3161d ("net: hisilicon: add OF dependency") > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> I wish we would really resolve this properly instead of hacking crap like this all the time, it's stupid. SPARC simply never needs to "translate" OF addresses, since all OF resources are fully translated already at boot time during OF tree import. All IRQs are fully resolved as well. So we could simply make of_translate_address() a NOP. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig index f250dec488fd..413935085591 100644 --- a/drivers/net/ethernet/hisilicon/Kconfig +++ b/drivers/net/ethernet/hisilicon/Kconfig @@ -5,7 +5,7 @@ config NET_VENDOR_HISILICON bool "Hisilicon devices" default y - depends on OF && (ARM || ARM64 || COMPILE_TEST) + depends on OF && (ARM || ARM64 || COMPILE_TEST) && !SPARC ---help--- If you have a network (Ethernet) card belonging to this class, say Y.
The Hisilicon network driver does not build for Sparc. Enabling COMPILE_TEST for it causes Sparc allmodconfig/allyesconfig builds to fail with drivers/net/ethernet/hisilicon/hns_mdio.c: In function 'hns_mdio_bus_name': drivers/net/ethernet/hisilicon/hns_mdio.c:409:3: error: implicit declaration of function 'of_translate_address' Fixes: 876133d3161d ("net: hisilicon: add OF dependency") Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/net/ethernet/hisilicon/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)