diff mbox

[1/1] sdl: fix incorrect SDL_CONF_OPTS assignment

Message ID 1445397025-21211-1-git-send-email-rprebello@gmail.com
State Accepted
Commit 3b884e44e0ef857eef1e95719c2e230b687e79a2
Headers show

Commit Message

Rodrigo Rebello Oct. 21, 2015, 3:10 a.m. UTC 
The option --enable-video-directfb=no was being assigned to
SDL_CONF_OPTS instead of being appended to it when
BR2_PACKAGE_SDL_DIRECTFB was disabled. That would clobber any options
previously added to SDL_CONF_OPTS (namely --enable-video-fbcon=yes|no).

Signed-off-by: Rodrigo Rebello <rprebello@gmail.com>
---
 package/sdl/sdl.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard Oct. 21, 2015, 8:07 a.m. UTC | #1 
>>>>> "Rodrigo" == Rodrigo Rebello <rprebello@gmail.com> writes:

 > The option --enable-video-directfb=no was being assigned to
 > SDL_CONF_OPTS instead of being appended to it when
 > BR2_PACKAGE_SDL_DIRECTFB was disabled. That would clobber any options
 > previously added to SDL_CONF_OPTS (namely --enable-video-fbcon=yes|no).

 > Signed-off-by: Rodrigo Rebello <rprebello@gmail.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
index 05d9a54..78eb4dd 100644
--- a/package/sdl/sdl.mk
+++ b/package/sdl/sdl.mk
@@ -34,7 +34,7 @@  SDL_DEPENDENCIES += directfb
 SDL_CONF_OPTS += --enable-video-directfb=yes
 SDL_CONF_ENV = ac_cv_path_DIRECTFBCONFIG=$(STAGING_DIR)/usr/bin/directfb-config
 else
-SDL_CONF_OPTS = --enable-video-directfb=no
+SDL_CONF_OPTS += --enable-video-directfb=no
 endif
 
 ifeq ($(BR2_PACKAGE_SDL_QTOPIA),y)