diff mbox

[1/2] dt-bindings: Consolidate Exynos SoC bindings under Samsung directory

Message ID 1445391051-3727-1-git-send-email-k.kozlowski@samsung.com
State New
Headers show

Commit Message

Krzysztof Kozlowski Oct. 21, 2015, 1:30 a.m. UTC
Exynos SoC Device Tree bindings are spread over arm/exynos/ and
arm/samsung/ directories. There is no need for that separation and it
actually confuses. Put everything under arm/samsung/.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>
---
 .../devicetree/bindings/arm/{exynos => samsung}/power_domain.txt          | 0
 Documentation/devicetree/bindings/arm/{ => samsung}/samsung-boards.txt    | 0
 Documentation/devicetree/bindings/arm/{exynos => samsung}/smp-sysram.txt  | 0
 3 files changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/arm/{exynos => samsung}/power_domain.txt (100%)
 rename Documentation/devicetree/bindings/arm/{ => samsung}/samsung-boards.txt (100%)
 rename Documentation/devicetree/bindings/arm/{exynos => samsung}/smp-sysram.txt (100%)

Comments

Javier Martinez Canillas Oct. 21, 2015, 8:38 a.m. UTC | #1
Hello Krzysztof,

On 10/21/2015 03:30 AM, Krzysztof Kozlowski wrote:
> Exynos SoC Device Tree bindings are spread over arm/exynos/ and
> arm/samsung/ directories. There is no need for that separation and it
> actually confuses. Put everything under arm/samsung/.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> ---

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
Javier Martinez Canillas Oct. 21, 2015, 8:39 a.m. UTC | #2
Hello Krzysztof,

On 10/21/2015 03:30 AM, Krzysztof Kozlowski wrote:
> Document compatibles used on other Exynos-based boards (non-Samsung):
> FriendlyARM, Google, Hardkernel and Insignal.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
> Cc: Hakjoo Kim <ruppi.kim@hardkernel.com>
> ---

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
Rob Herring Oct. 22, 2015, 12:22 a.m. UTC | #3
On Tue, Oct 20, 2015 at 8:30 PM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> Exynos SoC Device Tree bindings are spread over arm/exynos/ and
> arm/samsung/ directories. There is no need for that separation and it
> actually confuses. Put everything under arm/samsung/.

Thanks for the clean-up.

>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> ---
>  .../devicetree/bindings/arm/{exynos => samsung}/power_domain.txt          | 0
>  Documentation/devicetree/bindings/arm/{ => samsung}/samsung-boards.txt    | 0
>  Documentation/devicetree/bindings/arm/{exynos => samsung}/smp-sysram.txt  | 0
>  3 files changed, 0 insertions(+), 0 deletions(-)
>  rename Documentation/devicetree/bindings/arm/{exynos => samsung}/power_domain.txt (100%)

I'd rather see this with other power domain bindings. So
bindings/power/pd-samsung.txt I guess.

>  rename Documentation/devicetree/bindings/arm/{ => samsung}/samsung-boards.txt (100%)
>  rename Documentation/devicetree/bindings/arm/{exynos => samsung}/smp-sysram.txt (100%)

Probably need to move misc/sram.txt to bindings/sram/ and put both there.

Rob

>
> diff --git a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt b/Documentation/devicetree/bindings/arm/samsung/power_domain.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/arm/exynos/power_domain.txt
> rename to Documentation/devicetree/bindings/arm/samsung/power_domain.txt
> diff --git a/Documentation/devicetree/bindings/arm/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/arm/samsung-boards.txt
> rename to Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> diff --git a/Documentation/devicetree/bindings/arm/exynos/smp-sysram.txt b/Documentation/devicetree/bindings/arm/samsung/smp-sysram.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/arm/exynos/smp-sysram.txt
> rename to Documentation/devicetree/bindings/arm/samsung/smp-sysram.txt
> --
> 1.9.1
>
Krzysztof Kozlowski Oct. 22, 2015, 12:26 a.m. UTC | #4
On 22.10.2015 09:22, Rob Herring wrote:
> On Tue, Oct 20, 2015 at 8:30 PM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> Exynos SoC Device Tree bindings are spread over arm/exynos/ and
>> arm/samsung/ directories. There is no need for that separation and it
>> actually confuses. Put everything under arm/samsung/.
> 
> Thanks for the clean-up.
> 
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Cc: Kukjin Kim <kgene@kernel.org>
>> ---
>>  .../devicetree/bindings/arm/{exynos => samsung}/power_domain.txt          | 0
>>  Documentation/devicetree/bindings/arm/{ => samsung}/samsung-boards.txt    | 0
>>  Documentation/devicetree/bindings/arm/{exynos => samsung}/smp-sysram.txt  | 0
>>  3 files changed, 0 insertions(+), 0 deletions(-)
>>  rename Documentation/devicetree/bindings/arm/{exynos => samsung}/power_domain.txt (100%)
> 
> I'd rather see this with other power domain bindings. So
> bindings/power/pd-samsung.txt I guess.

OK

> 
>>  rename Documentation/devicetree/bindings/arm/{ => samsung}/samsung-boards.txt (100%)
>>  rename Documentation/devicetree/bindings/arm/{exynos => samsung}/smp-sysram.txt (100%)
> 
> Probably need to move misc/sram.txt to bindings/sram/ and put both there.

Right, that make sense. I'll send v2 moving pd-samsung and smp-sysram to
these locations.

Best regards,
Krzysztof
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt b/Documentation/devicetree/bindings/arm/samsung/power_domain.txt
similarity index 100%
rename from Documentation/devicetree/bindings/arm/exynos/power_domain.txt
rename to Documentation/devicetree/bindings/arm/samsung/power_domain.txt
diff --git a/Documentation/devicetree/bindings/arm/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
similarity index 100%
rename from Documentation/devicetree/bindings/arm/samsung-boards.txt
rename to Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
diff --git a/Documentation/devicetree/bindings/arm/exynos/smp-sysram.txt b/Documentation/devicetree/bindings/arm/samsung/smp-sysram.txt
similarity index 100%
rename from Documentation/devicetree/bindings/arm/exynos/smp-sysram.txt
rename to Documentation/devicetree/bindings/arm/samsung/smp-sysram.txt