diff mbox

[12/14] series: Add a signal to notify when a revision is complete

Message ID 1445378383-16977-13-git-send-email-damien.lespiau@intel.com
State Rejected
Headers show

Commit Message

Damien Lespiau Oct. 20, 2015, 9:59 p.m. UTC 
To decouple some high level and rather complex parsing code from the
models, let's add a signal when a SeriesRevision is complete.

One can use that signal to hook some logic there, for instance from the
mail parsing code.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Acked-by: Stephen Finucane <stephen.finucane@intel.com>
---
 patchwork/models.py | 9 +++++++++
 1 file changed, 9 insertions(+)
diff mbox

Patch

diff --git a/patchwork/models.py b/patchwork/models.py
index 2729d86..1faab1b 100644
--- a/patchwork/models.py
+++ b/patchwork/models.py
@@ -19,6 +19,7 @@ 
 
 from django.db import models
 from django.db.models import Q
+import django.dispatch
 from django.contrib.auth.models import User
 from django.core.urlresolvers import reverse
 from django.contrib.sites.models import Site
@@ -454,6 +455,10 @@  class Series(models.Model):
                 print('            msgid  : %s' % patch.msgid)
                 i += 1
 
+# Signal one can listen to to know when a revision is complete (ie. has all of
+# its patches)
+series_revision_complete = django.dispatch.Signal(providing_args=["revision"])
+
 # A 'revision' of a series. Resending a new version of a patch or a full new
 # iteration of a series will create a new revision.
 class SeriesRevision(models.Model):
@@ -480,6 +485,10 @@  class SeriesRevision(models.Model):
                                                 order=order)
         sp.save()
 
+        revision_complete = self.patches.count() == self.series.n_patches
+        if revision_complete:
+            series_revision_complete.send(sender=self.__class__, revision=self)
+
     def duplicate_meta(self):
         new = SeriesRevision.objects.get(pk=self.pk)
         new.pk = None