| Message ID | 1445349954-44062-1-git-send-email-Vincent.Riera@imgtec.com |
|---|---|
| State | Accepted |
| Headers | show |
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes: > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> A more detailed commit message would be good. Is this just for consistency or does it fix anything? (E.G. does the build system execute anything from HOST_DIR)? > --- > package/dhcpdump/dhcpdump.mk | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > diff --git a/package/dhcpdump/dhcpdump.mk b/package/dhcpdump/dhcpdump.mk > index 6b677a6..3584f4f 100644 > --- a/package/dhcpdump/dhcpdump.mk > +++ b/package/dhcpdump/dhcpdump.mk > @@ -16,8 +16,8 @@ DHCPDUMP_LIBS += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs` > endif > define DHCPDUMP_BUILD_CMDS > - $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) -D_GNU_SOURCE" \ > - LIBS="$(DHCPDUMP_LIBS)" > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) \ > + -D_GNU_SOURCE" LIBS="$(DHCPDUMP_LIBS)" > endef > define DHCPDUMP_INSTALL_TARGET_CMDS > -- > 1.7.1 > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hello Peter, On 10/20/2015 09:18 PM, Peter Korsgaard wrote: >>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes: > > > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> > > A more detailed commit message would be good. Is this just for > consistency or does it fix anything? (E.G. does the build system execute > anything from HOST_DIR)? No, it's just for consistency. Regards, Vincent. > >> --- > > package/dhcpdump/dhcpdump.mk | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > diff --git a/package/dhcpdump/dhcpdump.mk b/package/dhcpdump/dhcpdump.mk > > index 6b677a6..3584f4f 100644 > > --- a/package/dhcpdump/dhcpdump.mk > > +++ b/package/dhcpdump/dhcpdump.mk > > @@ -16,8 +16,8 @@ DHCPDUMP_LIBS += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs` > > endif > > > define DHCPDUMP_BUILD_CMDS > > - $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) -D_GNU_SOURCE" \ > > - LIBS="$(DHCPDUMP_LIBS)" > > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) \ > > + -D_GNU_SOURCE" LIBS="$(DHCPDUMP_LIBS)" > > endef > > > define DHCPDUMP_INSTALL_TARGET_CMDS > > -- > > 1.7.1 > > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > >
Dear Vicente Olivert Riera, On Tue, 20 Oct 2015 15:05:52 +0100, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> > --- > package/dhcpdump/dhcpdump.mk | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Applied after slightly tweaking the commit log following Peter's comment, thanks. Thomas
diff --git a/package/dhcpdump/dhcpdump.mk b/package/dhcpdump/dhcpdump.mk index 6b677a6..3584f4f 100644 --- a/package/dhcpdump/dhcpdump.mk +++ b/package/dhcpdump/dhcpdump.mk @@ -16,8 +16,8 @@ DHCPDUMP_LIBS += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs` endif define DHCPDUMP_BUILD_CMDS - $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) -D_GNU_SOURCE" \ - LIBS="$(DHCPDUMP_LIBS)" + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) \ + -D_GNU_SOURCE" LIBS="$(DHCPDUMP_LIBS)" endef define DHCPDUMP_INSTALL_TARGET_CMDS
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> --- package/dhcpdump/dhcpdump.mk | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)