| Message ID | 1445341184-22272-3-git-send-email-Peng.Fan@freescale.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
Hi Peng, On 20/10/2015 13:39, Peng Fan wrote: > board_mxsfb_system_setup shoule be named mxsfb_system_setup. > > Signed-off-by: Peng Fan <Peng.Fan@freescale.com> > Cc: Marek Vasut <marek.vasut@gmail.com> > Cc: Stefano Babic <sbabic@denx.de> > --- > > V2: > none > > board/sandisk/sansa_fuze_plus/sfp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/sandisk/sansa_fuze_plus/sfp.c b/board/sandisk/sansa_fuze_plus/sfp.c > index a3865ad..8d1a797 100644 > --- a/board/sandisk/sansa_fuze_plus/sfp.c > +++ b/board/sandisk/sansa_fuze_plus/sfp.c > @@ -311,7 +311,7 @@ static const struct { > { 0x07, 0 , 0x0173 }, > }; > > -void board_mxsfb_system_setup(void) > +void mxsfb_system_setup(void) > { > struct mxs_lcdif_regs *regs = (struct mxs_lcdif_regs *)MXS_LCDIF_BASE; > uint32_t id; > This is really a bug. Wrong name was not seen before. It looks like this series mixes some new features (LCDIF) with bug fixes that are quite orthogonal, as in this case. I will propose that I will start merge the easy fixes (as this one), and you won't need to post them in a new version. Acked-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano Babic
diff --git a/board/sandisk/sansa_fuze_plus/sfp.c b/board/sandisk/sansa_fuze_plus/sfp.c index a3865ad..8d1a797 100644 --- a/board/sandisk/sansa_fuze_plus/sfp.c +++ b/board/sandisk/sansa_fuze_plus/sfp.c @@ -311,7 +311,7 @@ static const struct { { 0x07, 0 , 0x0173 }, }; -void board_mxsfb_system_setup(void) +void mxsfb_system_setup(void) { struct mxs_lcdif_regs *regs = (struct mxs_lcdif_regs *)MXS_LCDIF_BASE; uint32_t id;
board_mxsfb_system_setup shoule be named mxsfb_system_setup. Signed-off-by: Peng Fan <Peng.Fan@freescale.com> Cc: Marek Vasut <marek.vasut@gmail.com> Cc: Stefano Babic <sbabic@denx.de> --- V2: none board/sandisk/sansa_fuze_plus/sfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)