Patchwork pppoe: uninitialized variable in pppoe_flush_dev()

login
register
mail settings
Submitter Dan Carpenter
Date May 22, 2010, 8:27 p.m.
Message ID <20100522202534.GO22515@bicker>
Download mbox | patch
Permalink /patch/53285/
State Accepted
Delegated to: David Miller
Headers show

Comments

Dan Carpenter - May 22, 2010, 8:27 p.m.
This assignment got deleted along with the checks by mistake.  This
comes from:  8753d29fd "pppoe: remove unnecessary checks in
pppoe_flush_dev"

Signed-off-by: Dan Carpenter <error27@gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - May 24, 2010, 6:50 a.m.
From: Dan Carpenter <error27@gmail.com>
Date: Sat, 22 May 2010 22:27:48 +0200

> This assignment got deleted along with the checks by mistake.  This
> comes from:  8753d29fd "pppoe: remove unnecessary checks in
> pppoe_flush_dev"
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Applied, thanks Dan.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c
index b1b93ff..805b64d 100644
--- a/drivers/net/pppoe.c
+++ b/drivers/net/pppoe.c
@@ -289,6 +289,7 @@  static void pppoe_flush_dev(struct net_device *dev)
 	struct pppoe_net *pn;
 	int i;
 
+	pn = pppoe_pernet(dev_net(dev));
 	write_lock_bh(&pn->hash_lock);
 	for (i = 0; i < PPPOE_HASH_SIZE; i++) {
 		struct pppox_sock *po = pn->hash_table[i];