| Message ID | 20100522194550.GG22515@bicker |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sat, May 22, 2010 at 12:45, Dan Carpenter <error27@gmail.com> wrote: > The bitwise negate is intended here. With the logical negate the > condition is always false. > > Signed-off-by: Dan Carpenter <error27@gmail.com> > > diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c > index 24507f3..57a7e41 100644 > --- a/drivers/net/e1000e/netdev.c > +++ b/drivers/net/e1000e/netdev.c > @@ -2554,7 +2554,7 @@ static void e1000_init_manageability_pt(struct e1000_adapter *adapter) > mdef = er32(MDEF(i)); > > /* Ignore filters with anything other than IPMI ports */ > - if (mdef & !(E1000_MDEF_PORT_623 | E1000_MDEF_PORT_664)) > + if (mdef & ~(E1000_MDEF_PORT_623 | E1000_MDEF_PORT_664)) > continue; > > /* Enable this decision filter in MANC2H */ > -- Thanks Dan, I have added the patch to my queue.
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index 24507f3..57a7e41 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/net/e1000e/netdev.c @@ -2554,7 +2554,7 @@ static void e1000_init_manageability_pt(struct e1000_adapter *adapter) mdef = er32(MDEF(i)); /* Ignore filters with anything other than IPMI ports */ - if (mdef & !(E1000_MDEF_PORT_623 | E1000_MDEF_PORT_664)) + if (mdef & ~(E1000_MDEF_PORT_623 | E1000_MDEF_PORT_664)) continue; /* Enable this decision filter in MANC2H */
The bitwise negate is intended here. With the logical negate the condition is always false. Signed-off-by: Dan Carpenter <error27@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html