| Message ID | 1445305886-11901-1-git-send-email-yanghy@cn.fujitsu.com |
|---|---|
| State | New |
| Headers | show |
On 10/20/2015 09:51 AM, Yang Hongyang wrote: > We want "buf, sizeof(buf)" here. sizeof(buffer) is the size of a > pointer, which is wrong. > Thanks to Paolo for pointing it out. > > Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com> > Cc: Jason Wang <jasowang@redhat.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> > --- > net/net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/net.c b/net/net.c > index 39af893..0c4a012 100644 > --- a/net/net.c > +++ b/net/net.c > @@ -700,7 +700,7 @@ static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, > offset = iov[0].iov_len; > } else { > buffer = buf; > - offset = iov_to_buf(iov, iovcnt, 0, buffer, sizeof(buffer)); > + offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); > } > > if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { Both two patches were applied in: https://github.com/jasowang/qemu/commits/net Thanks
On 20/10/2015 09:20, Jason Wang wrote: > > > On 10/20/2015 09:51 AM, Yang Hongyang wrote: >> We want "buf, sizeof(buf)" here. sizeof(buffer) is the size of a >> pointer, which is wrong. >> Thanks to Paolo for pointing it out. >> >> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com> >> Cc: Jason Wang <jasowang@redhat.com> >> Cc: Paolo Bonzini <pbonzini@redhat.com> >> --- >> net/net.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/net.c b/net/net.c >> index 39af893..0c4a012 100644 >> --- a/net/net.c >> +++ b/net/net.c >> @@ -700,7 +700,7 @@ static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, >> offset = iov[0].iov_len; >> } else { >> buffer = buf; >> - offset = iov_to_buf(iov, iovcnt, 0, buffer, sizeof(buffer)); >> + offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); >> } >> >> if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { > > Both two patches were applied in: > > https://github.com/jasowang/qemu/commits/net > > Thanks Thanks! Paolo
diff --git a/net/net.c b/net/net.c index 39af893..0c4a012 100644 --- a/net/net.c +++ b/net/net.c @@ -700,7 +700,7 @@ static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, offset = iov[0].iov_len; } else { buffer = buf; - offset = iov_to_buf(iov, iovcnt, 0, buffer, sizeof(buffer)); + offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); } if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) {
We want "buf, sizeof(buf)" here. sizeof(buffer) is the size of a pointer, which is wrong. Thanks to Paolo for pointing it out. Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com> Cc: Jason Wang <jasowang@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> --- net/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)