From patchwork Sat May 22 16:13:58 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Bug,584143] Re: qemu fails to set hdd serial number Date: Sat, 22 May 2010 06:13:58 -0000 From: =?utf-8?q?Lo=C3=AFc_Minier?= X-Patchwork-Id: 53273 Message-Id: <20100522161358.32211.74968.malone@wampee.canonical.com> To: qemu-devel@nongnu.org Patch still applies on top of qemu-kvm.git and qemu.git ** Bug watch added: Debian Bug tracker #573439 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 ** Also affects: qemu-kvm (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 Importance: Unknown Status: Unknown ** Also affects: qemu-kvm (Ubuntu) Importance: Undecided Status: New --- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900 +++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900 @@ -2397,7 +2397,7 @@ dinfo->on_write_error = on_write_error; dinfo->opts = opts; if (serial) - strncpy(dinfo->serial, serial, sizeof(serial)); + strncpy(dinfo->serial, serial, sizeof(dinfo->serial)); QTAILQ_INSERT_TAIL(&drives, dinfo, next); if (is_extboot) { extboot_drive = dinfo;