From patchwork Sat May 22 09:21:04 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 53263 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0A78AB7D24 for ; Sat, 22 May 2010 19:43:23 +1000 (EST) Received: from localhost ([127.0.0.1]:55298 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OFlEm-0003zG-4H for incoming@patchwork.ozlabs.org; Sat, 22 May 2010 05:43:20 -0400 Received: from [140.186.70.92] (port=58292 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OFl2i-0005lh-I8 for qemu-devel@nongnu.org; Sat, 22 May 2010 05:30:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OFl2e-0002KA-EV for qemu-devel@nongnu.org; Sat, 22 May 2010 05:30:52 -0400 Received: from adelie.canonical.com ([91.189.90.139]:59928) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OFl2e-0002K5-7V for qemu-devel@nongnu.org; Sat, 22 May 2010 05:30:48 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1OFl2b-0001Sq-Qe for ; Sat, 22 May 2010 10:30:46 +0100 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 3291F2E8403 for ; Sat, 22 May 2010 10:30:44 +0100 (BST) MIME-Version: 1.0 Date: Sat, 22 May 2010 09:21:04 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org X-Launchpad-Bug: product=qemu; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug-Tags: patch X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: mjt+launchpad-tls References: <20100522092104.29268.17427.malonedeb@soybean.canonical.com> Message-Id: <20100522092104.29268.17427.malonedeb@soybean.canonical.com> X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="None"; Instance="initZopeless config overlay" X-Launchpad-Hash: b9cca413859e3bd44c8e76a602ecc499e7e6e840 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: [Qemu-devel] [Bug 584143] [NEW] qemu fails to set hdd serial number X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Reply-To: Bug 584143 <584143@bugs.launchpad.net> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Public bug reported: The -drive ...,serial=xyz option is broken, at least in 0.12. See Debian bug#573439, http://bugs.debian.org/cgi- bin/bugreport.cgi?bug=573439 for details. The proposed fix from the original reporter: --- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900 +++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900 @@ -2397,7 +2397,7 @@ dinfo->on_write_error = on_write_error; dinfo->opts = opts; if (serial) - strncpy(dinfo->serial, serial, sizeof(serial)); + strncpy(dinfo->serial, serial, sizeof(dinfo->serial)); QTAILQ_INSERT_TAIL(&drives, dinfo, next); if (is_extboot) { extboot_drive = dinfo; ** Affects: qemu Importance: Undecided Status: New ** Tags: patch -- qemu fails to set hdd serial number https://bugs.launchpad.net/bugs/584143 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Bug description: The -drive ...,serial=xyz option is broken, at least in 0.12. See Debian bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details. The proposed fix from the original reporter: --- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900 +++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900 @@ -2397,7 +2397,7 @@ dinfo->on_write_error = on_write_error; dinfo->opts = opts; if (serial) - strncpy(dinfo->serial, serial, sizeof(serial)); + strncpy(dinfo->serial, serial, sizeof(dinfo->serial)); QTAILQ_INSERT_TAIL(&drives, dinfo, next); if (is_extboot) { extboot_drive = dinfo;