| Message ID | 1445235739-26537-1-git-send-email-hs@denx.de |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On 10/19/2015 08:22 AM, Heiko Schocher wrote: > This patch fixes a warning in clk_enable by calling > clk_prepare_enable instead. What about the corresponding clk_disable_unprepare()? Marc > > Signed-off-by: Heiko Schocher <hs@denx.de> > --- > > drivers/net/can/ti_hecc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c > index cf345cb..c08e8ea 100644 > --- a/drivers/net/can/ti_hecc.c > +++ b/drivers/net/can/ti_hecc.c > @@ -951,7 +951,7 @@ static int ti_hecc_probe(struct platform_device *pdev) > netif_napi_add(ndev, &priv->napi, ti_hecc_rx_poll, > HECC_DEF_NAPI_WEIGHT); > > - clk_enable(priv->clk); > + clk_prepare_enable(priv->clk); > err = register_candev(ndev); > if (err) { > dev_err(&pdev->dev, "register_candev() failed\n"); >
Hello Marc, Am 19.10.2015 um 08:34 schrieb Marc Kleine-Budde: > On 10/19/2015 08:22 AM, Heiko Schocher wrote: >> This patch fixes a warning in clk_enable by calling >> clk_prepare_enable instead. > > What about the corresponding clk_disable_unprepare()? Yes, that should be fixed too, do this in a v2, thanks! bye, Heiko > > Marc > >> >> Signed-off-by: Heiko Schocher <hs@denx.de> >> --- >> >> drivers/net/can/ti_hecc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c >> index cf345cb..c08e8ea 100644 >> --- a/drivers/net/can/ti_hecc.c >> +++ b/drivers/net/can/ti_hecc.c >> @@ -951,7 +951,7 @@ static int ti_hecc_probe(struct platform_device *pdev) >> netif_napi_add(ndev, &priv->napi, ti_hecc_rx_poll, >> HECC_DEF_NAPI_WEIGHT); >> >> - clk_enable(priv->clk); >> + clk_prepare_enable(priv->clk); >> err = register_candev(ndev); >> if (err) { >> dev_err(&pdev->dev, "register_candev() failed\n"); >> > >
diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c index cf345cb..c08e8ea 100644 --- a/drivers/net/can/ti_hecc.c +++ b/drivers/net/can/ti_hecc.c @@ -951,7 +951,7 @@ static int ti_hecc_probe(struct platform_device *pdev) netif_napi_add(ndev, &priv->napi, ti_hecc_rx_poll, HECC_DEF_NAPI_WEIGHT); - clk_enable(priv->clk); + clk_prepare_enable(priv->clk); err = register_candev(ndev); if (err) { dev_err(&pdev->dev, "register_candev() failed\n");
This patch fixes a warning in clk_enable by calling clk_prepare_enable instead. Signed-off-by: Heiko Schocher <hs@denx.de> --- drivers/net/can/ti_hecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)