Patchwork Fix --enable-user-pie compilation.

login
register
mail settings
Submitter Richard Henderson
Date May 21, 2010, 5:04 p.m.
Message ID <1274461486-23575-1-git-send-email-rth@twiddle.net>
Download mbox | patch
Permalink /patch/53195/
State New
Headers show

Comments

Richard Henderson - May 21, 2010, 5:04 p.m.
We forgot to propagate -fpie to the libdis-user directory.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 configure |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Richard Henderson - June 7, 2010, 3:07 p.m.
Ping^4


r~

On 05/21/2010 10:04 AM, Richard Henderson wrote:
> We forgot to propagate -fpie to the libdis-user directory.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  configure |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/configure b/configure
> index 3cd2c5f..ba3aaac 100755
> --- a/configure
> +++ b/configure
> @@ -2355,6 +2355,9 @@ for d in libdis libdis-user; do
>      ln -s $source_path/Makefile.dis $d/Makefile
>      echo > $d/config.mak
>  done
> +if test "$static" = "no" -a "$user_pie" = "yes" ; then
> +  echo "QEMU_CFLAGS+=-fpie" > libdis-user/config.mak
> +fi
>  
>  for target in $target_list; do
>  target_dir="$target"
Paolo Bonzini - June 7, 2010, 4:08 p.m.
On 06/07/2010 05:07 PM, Richard Henderson wrote:
> Ping^4
>
>
> r~
>
> On 05/21/2010 10:04 AM, Richard Henderson wrote:
>> We forgot to propagate -fpie to the libdis-user directory.
>>
>> Signed-off-by: Richard Henderson<rth@twiddle.net>
>> ---
>>   configure |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 3cd2c5f..ba3aaac 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2355,6 +2355,9 @@ for d in libdis libdis-user; do
>>       ln -s $source_path/Makefile.dis $d/Makefile
>>       echo>  $d/config.mak
>>   done
>> +if test "$static" = "no" -a "$user_pie" = "yes" ; then
>> +  echo "QEMU_CFLAGS+=-fpie">  libdis-user/config.mak
>> +fi
>>
>>   for target in $target_list; do
>>   target_dir="$target"

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

Patch

diff --git a/configure b/configure
index 3cd2c5f..ba3aaac 100755
--- a/configure
+++ b/configure
@@ -2355,6 +2355,9 @@  for d in libdis libdis-user; do
     ln -s $source_path/Makefile.dis $d/Makefile
     echo > $d/config.mak
 done
+if test "$static" = "no" -a "$user_pie" = "yes" ; then
+  echo "QEMU_CFLAGS+=-fpie" > libdis-user/config.mak
+fi
 
 for target in $target_list; do
 target_dir="$target"