| Message ID | 1274446713.11082.3.camel@lb-tlvb-eilong.il.broadcom.com |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
On 2010-05-21 14:58, Eilon Greenstein wrote: > On Thu, 2010-05-20 at 13:54 -0700, Krzysztof Olędzki wrote: >> On 2010-05-20 22:25, Rick Jones wrote: >>> Some simple/simplistic thoughts/questions... >>> >>> Has the DAC been used successfully prior to this? >> >> Yes. It was successfully used to connect two HP switches, before I >> received SFP+ SR modules, that allowed me to put the switches into >> distanced rooms. > > Krzysztof, > > I would like to check in what speed the I2C is running at, and while we > are there, to make sure it is at low speed (100KHz and not 400KHz). Can > you please add this patch and let me know what you see: Sure. > > diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c <CUT> [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 [bnx2x_8727_read_sfp_module_eeprom:2774(eth5)]I2C 2W speed 0x0, bit 8 0 > Since we are already off for the weekend, I couldn't find a machine with > this kind of board to test it for myself. On top of that, I don't have > this type of DAC cable, so I need your help in this debug process. No problem. There is no need to ask for a help a person who depends on your support. ;) I would like to solve it as soon as possible so I'm willing to test everything you send me. ;) best regards, Krzysztof Olędzki -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2010-05-21 15:19, Krzysztof Olędzki wrote: > On 2010-05-21 14:58, Eilon Greenstein wrote: >> On Thu, 2010-05-20 at 13:54 -0700, Krzysztof Olędzki wrote: >>> On 2010-05-20 22:25, Rick Jones wrote: >>>> Some simple/simplistic thoughts/questions... >>>> >>>> Has the DAC been used successfully prior to this? >>> >>> Yes. It was successfully used to connect two HP switches, before I >>> received SFP+ SR modules, that allowed me to put the switches into >>> distanced rooms. >> >> Krzysztof, >> >> I would like to check in what speed the I2C is running at, and while we >> are there, to make sure it is at low speed (100KHz and not 400KHz). Can >> you please add this patch and let me know what you see: > > Sure. > >> >> diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c > > <CUT> > > [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 > [bnx2x_8727_read_sfp_module_eeprom:2774(eth5)]I2C 2W speed 0x0, bit 8 0 > >> Since we are already off for the weekend, I couldn't find a machine with >> this kind of board to test it for myself. On top of that, I don't have >> this type of DAC cable, so I need your help in this debug process. > > No problem. There is no need to ask for a help a person who depends on > your support. ;) I would like to solve it as soon as possible so I'm > willing to test everything you send me. ;) Hello again, To make sure the NICs are OK I made a test and plugged a SFP+ SR module (HP J9150A): [bnx2x_8727_handle_mod_abs:4639(eth4)]MOD_ABS indication show module is present [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 [bnx2x_8727_read_sfp_module_eeprom:2835(eth4)]Got bad status 0x0 when reading from SFP+ EEPROM [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 [bnx2x_8727_read_sfp_module_eeprom:2835(eth4)]Got bad status 0x0 when reading from SFP+ EEPROM [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 [bnx2x_8727_read_sfp_module_eeprom:2835(eth4)]Got bad status 0x0 when reading from SFP+ EEPROM [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 [bnx2x_8727_read_sfp_module_eeprom:2835(eth4)]Got bad status 0x0 when reading from SFP+ EEPROM [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 [bnx2x_8727_read_sfp_module_eeprom:2835(eth4)]Got bad status 0x0 when reading from SFP+ EEPROM [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 [bnx2x_wait_for_sfp_module_initialized:3138(eth4)]SFP+ module initialization took 25 ms [bnx2x_sfp_module_detection:3197(eth4)]SFP+ module plugged in/out detected on port 0 [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 [bnx2x_get_edc_mode:2930(eth4)]Optic module detected [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 [bnx2x_get_edc_mode:2954(eth4)]EDC mode is set to 0x44 [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 [bnx2x_8727_read_sfp_module_eeprom:2774(eth4)]I2C 2W speed 0x0, bit 8 0 bnx2x: Warning: Unqualified SFP+ module detected on eth4, Port 0 from MergeOptics GmbH part number TRX10GVP2010CA01 [bnx2x_sfp_module_detection:3205(eth4)]Module verification failed!! So, both NICs and SFP+ DA cables are OK. The only problem we have is to make them talk together. :| Best regards, Krzysztof Olędzki -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c index ff70be8..6e05f99 100644 --- a/drivers/net/bnx2x_link.c +++ b/drivers/net/bnx2x_link.c @@ -2766,6 +2766,21 @@ static u8 bnx2x_8727_read_sfp_module_eeprom(struct link_params *params, MDIO_PMA_REG_SFP_TWO_WIRE_CTRL, &val); + /* Make sure we are working in 100KHz */ + bnx2x_cl45_read(bp, port, + PORT_HW_CFG_XGXS_EXT_PHY_TYPE_BCM8727, + ext_phy_addr, + MDIO_PMA_DEVAD, + 8005, + &val); + BNX2X_ERR("I2C 2W speed 0x%x, bit 8 %d\n", val, val & 8); + bnx2x_cl45_write(bp, port, + ext_phy_type, + ext_phy_addr, + MDIO_PMA_DEVAD, + 8005, + val & ~8); + /* Set the read command byte count */ bnx2x_cl45_write(bp, port,