diff mbox

[v2,8/9] target-i386: Ensure always-1 bits on DR6 can't be cleared

Message ID 1445012619-23772-9-git-send-email-ehabkost@redhat.com
State New
Headers show

Commit Message

Eduardo Habkost Oct. 16, 2015, 4:23 p.m. UTC 
Bits 4-11 and 16-31 on DR6 are documented as always 1, so ensure they
can't be cleared by software.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/bpt_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Henderson Oct. 18, 2015, 11:05 p.m. UTC | #1 
On 10/16/2015 06:23 AM, Eduardo Habkost wrote:
> Bits 4-11 and 16-31 on DR6 are documented as always 1, so ensure they
> can't be cleared by software.
>
> Signed-off-by: Eduardo Habkost<ehabkost@redhat.com>
> ---
>   target-i386/bpt_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~
diff mbox

Patch

diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c
index 3cb4a09..0fbdc03 100644
--- a/target-i386/bpt_helper.c
+++ b/target-i386/bpt_helper.c
@@ -261,7 +261,7 @@  void helper_set_dr(CPUX86State *env, int reg, target_ulong t0)
         }
         /* fallthru */
     case 6:
-        env->dr[6] = t0;
+        env->dr[6] = t0 | DR6_FIXED_1;
         return;
     case 5:
         if (env->cr[4] & CR4_DE_MASK) {