| Message ID | 1444990404.2436.2.camel@clsee-VirtualBox |
|---|---|
| State | Superseded |
| Headers | show |
On Friday, October 16, 2015 at 12:13:24 PM, Chin Liang See wrote: > From 4a91b5a380e7d3178d4378df79224442c79278bb Mon Sep 17 00:00:00 2001 > From: Chin Liang See <clsee@altera.com> > Date: Fri, 16 Oct 2015 16:35:10 +0800 > Subject: [PATCH v4 2/5] spi: cadence_qspi: Fix fdt read of > spi-max-frequency > > Fix the fdt read for spi-max-frequency as it's contained > in the child node. Current state of code is always > returning default value. > > Signed-off-by: Chin Liang See <clsee@altera.com> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > Cc: Dinh Nguyen <dinh.linux@gmail.com> > Cc: Marek Vasut <marex@denx.de> > Cc: Stefan Roese <sr@denx.de> > Cc: Vikas Manocha <vikas.manocha@st.com> > Cc: Jagannadh Teki <jteki@openedev.com> > Cc: Pavel Machek <pavel@denx.de> > Acked-by: Marek Vasut <marex@denx.de> > Acked-by: Pavel Machek <pavel@denx.de> > --- > Changes for v4 > - use the newly created fdtdec_get_uint This patch depends on 5/5, so this will break bisect . Please do reorder the patches , most likely such that 5/5 goes in first and the rest follows. Best regards, Marek Vasut
Hi Marek, On Sat, 2015-10-17 at 01:08 +0200, marex@denx.de wrote: > On Friday, October 16, 2015 at 12:13:24 PM, Chin Liang See wrote: > > From 4a91b5a380e7d3178d4378df79224442c79278bb Mon Sep 17 00:00:00 2001 > > From: Chin Liang See <clsee@altera.com> > > Date: Fri, 16 Oct 2015 16:35:10 +0800 > > Subject: [PATCH v4 2/5] spi: cadence_qspi: Fix fdt read of > > spi-max-frequency > > > > Fix the fdt read for spi-max-frequency as it's contained > > in the child node. Current state of code is always > > returning default value. > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > Cc: Marek Vasut <marex@denx.de> > > Cc: Stefan Roese <sr@denx.de> > > Cc: Vikas Manocha <vikas.manocha@st.com> > > Cc: Jagannadh Teki <jteki@openedev.com> > > Cc: Pavel Machek <pavel@denx.de> > > Acked-by: Marek Vasut <marex@denx.de> > > Acked-by: Pavel Machek <pavel@denx.de> > > --- > > Changes for v4 > > - use the newly created fdtdec_get_uint > > This patch depends on 5/5, so this will break bisect . Please do > reorder the patches , most likely such that 5/5 goes in first and > the rest follows. > Sure, I can do the patches order re-shuffling. Thanks Chin Liang > Best regards, > Marek Vasut
On Saturday, October 17, 2015 at 02:46:29 PM, Chin Liang See wrote: > Hi Marek, Hi! > On Sat, 2015-10-17 at 01:08 +0200, marex@denx.de wrote: > > On Friday, October 16, 2015 at 12:13:24 PM, Chin Liang See wrote: > > > From 4a91b5a380e7d3178d4378df79224442c79278bb Mon Sep 17 00:00:00 2001 > > > From: Chin Liang See <clsee@altera.com> > > > Date: Fri, 16 Oct 2015 16:35:10 +0800 > > > Subject: [PATCH v4 2/5] spi: cadence_qspi: Fix fdt read of > > > spi-max-frequency > > > > > > Fix the fdt read for spi-max-frequency as it's contained > > > in the child node. Current state of code is always > > > returning default value. > > > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > > Cc: Marek Vasut <marex@denx.de> > > > Cc: Stefan Roese <sr@denx.de> > > > Cc: Vikas Manocha <vikas.manocha@st.com> > > > Cc: Jagannadh Teki <jteki@openedev.com> > > > Cc: Pavel Machek <pavel@denx.de> > > > Acked-by: Marek Vasut <marex@denx.de> > > > Acked-by: Pavel Machek <pavel@denx.de> > > > --- > > > Changes for v4 > > > - use the newly created fdtdec_get_uint > > > > This patch depends on 5/5, so this will break bisect . Please do > > reorder the patches , most likely such that 5/5 goes in first and > > the rest follows. > > Sure, I can do the patches order re-shuffling. Thanks! Ideally, I think you can even send those patches separatelly and note that the QSPI series depends on the FDT patch. Best regards, Marek Vasut
diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c index c5a4276..5756178 100644 --- a/drivers/spi/cadence_qspi.c +++ b/drivers/spi/cadence_qspi.c @@ -295,10 +295,6 @@ static int cadence_spi_ofdata_to_platdata(struct udevice *bus) plat->regbase = (void *)data[0]; plat->ahbbase = (void *)data[2]; - /* Use 500KHz as a suitable default */ - plat->max_hz = fdtdec_get_int(blob, node, "spi-max-frequency", - 500000); - /* All other paramters are embedded in the child node */ subnode = fdt_first_subnode(blob, node);