| Message ID | 1444986537-28387-5-git-send-email-anup.patel@broadcom.com |
|---|---|
| State | Superseded |
| Headers | show |
On 16/10/15 10:08, Anup Patel wrote: > The NAND controller on NS2 SoC is compatible with existing > BRCM IPROC NAND driver so let's enable it in NS2 DT and > NS2 SVK DT. > > Signed-off-by: Anup Patel <anup.patel@broadcom.com> > Reviewed-by: Ray Jui <rjui@broadcom.com> > Reviewed-by: Scott Branden <sbranden@broadcom.com> > --- > arch/arm64/boot/dts/broadcom/ns2-svk.dts | 12 ++++++++++++ > arch/arm64/boot/dts/broadcom/ns2.dtsi | 14 ++++++++++++++ > 2 files changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts > index e5950d5..a754160 100644 > --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts > +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts > @@ -63,5 +63,17 @@ > uart3: serial@66130000 { > status = "ok"; > }; Better to change even the above reference, see below. > + > + nand: nand@66460000 { In most of the cases where such static overlays are done, I have seen the labels being used to refer back the node. Using the complete node name again is kind of inviting trouble as even minor typo results in creation of another node.
> -----Original Message----- > From: Sudeep Holla [mailto:sudeep.holla@arm.com] > Sent: 20 October 2015 14:36 > To: Anup Patel > Cc: David Woodhouse; Brian Norris; linux-mtd@lists.infradead.org; Sudeep > Holla; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Catalin > Marinas; Will Deacon; Ray Jui; Scott Branden; Florian Fainelli; Pramod Kumar; > Vikram Prakash; Sandeep Tripathy; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; bcm-kernel- > feedback-list > Subject: Re: [PATCH v2 4/4] arm64: dts: Add BRCM IPROC NAND DT node for > NS2 > > > > On 16/10/15 10:08, Anup Patel wrote: > > The NAND controller on NS2 SoC is compatible with existing BRCM IPROC > > NAND driver so let's enable it in NS2 DT and > > NS2 SVK DT. > > > > Signed-off-by: Anup Patel <anup.patel@broadcom.com> > > Reviewed-by: Ray Jui <rjui@broadcom.com> > > Reviewed-by: Scott Branden <sbranden@broadcom.com> > > --- > > arch/arm64/boot/dts/broadcom/ns2-svk.dts | 12 ++++++++++++ > > arch/arm64/boot/dts/broadcom/ns2.dtsi | 14 ++++++++++++++ > > 2 files changed, 26 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > b/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > index e5950d5..a754160 100644 > > --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > @@ -63,5 +63,17 @@ > > uart3: serial@66130000 { > > status = "ok"; > > }; > > Better to change even the above reference, see below. > > > + > > + nand: nand@66460000 { > > In most of the cases where such static overlays are done, I have seen the labels > being used to refer back the node. Using the complete node name again is kind > of inviting trouble as even minor typo results in creation of another node. Thanks for pointing. I will use label here for both uart3 and nand. Regards, Anup
diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts index e5950d5..a754160 100644 --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts @@ -63,5 +63,17 @@ uart3: serial@66130000 { status = "ok"; }; + + nand: nand@66460000 { + nandcs@0 { + compatible = "brcm,nandcs"; + reg = <0>; + nand-ecc-mode = "hw"; + nand-ecc-strength = <8>; + nand-ecc-step-size = <512>; + #address-cells = <1>; + #size-cells = <1>; + }; + }; }; }; diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi b/arch/arm64/boot/dts/broadcom/ns2.dtsi index f603277..9610822 100644 --- a/arch/arm64/boot/dts/broadcom/ns2.dtsi +++ b/arch/arm64/boot/dts/broadcom/ns2.dtsi @@ -212,5 +212,19 @@ compatible = "brcm,iproc-rng200"; reg = <0x66220000 0x28>; }; + + nand: nand@66460000 { + compatible = "brcm,nand-iproc", "brcm,brcmnand-v6.1"; + reg = <0x66460000 0x600>, + <0x67015408 0x600>, + <0x66460f00 0x20>; + reg-names = "nand", "iproc-idm", "iproc-ext"; + interrupts = <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>; + + #address-cells = <1>; + #size-cells = <0>; + + brcm,nand-has-wp; + }; }; };