[0/6] qobject: Make conversion from QObject * accept null
diff mbox

Message ID 20151015120651.249f46d2@redhat.com
State New
Headers show

Commit Message

Luiz Capitulino Oct. 15, 2015, 4:06 p.m. UTC
On Thu, 15 Oct 2015 16:15:31 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> The qobject_to_FOO() crash on null, which is a trap for the unwary.
> Return null instead, and simplify a few callers.
> 
> Throw in a patch to drop QObject_HEAD.
> 
> Luiz, I'm happy to take this through my tree, since got a QMP series
> based on it (to be posted shortly).

Please do.

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

Btw, what do you think about this patch? :)

Comments

Markus Armbruster Oct. 22, 2015, 12:20 p.m. UTC | #1
Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Thu, 15 Oct 2015 16:15:31 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> The qobject_to_FOO() crash on null, which is a trap for the unwary.
>> Return null instead, and simplify a few callers.
>> 
>> Throw in a patch to drop QObject_HEAD.
>> 
>> Luiz, I'm happy to take this through my tree, since got a QMP series
>> based on it (to be posted shortly).
>
> Please do.
>
> Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

Thanks!

> Btw, what do you think about this patch? :)

I knew I was playing with fire %-}

Right now I'm too swamped with QAPI patches to take on more.  Once we
flushed that queue, and got QAPI to quiet down a bit, I can take HMP and
QObject off you.

Patch
diff mbox

diff --git a/MAINTAINERS b/MAINTAINERS
index 9bd2b8f..aa03f3d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1010,7 +1010,7 @@  F: qemu-timer.c
 F: vl.c
 
 Human Monitor (HMP)
-M: Luiz Capitulino <lcapitulino@redhat.com>
+M: Markus Armbruster <armbru@redhat.com>
 S: Maintained
 F: monitor.c
 F: hmp.c
@@ -1073,7 +1073,7 @@  F: qapi/*.json
 T: git git://repo.or.cz/qemu/armbru.git qapi-next
 
 QObject
-M: Luiz Capitulino <lcapitulino@redhat.com>
+M: Markus Armbruster <armbru@redhat.com>
 S: Maintained
 F: qobject/
 F: include/qapi/qmp/