diff mbox

sqlcipher: disable tcl support

Message ID 1444905771-30927-1-git-send-email-gustavo@zacarias.com.ar
State Accepted
Headers show

Commit Message

Gustavo Zacarias Oct. 15, 2015, 10:42 a.m. UTC
In commit b1dcb1c2 a fix was attempted at fixing a build failure where
sqlcipher finds the distribution tcl and tries to build against it.
sqlcipher has two tcl usage scenarios: host-tcl which is required to
actually build it, and target tcl to build bindings.
Since cross-compilation of the bindings isn't clean it fails as well,
and since it wasn't a feature before either just disable it completely,
since the wrong fix makes the sqlcipher build failures worse.
Fixes:
http://autobuild.buildroot.net/results/fc0/fc0528de7fed2f34f503fe8dd8b4c21ded0d6dff/

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/sqlcipher/sqlcipher.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Oct. 15, 2015, 11:27 a.m. UTC | #1
Dear Gustavo Zacarias,

On Thu, 15 Oct 2015 07:42:51 -0300, Gustavo Zacarias wrote:
> In commit b1dcb1c2 a fix was attempted at fixing a build failure where
> sqlcipher finds the distribution tcl and tries to build against it.
> sqlcipher has two tcl usage scenarios: host-tcl which is required to
> actually build it, and target tcl to build bindings.
> Since cross-compilation of the bindings isn't clean it fails as well,
> and since it wasn't a feature before either just disable it completely,
> since the wrong fix makes the sqlcipher build failures worse.
> Fixes:
> http://autobuild.buildroot.net/results/fc0/fc0528de7fed2f34f503fe8dd8b4c21ded0d6dff/
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/sqlcipher/sqlcipher.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas
diff mbox

Patch

diff --git a/package/sqlcipher/sqlcipher.mk b/package/sqlcipher/sqlcipher.mk
index fadec22..196f162 100644
--- a/package/sqlcipher/sqlcipher.mk
+++ b/package/sqlcipher/sqlcipher.mk
@@ -15,7 +15,7 @@  SQLCIPHER_CONF_ENV = \
 
 SQLCIPHER_CONF_OPTS = \
 	--enable-threadsafe \
-	--with-tcl=$(HOST_DIR)/usr/lib
+	--disable-tcl
 
 SQLCIPHER_CFLAGS += -DSQLITE_HAS_CODEC # Required according to the README
 SQLCIPHER_CONF_ENV += LIBS="-lcrypto -lz"