| Message ID | 1444902004-14433-6-git-send-email-jeffrey.t.kirsher@intel.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2015-10-15 at 02:39 -0700, Jeff Kirsher wrote: > From: Neerav Parikh <neerav.parikh@intel.com> > > There are several error messages that have been printing when there is > no functional issue. These messages should be available at debug message > level only. [] > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c [] > @@ -6593,9 +6593,9 @@ static void i40e_reset_and_rebuild(struct i40e_pf *pf, bool reinit) > /* make sure our flow control settings are restored */ > ret = i40e_set_fc(&pf->hw, &set_fc_aq_fail, true); > if (ret) > - dev_info(&pf->pdev->dev, "set fc fail, err %s aq_err %s\n", > - i40e_stat_str(&pf->hw, ret), > - i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); > + dev_dbg(&pf->pdev->dev, "setting flow control: ret = %s last_status = %s\n", > + i40e_stat_str(&pf->hw, ret), > + i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); [] > @@ -10333,10 +10339,9 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > /* get the requested speeds from the fw */ > err = i40e_aq_get_phy_capabilities(hw, false, false, &abilities, NULL); > if (err) > - dev_info(&pf->pdev->dev, > - "get phy capabilities failed, err %s aq_err %s, advertised speed settings may not be correct\n", > - i40e_stat_str(&pf->hw, err), > - i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); > + dev_dbg(&pf->pdev->dev, "get requested speeds ret = %s last_status = %s\n", > + i40e_stat_str(&pf->hw, err), > + i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); > pf->hw.phy.link_info.requested_speeds = abilities.link_speed; > > /* get the supported phy types from the fw */ Perhaps these 2 are functional issues and should remain dev_info or maybe upgraded to notice or err -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> From: Joe Perches [mailto:joe@perches.com] > Sent: Thursday, October 15, 2015 2:55 AM > > On Thu, 2015-10-15 at 02:39 -0700, Jeff Kirsher wrote: > > From: Neerav Parikh <neerav.parikh@intel.com> > > > > There are several error messages that have been printing when there is > > no functional issue. These messages should be available at debug > > message level only. > [] > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c > > b/drivers/net/ethernet/intel/i40e/i40e_main.c > [] > > @@ -6593,9 +6593,9 @@ static void i40e_reset_and_rebuild(struct i40e_pf > *pf, bool reinit) > > /* make sure our flow control settings are restored */ > > ret = i40e_set_fc(&pf->hw, &set_fc_aq_fail, true); > > if (ret) > > - dev_info(&pf->pdev->dev, "set fc fail, err %s aq_err %s\n", > > - i40e_stat_str(&pf->hw, ret), > > - i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); > > + dev_dbg(&pf->pdev->dev, "setting flow control: ret = %s > last_status = %s\n", > > + i40e_stat_str(&pf->hw, ret), > > + i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); > [] > > @@ -10333,10 +10339,9 @@ static int i40e_probe(struct pci_dev *pdev, > const struct pci_device_id *ent) > > /* get the requested speeds from the fw */ > > err = i40e_aq_get_phy_capabilities(hw, false, false, &abilities, NULL); > > if (err) > > - dev_info(&pf->pdev->dev, > > - "get phy capabilities failed, err %s aq_err %s, > advertised speed settings may not be correct\n", > > - i40e_stat_str(&pf->hw, err), > > - i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); > > + dev_dbg(&pf->pdev->dev, "get requested speeds ret = %s > last_status = %s\n", > > + i40e_stat_str(&pf->hw, err), > > + i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); > > pf->hw.phy.link_info.requested_speeds = abilities.link_speed; > > > > /* get the supported phy types from the fw */ > > > Perhaps these 2 are functional issues and should remain dev_info or maybe > upgraded to notice or err > > They aren't functional issues right now. Both of these are actually failures from the get_phy_capabilities call, so the only problem would be the phy information the driver has stored being slightly out of date, and in this case it is out of date for such a short period of time that it doesn't have an effect. We don't want to alarm people with an error message that has no functional impact right now, but we wanted to leave it in at the debug level in case it does have a functional impact in the future we still have a way to see the problem. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c b/drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c index 7c42d13..886e667 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c +++ b/drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c @@ -240,10 +240,9 @@ static void i40e_dcbnl_del_app(struct i40e_pf *pf, for (v = 0; v < pf->num_alloc_vsi; v++) { if (pf->vsi[v] && pf->vsi[v]->netdev) { err = i40e_dcbnl_vsi_del_app(pf->vsi[v], app); - if (err) - dev_info(&pf->pdev->dev, "Failed deleting app for VSI seid=%d err=%d sel=%d proto=0x%x prio=%d\n", - pf->vsi[v]->seid, err, app->selector, - app->protocolid, app->priority); + dev_dbg(&pf->pdev->dev, "Deleting app for VSI seid=%d err=%d sel=%d proto=0x%x prio=%d\n", + pf->vsi[v]->seid, err, app->selector, + app->protocolid, app->priority); } } } diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c index eaedc1f..2ec2411 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c +++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c @@ -284,7 +284,7 @@ void i40e_init_pf_fcoe(struct i40e_pf *pf) pf->fcoe_hmc_filt_num = 0; if (!pf->hw.func_caps.fcoe) { - dev_info(&pf->pdev->dev, "FCoE capability is disabled\n"); + dev_dbg(&pf->pdev->dev, "FCoE capability is disabled\n"); return; } diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 10662f6..7c4add8 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -6593,9 +6593,9 @@ static void i40e_reset_and_rebuild(struct i40e_pf *pf, bool reinit) /* make sure our flow control settings are restored */ ret = i40e_set_fc(&pf->hw, &set_fc_aq_fail, true); if (ret) - dev_info(&pf->pdev->dev, "set fc fail, err %s aq_err %s\n", - i40e_stat_str(&pf->hw, ret), - i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); + dev_dbg(&pf->pdev->dev, "setting flow control: ret = %s last_status = %s\n", + i40e_stat_str(&pf->hw, ret), + i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); /* Rebuild the VSIs and VEBs that existed before reset. * They are still in our local switch element arrays, so only @@ -9847,8 +9847,14 @@ static void i40e_determine_queue_usage(struct i40e_pf *pf) } pf->queues_left = queues_left; + dev_dbg(&pf->pdev->dev, + "qs_avail=%d FD SB=%d lan_qs=%d lan_tc0=%d vf=%d*%d vmdq=%d*%d, remaining=%d\n", + pf->hw.func_caps.num_tx_qp, + !!(pf->flags & I40E_FLAG_FD_SB_ENABLED), + pf->num_lan_qps, pf->rss_size, pf->num_req_vfs, pf->num_vf_qps, + pf->num_vmdq_vsis, pf->num_vmdq_qps, queues_left); #ifdef I40E_FCOE - dev_info(&pf->pdev->dev, "fcoe queues = %d\n", pf->num_fcoe_qps); + dev_dbg(&pf->pdev->dev, "fcoe queues = %d\n", pf->num_fcoe_qps); #endif } @@ -10333,10 +10339,9 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) /* get the requested speeds from the fw */ err = i40e_aq_get_phy_capabilities(hw, false, false, &abilities, NULL); if (err) - dev_info(&pf->pdev->dev, - "get phy capabilities failed, err %s aq_err %s, advertised speed settings may not be correct\n", - i40e_stat_str(&pf->hw, err), - i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); + dev_dbg(&pf->pdev->dev, "get requested speeds ret = %s last_status = %s\n", + i40e_stat_str(&pf->hw, err), + i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); pf->hw.phy.link_info.requested_speeds = abilities.link_speed; /* get the supported phy types from the fw */