diff mbox

loosing IPMI-card by loading netconsole

Message ID 20100520101601.GA26235@localhost
State RFC, archived
Delegated to: David Miller
Headers show

Commit Message

Henning Fehrmann May 20, 2010, 10:16 a.m. UTC 
Hello,
> 
> 
> Let me re-describe the symptoms.
> I am not loading any ipmi related modules and not the netconsole
> module.
> When booting out current 2.6.32 kernel we can not access the IPMI
> remotely.
> 
> We had one case where the IPMI card was accessible while using this
> kernel but probably due to the fact that eth0 was removed. We do not
> consider this case anymore. 
> 
> This problem does not occur when using an older kernel. 
> 
> It has likely nothing to do with netconsole.
> 
> Here is the bisecting result:
> 
> The sha1 sum of the first bad commit is: 
> 6e50912a442947d5fafd296ca6fdcbeb36b163ff
> 
> Hence, the last good commit has:
> b2f8f7525c8aa1fdd8ad8c72c832dfb571d5f768

I 'reverse patched' the changes: 



and compiled the kernel. This kernel works and the IPMI card is remotely accessible. 

Can we savely remove this two lines or are we running into other problems?

Cheers,
Henning
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/e1000e/param.c b/drivers/net/e1000e/param.c
index e909f96..1342e0b 100644
--- a/drivers/net/e1000e/param.c
+++ b/drivers/net/e1000e/param.c
@@ -427,6 +427,8 @@  void __devinit e1000e_check_options(struct e1000_adapter *adapter)
                        e1000_validate_option(&crc_stripping, &opt, adapter);
                        if (crc_stripping == OPTION_ENABLED)
                                adapter->flags2 |= FLAG2_CRC_STRIPPING;
+               } else {
+                       adapter->flags2 |= FLAG2_CRC_STRIPPING;
                }
        }
        { /* Kumeran Lock Loss Workaround */