diff mbox

[1/2] iio: adc: mcp320x: Deprecated compatible strings with no vendor prefix

Message ID 1444827279-23163-2-git-send-email-javier@osg.samsung.com
State Under Review, archived
Headers show

Commit Message

Javier Martinez Canillas Oct. 14, 2015, 12:54 p.m. UTC
The Microchip Analog to Digital Converter (ADC) Device Tree binding
documents compatible strings with no vendor prefix. Since it should
compatible strings with also a vendor, add these to the binding doc
and mark the old ones as deprecated.

The driver says that the device is from Microchip Technology which
is listed in Documentation/devicetree/bindings/vendor-prefixes.txt
so use the documented prefix.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 .../devicetree/bindings/iio/adc/mcp320x.txt        | 30 +++++++++++++++-------
 1 file changed, 21 insertions(+), 9 deletions(-)

Comments

Michael Welling Oct. 14, 2015, 3:27 p.m. UTC | #1
On Wed, Oct 14, 2015 at 02:54:38PM +0200, Javier Martinez Canillas wrote:
> The Microchip Analog to Digital Converter (ADC) Device Tree binding
> documents compatible strings with no vendor prefix. Since it should
> compatible strings with also a vendor, add these to the binding doc
> and mark the old ones as deprecated.
> 
> The driver says that the device is from Microchip Technology which
> is listed in Documentation/devicetree/bindings/vendor-prefixes.txt
> so use the documented prefix.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  .../devicetree/bindings/iio/adc/mcp320x.txt        | 30 +++++++++++++++-------
>  1 file changed, 21 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
> index 2a1f3af30155..bcd3ac8e6e0c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
> @@ -10,16 +10,28 @@ must be specified.
>  Required properties:
>  	- compatible:  	Must be one of the following, depending on the
>  			model:
> -				"mcp3001"
> -				"mcp3002"
> -				"mcp3004"
> -				"mcp3008"
> -				"mcp3201"
> -				"mcp3202"
> -				"mcp3204"
> -				"mcp3208"
> -				"mcp3301"
> +				"mcp3001" (DEPRECATED)
> +				"mcp3002" (DEPRECATED)
> +				"mcp3004" (DEPRECATED)
> +				"mcp3008" (DEPRECATED)
> +				"mcp3201" (DEPRECATED)
> +				"mcp3202" (DEPRECATED)
> +				"mcp3204" (DEPRECATED)
> +				"mcp3208" (DEPRECATED)
> +				"mcp3301" (DEPRECATED)
>  
> +				"microchip,mcp3001"
> +				"microchip,mcp3002"
> +				"microchip,mcp3004"
> +				"microchip,mcp3008"
> +				"microchip,mcp3201"
> +				"microchip,mcp3202"
> +				"microchip,mcp3204"
> +				"microchip,mcp3208"
> +				"microchip,mcp3301"
> +
> +			NOTE: The use of the compatibles with no vendor prefix
> +			is deprecated and only listed because old DT use them.
>

Acked-by: Michael Welling <mwelling@ieee.org>
  
>  Examples:
>  spi_controller {
> -- 
> 2.4.3
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jonathan Cameron Oct. 25, 2015, 12:35 p.m. UTC | #2
On 14/10/15 13:54, Javier Martinez Canillas wrote:
> The Microchip Analog to Digital Converter (ADC) Device Tree binding
> documents compatible strings with no vendor prefix. Since it should
> compatible strings with also a vendor, add these to the binding doc
> and mark the old ones as deprecated.
> 
> The driver says that the device is from Microchip Technology which
> is listed in Documentation/devicetree/bindings/vendor-prefixes.txt
> so use the documented prefix.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied to the togreg branch of iio.git - initially pushed out as testing.
Thanks,
> ---
> 
>  .../devicetree/bindings/iio/adc/mcp320x.txt        | 30 +++++++++++++++-------
>  1 file changed, 21 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
> index 2a1f3af30155..bcd3ac8e6e0c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
> @@ -10,16 +10,28 @@ must be specified.
>  Required properties:
>  	- compatible:  	Must be one of the following, depending on the
>  			model:
> -				"mcp3001"
> -				"mcp3002"
> -				"mcp3004"
> -				"mcp3008"
> -				"mcp3201"
> -				"mcp3202"
> -				"mcp3204"
> -				"mcp3208"
> -				"mcp3301"
> +				"mcp3001" (DEPRECATED)
> +				"mcp3002" (DEPRECATED)
> +				"mcp3004" (DEPRECATED)
> +				"mcp3008" (DEPRECATED)
> +				"mcp3201" (DEPRECATED)
> +				"mcp3202" (DEPRECATED)
> +				"mcp3204" (DEPRECATED)
> +				"mcp3208" (DEPRECATED)
> +				"mcp3301" (DEPRECATED)
>  
> +				"microchip,mcp3001"
> +				"microchip,mcp3002"
> +				"microchip,mcp3004"
> +				"microchip,mcp3008"
> +				"microchip,mcp3201"
> +				"microchip,mcp3202"
> +				"microchip,mcp3204"
> +				"microchip,mcp3208"
> +				"microchip,mcp3301"
> +
> +			NOTE: The use of the compatibles with no vendor prefix
> +			is deprecated and only listed because old DT use them.
>  
>  Examples:
>  spi_controller {
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jonathan Cameron Oct. 25, 2015, 12:36 p.m. UTC | #3
On 14/10/15 16:27, Michael Welling wrote:
> On Wed, Oct 14, 2015 at 02:54:38PM +0200, Javier Martinez Canillas wrote:
>> The Microchip Analog to Digital Converter (ADC) Device Tree binding
>> documents compatible strings with no vendor prefix. Since it should
>> compatible strings with also a vendor, add these to the binding doc
>> and mark the old ones as deprecated.
>>
>> The driver says that the device is from Microchip Technology which
>> is listed in Documentation/devicetree/bindings/vendor-prefixes.txt
>> so use the documented prefix.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>>  .../devicetree/bindings/iio/adc/mcp320x.txt        | 30 +++++++++++++++-------
>>  1 file changed, 21 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
>> index 2a1f3af30155..bcd3ac8e6e0c 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
>> +++ b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
>> @@ -10,16 +10,28 @@ must be specified.
>>  Required properties:
>>  	- compatible:  	Must be one of the following, depending on the
>>  			model:
>> -				"mcp3001"
>> -				"mcp3002"
>> -				"mcp3004"
>> -				"mcp3008"
>> -				"mcp3201"
>> -				"mcp3202"
>> -				"mcp3204"
>> -				"mcp3208"
>> -				"mcp3301"
>> +				"mcp3001" (DEPRECATED)
>> +				"mcp3002" (DEPRECATED)
>> +				"mcp3004" (DEPRECATED)
>> +				"mcp3008" (DEPRECATED)
>> +				"mcp3201" (DEPRECATED)
>> +				"mcp3202" (DEPRECATED)
>> +				"mcp3204" (DEPRECATED)
>> +				"mcp3208" (DEPRECATED)
>> +				"mcp3301" (DEPRECATED)
>>  
>> +				"microchip,mcp3001"
>> +				"microchip,mcp3002"
>> +				"microchip,mcp3004"
>> +				"microchip,mcp3008"
>> +				"microchip,mcp3201"
>> +				"microchip,mcp3202"
>> +				"microchip,mcp3204"
>> +				"microchip,mcp3208"
>> +				"microchip,mcp3301"
>> +
>> +			NOTE: The use of the compatibles with no vendor prefix
>> +			is deprecated and only listed because old DT use them.
>>
> 
> Acked-by: Michael Welling <mwelling@ieee.org>
Small point, Michael. Please add such acks below the the Author sign off.
Otherwise sometimes I miss them!  Added it now for this one.
>   
>>  Examples:
>>  spi_controller {
>> -- 
>> 2.4.3
>>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michael Welling Oct. 25, 2015, 7:34 p.m. UTC | #4
On Sun, Oct 25, 2015 at 12:36:37PM +0000, Jonathan Cameron wrote:
> Small point, Michael. Please add such acks below the the Author sign off.
> Otherwise sometimes I miss them!  Added it now for this one.

Okay sorry about the misplacement.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
index 2a1f3af30155..bcd3ac8e6e0c 100644
--- a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
+++ b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
@@ -10,16 +10,28 @@  must be specified.
 Required properties:
 	- compatible:  	Must be one of the following, depending on the
 			model:
-				"mcp3001"
-				"mcp3002"
-				"mcp3004"
-				"mcp3008"
-				"mcp3201"
-				"mcp3202"
-				"mcp3204"
-				"mcp3208"
-				"mcp3301"
+				"mcp3001" (DEPRECATED)
+				"mcp3002" (DEPRECATED)
+				"mcp3004" (DEPRECATED)
+				"mcp3008" (DEPRECATED)
+				"mcp3201" (DEPRECATED)
+				"mcp3202" (DEPRECATED)
+				"mcp3204" (DEPRECATED)
+				"mcp3208" (DEPRECATED)
+				"mcp3301" (DEPRECATED)
 
+				"microchip,mcp3001"
+				"microchip,mcp3002"
+				"microchip,mcp3004"
+				"microchip,mcp3008"
+				"microchip,mcp3201"
+				"microchip,mcp3202"
+				"microchip,mcp3204"
+				"microchip,mcp3208"
+				"microchip,mcp3301"
+
+			NOTE: The use of the compatibles with no vendor prefix
+			is deprecated and only listed because old DT use them.
 
 Examples:
 spi_controller {