Patchwork [1/6] sata_mv: drop unncessary EH callback resetting

login
register
mail settings
Submitter Tejun Heo
Date May 19, 2010, 8:10 p.m.
Message ID <1274299824-15691-2-git-send-email-tj@kernel.org>
Download mbox | patch
Permalink /patch/53015/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Tejun Heo - May 19, 2010, 8:10 p.m.
Now that BMDMA EH ops are separated out from SFF ops, mv5_ops doesn't
have to explicitly reset ->error_handler() and ->post_internal_cmd().
Drop them.

Signed-off-by: Tejun Heo <tj@kernel.org>
---
 drivers/ata/sata_mv.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Jeff Garzik - May 25, 2010, 11:42 p.m.
On 05/19/2010 04:10 PM, Tejun Heo wrote:
> Now that BMDMA EH ops are separated out from SFF ops, mv5_ops doesn't
> have to explicitly reset ->error_handler() and ->post_internal_cmd().
> Drop them.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> ---
>   drivers/ata/sata_mv.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index f3471bc..16bacd3 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -675,8 +675,6 @@ static struct ata_port_operations mv5_ops = {
>   	.freeze			= mv_eh_freeze,
>   	.thaw			= mv_eh_thaw,
>   	.hardreset		= mv_hardreset,
> -	.error_handler		= ata_std_error_handler, /* avoid SFF EH */
> -	.post_internal_cmd	= ATA_OP_NULL,

applied 1-6


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index f3471bc..16bacd3 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -675,8 +675,6 @@  static struct ata_port_operations mv5_ops = {
 	.freeze			= mv_eh_freeze,
 	.thaw			= mv_eh_thaw,
 	.hardreset		= mv_hardreset,
-	.error_handler		= ata_std_error_handler, /* avoid SFF EH */
-	.post_internal_cmd	= ATA_OP_NULL,
 
 	.scr_read		= mv5_scr_read,
 	.scr_write		= mv5_scr_write,