diff mbox

[v2,1/6] MIPS: Initial support of bonito north bridge used by fulong mini pc

Message ID 1274279192-2344-1-git-send-email-zltjiangshi@gmail.com
State New
Headers show

Commit Message

chen huacai May 19, 2010, 2:26 p.m. UTC
Signed-off-by: Huacai Chen <zltjiangshi@gmail.com>
---
 Makefile.target                      |    1 +
 default-configs/mips64el-softmmu.mak |    1 +
 hw/bonito.c                          |  950 ++++++++++++++++++++++++++++++++++
 hw/mips.h                            |    3 +
 4 files changed, 955 insertions(+), 0 deletions(-)
 create mode 100644 hw/bonito.c

Comments

Aurelien Jarno May 28, 2010, 8:31 p.m. UTC | #1
Please find my comments below. Note that I don't feel very comfortable
with PCI code, so a review from someone know this part of QEMU would be
nice.

On Wed, May 19, 2010 at 10:26:32PM +0800, Huacai Chen wrote:
> Signed-off-by: Huacai Chen <zltjiangshi@gmail.com>
> ---
>  Makefile.target                      |    1 +
>  default-configs/mips64el-softmmu.mak |    1 +
>  hw/bonito.c                          |  950 ++++++++++++++++++++++++++++++++++
>  hw/mips.h                            |    3 +
>  4 files changed, 955 insertions(+), 0 deletions(-)
>  create mode 100644 hw/bonito.c
> 
> diff --git a/Makefile.target b/Makefile.target
> index a22484e..247a2eb 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -221,6 +221,7 @@ obj-mips-y += dma.o vga.o i8259.o
>  obj-mips-y += g364fb.o jazz_led.o
>  obj-mips-y += gt64xxx.o pckbd.o mc146818rtc.o
>  obj-mips-y += piix4.o cirrus_vga.o
> +obj-mips-$(CONFIG_FULONG) += bonito.o
>  
>  obj-microblaze-y = petalogix_s3adsp1800_mmu.o
>  
> diff --git a/default-configs/mips64el-softmmu.mak b/default-configs/mips64el-softmmu.mak
> index 6fa54a3..b731c74 100644
> --- a/default-configs/mips64el-softmmu.mak
> +++ b/default-configs/mips64el-softmmu.mak
> @@ -27,3 +27,4 @@ CONFIG_DP8393X=y
>  CONFIG_DS1225Y=y
>  CONFIG_MIPSNET=y
>  CONFIG_PFLASH_CFI01=y
> +CONFIG_FULONG=y
> diff --git a/hw/bonito.c b/hw/bonito.c
> new file mode 100644
> index 0000000..246c12a
> --- /dev/null
> +++ b/hw/bonito.c
> @@ -0,0 +1,950 @@
> +/*
> + * bonito north bridge support
> + *
> + * Copyright (c) 2008 yajin (yajin@vm-kernel.org)
> + * Copyright (c) 2010 Huacai Chen (zltjiangshi@gmail.com)
> + *
> + * This code is licensed under the GNU GPL v2.
> + */
> +
> +/*
> + * fulong 2e mini pc has a bonito north bridge.
> + */
> +
> +/* what is the meaning of devfn in qemu and IDSEL in bonito northbridge?
> + *
> + * devfn   pci_slot<<3  + funno
> + * one pci bus can have 32 devices and each device can have 8 functions.
> + *
> + * In bonito north bridge, pci slot = IDSEL bit - 12.
> + * For example, PCI_IDSEL_VIA686B = 17,
> + * pci slot = 17-12=5
> + *
> + * so
> + * VT686B_FUN0's devfn = (5<<3)+0
> + * VT686B_FUN1's devfn = (5<<3)+1
> + *
> + * qemu also uses pci address for north bridge to access pci config register.
> + * bus_no   [23:16]
> + * dev_no   [15:11]
> + * fun_no   [10:8]
> + * reg_no   [7:2]
> + *
> + * so function bonito_sbridge_pciaddr for the translation from
> + * north bridge address to pci address.
> + */
> +
> +#include <assert.h>
> +
> +#include "hw.h"
> +#include "pci.h"
> +#include "pc.h"
> +#include "mips.h"
> +
> +typedef target_phys_addr_t pci_addr_t;
> +#include "pci_host.h"
> +
> +//#define DEBUG_BONITO
> +
> +#ifdef DEBUG_BONITO
> +#define DPRINTF(fmt, ...) fprintf(stderr, "%s: " fmt, __FUNCTION__, ##__VA_ARGS__)
> +#else
> +#define DPRINTF(fmt, ...)
> +#endif
> +
> +/* from linux soure code. include/asm-mips/mips-boards/bonito64.h*/
> +#define BONITO_BOOT_BASE        0x1fc00000
> +#define BONITO_BOOT_SIZE        0x00100000
> +#define BONITO_BOOT_TOP         (BONITO_BOOT_BASE+BONITO_BOOT_SIZE-1)
> +#define BONITO_FLASH_BASE       0x1c000000
> +#define BONITO_FLASH_SIZE       0x03000000
> +#define BONITO_FLASH_TOP        (BONITO_FLASH_BASE+BONITO_FLASH_SIZE-1)
> +#define BONITO_SOCKET_BASE      0x1f800000
> +#define BONITO_SOCKET_SIZE      0x00400000
> +#define BONITO_SOCKET_TOP       (BONITO_SOCKET_BASE+BONITO_SOCKET_SIZE-1)
> +#define BONITO_REG_BASE         0x1fe00000
> +#define BONITO_REG_SIZE         0x00040000
> +#define BONITO_REG_TOP          (BONITO_REG_BASE+BONITO_REG_SIZE-1)
> +#define BONITO_DEV_BASE         0x1ff00000
> +#define BONITO_DEV_SIZE         0x00100000
> +#define BONITO_DEV_TOP          (BONITO_DEV_BASE+BONITO_DEV_SIZE-1)
> +#define BONITO_PCILO_BASE       0x10000000
> +#define BONITO_PCILO_BASE_VA    0xb0000000
> +#define BONITO_PCILO_SIZE       0x0c000000
> +#define BONITO_PCILO_TOP        (BONITO_PCILO_BASE+BONITO_PCILO_SIZE-1)
> +#define BONITO_PCILO0_BASE      0x10000000
> +#define BONITO_PCILO1_BASE      0x14000000
> +#define BONITO_PCILO2_BASE      0x18000000
> +#define BONITO_PCIHI_BASE       0x20000000
> +#define BONITO_PCIHI_SIZE       0x20000000
> +#define BONITO_PCIHI_TOP        (BONITO_PCIHI_BASE+BONITO_PCIHI_SIZE-1)
> +#define BONITO_PCIIO_BASE       0x1fd00000
> +#define BONITO_PCIIO_BASE_VA    0xbfd00000
> +#define BONITO_PCIIO_SIZE       0x00010000
> +#define BONITO_PCIIO_TOP        (BONITO_PCIIO_BASE+BONITO_PCIIO_SIZE-1)
> +#define BONITO_PCICFG_BASE      0x1fe80000
> +#define BONITO_PCICFG_SIZE      0x00080000
> +#define BONITO_PCICFG_TOP       (BONITO_PCICFG_BASE+BONITO_PCICFG_SIZE-1)
> +
> +
> +#define BONITO_PCICONFIGBASE    0x00
> +#define BONITO_REGBASE          0x100
> +
> +#define BONITO_PCICONFIG_BASE   (BONITO_PCICONFIGBASE+BONITO_REG_BASE)
> +#define BONITO_PCICONFIG_SIZE   (0x100)
> +
> +#define BONITO_INTERNAL_REG_BASE  (BONITO_REGBASE+BONITO_REG_BASE)
> +#define BONITO_INTERNAL_REG_SIZE  (0x70)
> +
> +#define BONITO_SPCICONFIG_BASE  (BONITO_PCICFG_BASE)
> +#define BONITO_SPCICONFIG_SIZE  (BONITO_PCICFG_SIZE)
> +
> +
> +
> +/* 1. Bonito h/w Configuration */
> +/* Power on register */
> +
> +#define BONITO_BONPONCFG        (0x00 >> 2)      /* 0x100 */
> +#define BONITO_BONGENCFG_OFFSET 0x4
> +#define BONITO_BONGENCFG        (BONITO_BONGENCFG_OFFSET>>2)   /*0x104 */
> +
> +/* 2. IO & IDE configuration */
> +#define BONITO_IODEVCFG         (0x08 >> 2)      /* 0x108 */
> +
> +/* 3. IO & IDE configuration */
> +#define BONITO_SDCFG            (0x0c >> 2)      /* 0x10c */
> +
> +/* 4. PCI address map control */
> +#define BONITO_PCIMAP           (0x10 >> 2)      /* 0x110 */
> +#define BONITO_PCIMEMBASECFG    (0x14 >> 2)      /* 0x114 */
> +#define BONITO_PCIMAP_CFG       (0x18 >> 2)      /* 0x118 */
> +
> +/* 5. ICU & GPIO regs */
> +/* GPIO Regs - r/w */
> +#define BONITO_GPIODATA_OFFSET  0x1c
> +#define BONITO_GPIODATA         (BONITO_GPIODATA_OFFSET >> 2)   /* 0x11c */
> +#define BONITO_GPIOIE           (0x20 >> 2)      /* 0x120 */
> +
> +/* ICU Configuration Regs - r/w */
> +#define BONITO_INTEDGE          (0x24 >> 2)      /* 0x124 */
> +#define BONITO_INTSTEER         (0x28 >> 2)      /* 0x128 */
> +#define BONITO_INTPOL           (0x2c >> 2)      /* 0x12c */
> +
> +/* ICU Enable Regs - IntEn & IntISR are r/o. */
> +#define BONITO_INTENSET         (0x30 >> 2)      /* 0x130 */
> +#define BONITO_INTENCLR         (0x34 >> 2)      /* 0x134 */
> +#define BONITO_INTEN            (0x38 >> 2)      /* 0x138 */
> +#define BONITO_INTISR           (0x3c >> 2)      /* 0x13c */
> +
> +/* PCI mail boxes */
> +#define BONITO_PCIMAIL0_OFFSET    0x40
> +#define BONITO_PCIMAIL1_OFFSET    0x44
> +#define BONITO_PCIMAIL2_OFFSET    0x48
> +#define BONITO_PCIMAIL3_OFFSET    0x4c
> +#define BONITO_PCIMAIL0         (0x40 >> 2)      /* 0x140 */
> +#define BONITO_PCIMAIL1         (0x44 >> 2)      /* 0x144 */
> +#define BONITO_PCIMAIL2         (0x48 >> 2)      /* 0x148 */
> +#define BONITO_PCIMAIL3         (0x4c >> 2)      /* 0x14c */
> +
> +/* 6. PCI cache */
> +#define BONITO_PCICACHECTRL     (0x50 >> 2)      /* 0x150 */
> +#define BONITO_PCICACHETAG      (0x54 >> 2)      /* 0x154 */
> +#define BONITO_PCIBADADDR       (0x58 >> 2)      /* 0x158 */
> +#define BONITO_PCIMSTAT         (0x5c >> 2)      /* 0x15c */
> +
> +/* 7. other*/
> +#define BONITO_TIMECFG          (0x60 >> 2)      /* 0x160 */
> +#define BONITO_CPUCFG           (0x64 >> 2)      /* 0x164 */
> +#define BONITO_DQCFG            (0x68 >> 2)      /* 0x168 */
> +#define BONITO_MEMSIZE          (0x6C >> 2)      /* 0x16c */
> +
> +#define BONITO_REGS             (0x70 >> 2)
> +
> +/* PCI config for south bridge. type 0 */
> +#define BONITO_PCICONF_IDSEL_MASK      0xfffff800     /* [31:11] */
> +#define BONITO_PCICONF_IDSEL_OFFSET    11
> +#define BONITO_PCICONF_FUN_MASK        0x700    /* [10:8] */
> +#define BONITO_PCICONF_FUN_OFFSET      8
> +#define BONITO_PCICONF_REG_MASK        0xFC
> +#define BONITO_PCICONF_REG_OFFSET      0
> +
> +
> +/* idsel BIT = pci slot number +12 */
> +#define PCI_SLOT_BASE              12
> +#define PCI_IDSEL_VIA686B_BIT      (17)
> +#define PCI_IDSEL_VIA686B          (1<<PCI_IDSEL_VIA686B_BIT)
> +
> +#define PCI_ADDR(busno,devno,funno,regno)  \
> +    ((((busno)<<16)&0xff0000) + (((devno)<<11)&0xf800) + (((funno)<<8)&0x700) + (regno))
> +
> +typedef PCIHostState BonitoState;
> +
> +typedef struct PCIBonitoState
> +{
> +    PCIDevice dev;
> +    BonitoState *pcihost;
> +    uint32_t regs[BONITO_REGS];
> +
> +    struct bonldma {
> +        uint32_t ldmactrl;
> +        uint32_t ldmastat;
> +        uint32_t ldmaaddr;
> +        uint32_t ldmago;
> +    } bonldma;
> +
> +    /* Based at 1fe00300, bonito Copier */
> +    struct boncop {
> +        uint32_t copctrl;
> +        uint32_t copstat;
> +        uint32_t coppaddr;
> +        uint32_t copgo;
> +    } boncop;
> +
> +    /* north brige pci config */
> +    uint8_t config[256];

Why not using the config field from PCIDevice ?

> +
> +    /* Bonito registers */
> +    target_phys_addr_t bonito_reg_start;
> +    target_phys_addr_t bonito_reg_length;
> +    int bonito_reg_handle;
> +
> +    target_phys_addr_t bonito_pciconf_start;
> +    target_phys_addr_t bonito_pciconf_length;
> +    int bonito_pciconf_handle;
> +
> +    target_phys_addr_t bonito_spciconf_start;
> +    target_phys_addr_t bonito_spciconf_length;
> +    int bonito_spciconf_handle;
> +
> +    target_phys_addr_t bonito_pciio_start;
> +    target_phys_addr_t bonito_pciio_length;
> +    int bonito_pciio_handle;
> +
> +    target_phys_addr_t bonito_localio_start;
> +    target_phys_addr_t bonito_localio_length;
> +    int bonito_localio_handle;
> +
> +    target_phys_addr_t bonito_ldma_start;
> +    target_phys_addr_t bonito_ldma_length;
> +    int bonito_ldma_handle;
> +
> +    target_phys_addr_t bonito_cop_start;
> +    target_phys_addr_t bonito_cop_length;
> +    int bonito_cop_handle;
> +
> +} PCIBonitoState;
> +
> +PCIBonitoState * bonito_state;
> +
> +static void bonito_writeb(void *opaque, target_phys_addr_t addr, uint32_t val)
> +{
> +    DPRINTF("bonito_writeb "TARGET_FMT_plx" val %x  \n", addr, val);
> +}
> +
> +static void bonito_writew(void *opaque, target_phys_addr_t addr, uint32_t val)
> +{
> +    DPRINTF("bonito_writew "TARGET_FMT_plx" val %x  \n", addr, val);
> +}

Are byte and word access supported on this chipset? If not, it would be
better to declare the two first entries of CPUWriteMemoryFunc as NULL.

> +static void bonito_writel(void *opaque, target_phys_addr_t addr, uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t saddr;
> +    int reset = 0;
> +
> +    saddr = (addr - 0x100) >> 2;

Where this 0x100 comes from?

> +
> +    DPRINTF("bonito_writel "TARGET_FMT_plx" val %x saddr %x \n", addr, val, saddr);
> +    switch (saddr) {
> +    case BONITO_BONPONCFG:
> +    case BONITO_IODEVCFG:
> +    case BONITO_SDCFG:
> +    case BONITO_PCIMAP:
> +    case BONITO_PCIMEMBASECFG:
> +    case BONITO_PCIMAP_CFG:
> +    case BONITO_GPIODATA:
> +    case BONITO_GPIOIE:
> +    case BONITO_INTEDGE:
> +    case BONITO_INTSTEER:
> +    case BONITO_INTPOL:
> +    case BONITO_PCIMAIL0:
> +    case BONITO_PCIMAIL1:
> +    case BONITO_PCIMAIL2:
> +    case BONITO_PCIMAIL3:
> +    case BONITO_PCICACHECTRL:
> +    case BONITO_PCICACHETAG:
> +    case BONITO_PCIBADADDR:
> +    case BONITO_PCIMSTAT:
> +    case BONITO_TIMECFG:
> +    case BONITO_CPUCFG:
> +    case BONITO_DQCFG:
> +    case BONITO_MEMSIZE:
> +        s->regs[saddr] = val;
> +        break;
> +    case BONITO_BONGENCFG:
> +        if (!(s->regs[saddr] & 0x04) && (val & 0x04)) {
> +            reset = 1; /* bit 2 jump from 0 to 1 cause reset */
> +        }
> +        s->regs[saddr] = val;
> +        if (reset) {
> +            qemu_system_reset_request();
> +        }
> +        break;
> +    case BONITO_INTENSET:
> +        s->regs[BONITO_INTENSET] = val;
> +        s->regs[BONITO_INTEN] |= val;
> +        break;
> +    case BONITO_INTENCLR:
> +        s->regs[BONITO_INTENCLR] = val;
> +        s->regs[BONITO_INTEN] &= ~val;
> +        break;
> +    case BONITO_INTEN:
> +    case BONITO_INTISR:
> +    DPRINTF("write to readonly bonito register %x \n", saddr);

indentation issue

> +        break;
> +    default:
> +    DPRINTF("write to unknown bonito register %x \n", saddr);

indentation issue

> +        break;
> +    }
> +}
> +
> +static uint32_t bonito_readb(void *opaque, target_phys_addr_t addr)
> +{
> +    DPRINTF("bonito_readb "TARGET_FMT_plx"  \n", addr);
> +    return 0;
> +}
> +
> +static uint32_t bonito_readw(void *opaque, target_phys_addr_t addr)
> +{
> +    DPRINTF("bonito_readw "TARGET_FMT_plx"  \n", addr);
> +    return 0;
> +}

Same as for write.

> +static uint32_t bonito_readl(void *opaque, target_phys_addr_t addr)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t saddr;
> +
> +    saddr = (addr - 0x100) >> 2;
> +
> +    DPRINTF("bonito_readl "TARGET_FMT_plx"  \n", addr);
> +    switch (saddr) {
> +    case BONITO_INTISR:
> +        return s->regs[saddr];
> +    default:
> +        return s->regs[saddr];
> +    }
> +}
> +
> +static CPUWriteMemoryFunc * const bonito_write[] = {
> +    bonito_writeb,
> +    bonito_writew,
> +    bonito_writel,
> +};
> +
> +static CPUReadMemoryFunc * const bonito_read[] = {
> +    bonito_readb,
> +    bonito_readw,
> +    bonito_readl,
> +};
> +
> +static void bonito_pciconf_writeb(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    DPRINTF("bonito_pciconf_writeb "TARGET_FMT_plx" val %x \n", addr, val);
> +}
> +
> +static void bonito_pciconf_writew(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    DPRINTF("bonito_pciconf_writew "TARGET_FMT_plx" val %x \n", addr, val);
> +}

Same as previously.

> +static void bonito_pciconf_writel(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t saddr;
> +    uint32_t *ptr = (uint32_t *) s->config;
> +
> +    saddr = (addr) >> 2;
> +    DPRINTF("bonito_pciconf_writel "TARGET_FMT_plx" val %x \n", addr, val);
> +    ptr += saddr;
> +    *ptr = val;
> +}
> +
> +static uint32_t bonito_pciconf_readb(void *opaque, target_phys_addr_t addr)
> +{
> +    DPRINTF("bonito_pciconf_readb "TARGET_FMT_plx"\n", addr);
> +    return 0;
> +}
> +static uint32_t bonito_pciconf_readw(void *opaque, target_phys_addr_t addr)
> +{
> +    DPRINTF("bonito_pciconf_readw "TARGET_FMT_plx"\n", addr);
> +    return 0;
> +}
> +
> +static uint32_t bonito_pciconf_readl(void *opaque, target_phys_addr_t addr)
> +{
> +
> +    PCIBonitoState *s = opaque;
> +    uint32_t saddr;
> +    uint32_t *ptr = (uint32_t *) s->config;
> +
> +    saddr = (addr) >> 2;
> +    DPRINTF("bonito_pciconf_readl "TARGET_FMT_plx"\n", addr);
> +    ptr += saddr;
> +
> +    return (*ptr);
> +}
> +
> +/* north bridge PCI configure space. 0x1fe0 0000 - 0x1fe0 00ff */
> +static CPUWriteMemoryFunc * const bonito_pciconf_write[] = {
> +    bonito_pciconf_writeb,
> +    bonito_pciconf_writew,
> +    bonito_pciconf_writel,
> +};
> +
> +static CPUReadMemoryFunc * const bonito_pciconf_read[] = {
> +    bonito_pciconf_readb,
> +    bonito_pciconf_readw,
> +    bonito_pciconf_readl,
> +};
> +
> +static uint32_t bonito_localio_readb(void *opaque, target_phys_addr_t addr)
> +{
> +    uint32_t val;
> +
> +    DPRINTF("bonito_localio_readb "TARGET_FMT_plx"\n", addr);
> +    val = cpu_inb(addr & 0xffff);
> +    return val;
> +}

This function and the related ones below should probably use isa_mmio
instead.

> +static uint32_t bonito_localio_readw(void *opaque, target_phys_addr_t addr)
> +{
> +    uint32_t val;
> +
> +    DPRINTF("bonito_localio_readw "TARGET_FMT_plx"\n", addr);
> +    val = cpu_inw(addr & 0xffff);
> +#ifdef TARGET_WORDS_BIGENDIAN
> +    val = bswap16(val);
> +#endif
> +    return val;
> +}
> +
> +static uint32_t bonito_localio_readl(void *opaque, target_phys_addr_t addr)
> +{
> +    uint32_t val;
> +
> +    DPRINTF("bonito_localio_readl "TARGET_FMT_plx"\n", addr);
> +    val = cpu_inl(addr & 0xffff);
> +#ifdef TARGET_WORDS_BIGENDIAN
> +    val = bswap32(val);
> +#endif
> +    return val;
> +}
> +
> +static void bonito_localio_writeb(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    DPRINTF("bonito_localio_writeb "TARGET_FMT_plx"\n", addr);
> +    cpu_outb(addr & 0xffff, val);
> +}
> +
> +static void bonito_localio_writew(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    DPRINTF("bonito_localio_writew "TARGET_FMT_plx"\n", addr);
> +#ifdef TARGET_WORDS_BIGENDIAN
> +    val = bswap16(val);
> +#endif
> +    cpu_outw(addr & 0xffff, val);
> +}
> +
> +static void bonito_localio_writel(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    DPRINTF("bonito_localio_writel "TARGET_FMT_plx"\n", addr);
> +#ifdef TARGET_WORDS_BIGENDIAN
> +    val = bswap32(val);
> +#endif
> +    cpu_outl(addr & 0xffff, val);
> +}
> +
> +static CPUReadMemoryFunc * const bonito_localio_read[] = {
> +    bonito_localio_readb,
> +    bonito_localio_readw,
> +    bonito_localio_readl,
> +};
> +
> +static CPUWriteMemoryFunc * const bonito_localio_write[] = {
> +    bonito_localio_writeb,
> +    bonito_localio_writew,
> +    bonito_localio_writel,
> +};
> +
> +static uint32_t bonito_ldma_readl(void *opaque, target_phys_addr_t addr)
> +{
> +    uint32_t val;
> +    PCIBonitoState *s = opaque;
> +
> +    val = ((uint32_t *)(&s->bonldma))[addr/sizeof(uint32_t)];
> +
> +    return val;
> +}
> +
> +static void bonito_ldma_writel(void *opaque, target_phys_addr_t addr,
> +                               uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +
> +    ((uint32_t *)(&s->bonldma))[addr/sizeof(uint32_t)] = val & 0xffffffff;
> +}
> +
> +static CPUWriteMemoryFunc * const bonito_ldma_write[] = {
> +    bonito_ldma_writel,
> +    bonito_ldma_writel,
> +    bonito_ldma_writel,
> +};
> +
> +static CPUReadMemoryFunc * const bonito_ldma_read[] = {
> +    bonito_ldma_readl,
> +    bonito_ldma_readl,
> +    bonito_ldma_readl,
> +};
> +
> +static uint32_t bonito_cop_readl(void *opaque, target_phys_addr_t addr)
> +{
> +    uint32_t val;
> +    PCIBonitoState *s = opaque;
> +
> +    val = ((uint32_t *)(&s->boncop))[addr/sizeof(uint32_t)];
> +
> +    return val;
> +}
> +
> +static void bonito_cop_writel(void *opaque, target_phys_addr_t addr,
> +                              uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +
> +    ((uint32_t *)(&s->boncop))[addr/sizeof(uint32_t)] = val & 0xffffffff;
> +}
> +
> +static CPUWriteMemoryFunc * const bonito_cop_write[] = {
> +    bonito_cop_writel,
> +    bonito_cop_writel,
> +    bonito_cop_writel,
> +};
> +
> +static CPUReadMemoryFunc * const bonito_cop_read[] = {
> +    bonito_cop_readl,
> +    bonito_cop_readl,
> +    bonito_cop_readl,
> +};
> +
> +static uint32_t bonito_sbridge_pciaddr(void *opaque, target_phys_addr_t addr)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t cfgaddr;
> +    uint32_t idsel;
> +    uint32_t devno;
> +    uint32_t funno;
> +    uint32_t regno;
> +    uint32_t pciaddr;
> +
> +    /* support type0 pci config */
> +    if ((s->regs[BONITO_PCIMAP_CFG] & 0x10000) != 0x0) {
> +        return 0xffffffff;
> +    }
> +
> +    cfgaddr = addr & 0xffff;
> +    cfgaddr |= (s->regs[BONITO_PCIMAP_CFG] & 0xffff) << 16;
> +
> +    idsel = (cfgaddr & BONITO_PCICONF_IDSEL_MASK) >> BONITO_PCICONF_IDSEL_OFFSET;
> +    devno = ffs(idsel) - 1;
> +    funno = (cfgaddr & BONITO_PCICONF_FUN_MASK) >> BONITO_PCICONF_FUN_OFFSET;
> +    regno = (cfgaddr & BONITO_PCICONF_REG_MASK) >> BONITO_PCICONF_REG_OFFSET;
> +
> +    if (idsel == 0) {
> +        fprintf(stderr, "error in bonito pci config address" TARGET_FMT_plx
> +            ",pcimap_cfg=%x\n", addr, s->regs[BONITO_PCIMAP_CFG]);
> +        exit(1);
> +    }
> +    pciaddr = PCI_ADDR(pci_bus_num(s->pcihost->bus), devno, funno, regno);
> +    DPRINTF("cfgaddr %x pciaddr %x busno %x devno %d funno %d regno %d \n",
> +        cfgaddr, pciaddr, pci_bus_num(s->pcihost->bus), devno, funno, regno);
> +
> +    return pciaddr;
> +}
> +
> +static void bonito_spciconf_writeb(void *opaque, target_phys_addr_t addr,
> +                                   uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_writeb "TARGET_FMT_plx" val %x \n", addr, val);
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val & 0xff, 1);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +}
> +
> +static void bonito_spciconf_writew(void *opaque, target_phys_addr_t addr,
> +                                   uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_writew "TARGET_FMT_plx" val %x \n", addr, val);
> +    assert((addr&0x1)==0);
> +
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val, 2);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +}
> +
> +static void bonito_spciconf_writel(void *opaque, target_phys_addr_t addr,
> +                                   uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_writel "TARGET_FMT_plx" val %x \n", addr, val);
> +    assert((addr&0x3)==0);
> +
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val, 4);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +}
> +
> +static uint32_t bonito_spciconf_readb(void *opaque, target_phys_addr_t addr)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_readb "TARGET_FMT_plx"  \n", addr);
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return 0xff;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +
> +    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 1);
> +}
> +
> +static uint32_t bonito_spciconf_readw(void *opaque, target_phys_addr_t addr)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_readw "TARGET_FMT_plx"  \n", addr);
> +    assert((addr&0x1)==0);
> +
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return 0xffff;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +
> +    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 2);
> +}
> +
> +static uint32_t bonito_spciconf_readl(void *opaque, target_phys_addr_t addr)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_readl "TARGET_FMT_plx"  \n", addr);
> +    assert((addr&0x3) == 0);
> +
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return 0xffffffff;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +
> +    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 4);
> +}
> +
> +/* south bridge PCI configure space. 0x1fe8 0000 - 0x1fef ffff */
> +static CPUWriteMemoryFunc * const bonito_spciconf_write[] = {
> +    bonito_spciconf_writeb,
> +    bonito_spciconf_writew,
> +    bonito_spciconf_writel,
> +};
> +
> +static CPUReadMemoryFunc * const bonito_spciconf_read[] = {
> +    bonito_spciconf_readb,
> +    bonito_spciconf_readw,
> +    bonito_spciconf_readl,
> +};
> +
> +#define BONITO_IRQ_BASE 32
> +
> +static void pci_bonito_set_irq(void *opaque, int irq_num, int level)
> +{
> +    qemu_irq pic = opaque;
> +    int internal_irq = irq_num - BONITO_IRQ_BASE;
> +
> +    if (bonito_state->regs[BONITO_INTEDGE] & (1<<internal_irq)) {
> +        qemu_irq_pulse(pic);
> +    } else {   /* level triggered */
> +        if (bonito_state->regs[BONITO_INTPOL] & (1<<internal_irq)) {
> +            qemu_irq_raise(pic);
> +        } else {
> +            qemu_irq_lower(pic);
> +        }
> +    }
> +}
> +
> +/* map the original irq (0~3) to bonito irq (16~47, but 16~31 are unused) */
> +static int pci_bonito_map_irq(PCIDevice * pci_dev, int irq_num)
> +{
> +    int slot;
> +
> +    slot = (pci_dev->devfn >> 3);
> +
> +    switch (slot) {
> +    case 5:   /* FULONG2E_VIA_SLOT, SouthBridge, IDE, USB, ACPI, AC97, MC97 */
> +        return irq_num % 4 + BONITO_IRQ_BASE;
> +    case 6:   /* FULONG2E_ATI_SLOT, VGA */
> +        return 4 + BONITO_IRQ_BASE;
> +    case 7:   /* FULONG2E_RTL_SLOT, RTL8139 */
> +        return 5 + BONITO_IRQ_BASE;
> +    case 8 ... 12: /* PCI slot 1 to 4 */
> +        return (slot - 8 + irq_num) + 6 + BONITO_IRQ_BASE;
> +    default:  /* Unknown device, don't do any translation */
> +        return irq_num;
> +    }
> +}
> +
> +static void bonito_reset(void *opaque)
> +{
> +    PCIBonitoState *s = opaque;
> +
> +    /* set the default value of north bridge pci config */
> +    s->config[0x04] = 0x00;
> +    s->config[0x05] = 0x00;
> +    s->config[0x06] = 0x00;
> +    s->config[0x07] = 0x00;
> +
> +    s->config[0x08] = 0x01;
> +    s->config[0x09] = 0x00;
> +    s->config[0x0a] = 0x00;
> +    s->config[0x0b] = 0x06;
> +
> +    s->config[0x2c] = 0x00;
> +    s->config[0x2d] = 0x00;
> +    s->config[0x2e] = 0x00;
> +    s->config[0x2f] = 0x00;
> +
> +    s->config[0x3c] = 0x00;
> +    s->config[0x3d] = 0x01;
> +    s->config[0x3e] = 0x3c;
> +    s->config[0x3f] = 0x00;
> +
> +    /* set the default value of north bridge registers */
> +
> +    s->regs[BONITO_BONPONCFG] = 0xc40;
> +    s->regs[BONITO_BONGENCFG] = 0x1384;

Is it the correct reset value? I am surprised the reset bit (0x04) is
enabled.

> +    s->regs[BONITO_IODEVCFG] = 0x2bff8010;
> +    s->regs[BONITO_SDCFG] = 0x255e0091;
> +
> +    s->regs[BONITO_GPIODATA] = 0x1ff;
> +    s->regs[BONITO_GPIOIE] = 0x1ff;
> +    s->regs[BONITO_DQCFG] = 0x8;
> +    s->regs[BONITO_MEMSIZE] = 0x10000000;
> +    s->regs[BONITO_PCIMAP] = 0x6140;
> +}
> +
> +static const VMStateDescription vmstate_bonito = {
> +    .name = "Bonito",
> +    .version_id = 1,
> +    .minimum_version_id = 1,
> +    .minimum_version_id_old = 1,
> +    .fields      = (VMStateField []) {
> +        VMSTATE_PCI_DEVICE(dev, PCIBonitoState),
> +        VMSTATE_END_OF_LIST()
> +    }
> +};
> +
> +static int bonito_pcihost_initfn(SysBusDevice *dev)
> +{
> +    return 0;
> +}
> +
> +static int bonito_initfn(PCIDevice *dev)
> +{
> +    PCIBonitoState *s = DO_UPCAST(PCIBonitoState, dev, dev);
> +
> +    /* Bonito North Bridge, built on FPGA, VENDOR_ID/DEVICE_ID are "undefined" */
> +    pci_config_set_vendor_id(dev->config, 0xdf53);
> +    pci_config_set_device_id(dev->config, 0x00d5);
> +    pci_config_set_class(dev->config, PCI_CLASS_BRIDGE_HOST);
> +
> +    /* set the north bridge register mapping */
> +    s->bonito_reg_handle = cpu_register_io_memory(bonito_read, bonito_write, s);
> +    s->bonito_reg_start = BONITO_INTERNAL_REG_BASE;
> +    s->bonito_reg_length = BONITO_INTERNAL_REG_SIZE;
> +    cpu_register_physical_memory(s->bonito_reg_start, s->bonito_reg_length,
> +                                 s->bonito_reg_handle);
> +
> +    /* set the north bridge pci configure  mapping */
> +    s->bonito_pciconf_handle = cpu_register_io_memory(bonito_pciconf_read,
> +                                                      bonito_pciconf_write, s);
> +    s->bonito_pciconf_start = BONITO_PCICONFIG_BASE;
> +    s->bonito_pciconf_length = BONITO_PCICONFIG_SIZE;
> +    cpu_register_physical_memory(s->bonito_pciconf_start, s->bonito_pciconf_length,
> +                                 s->bonito_pciconf_handle);
> +
> +    /* set the south bridge pci configure  mapping */
> +    s->bonito_spciconf_handle = cpu_register_io_memory(bonito_spciconf_read,
> +                                                       bonito_spciconf_write, s);
> +    s->bonito_spciconf_start = BONITO_SPCICONFIG_BASE;
> +    s->bonito_spciconf_length = BONITO_SPCICONFIG_SIZE;
> +    cpu_register_physical_memory(s->bonito_spciconf_start, s->bonito_spciconf_length,
> +                                 s->bonito_spciconf_handle);
> +
> +    /* add pci local io mapping */
> +    s->bonito_localio_handle = cpu_register_io_memory(bonito_localio_read,
> +                                                      bonito_localio_write, s);
> +    s->bonito_localio_start = BONITO_DEV_BASE;
> +    s->bonito_localio_length = BONITO_DEV_SIZE;
> +    cpu_register_physical_memory(s->bonito_localio_start, s->bonito_localio_length,
> +                                 s->bonito_localio_handle);
> +
> +    s->bonito_ldma_handle = cpu_register_io_memory(bonito_ldma_read,
> +                                                   bonito_ldma_write, s);
> +    s->bonito_ldma_start = 0xbfe00200;
> +    s->bonito_ldma_length = 0x100;
> +    cpu_register_physical_memory(s->bonito_ldma_start, s->bonito_ldma_length,
> +                                 s->bonito_ldma_handle);
> +
> +    s->bonito_cop_handle = cpu_register_io_memory(bonito_cop_read,
> +                                                  bonito_cop_write, s);
> +    s->bonito_cop_start = 0xbfe00300;
> +    s->bonito_cop_length = 0x100;
> +    cpu_register_physical_memory(s->bonito_cop_start, s->bonito_cop_length,
> +                                 s->bonito_cop_handle);
> +
> +    /* Map PCI IO Space  0x1fd0 0000 - 0x1fd1 0000 */
> +    s->bonito_pciio_start = BONITO_PCIIO_BASE;
> +    s->bonito_pciio_length = BONITO_PCIIO_SIZE;
> +    isa_mem_base = s->bonito_pciio_start;
> +    isa_mmio_init(s->bonito_pciio_start, s->bonito_pciio_length, 0);
> +
> +    qemu_register_reset(bonito_reset, s);
> +
> +    return 0;
> +}
> +
> +PCIBus *bonito_init(qemu_irq pic)
> +{
> +    DeviceState *dev;
> +    PCIBus *b;
> +    BonitoState *pcihost;
> +    PCIBonitoState *s;
> +    PCIDevice *d;
> +
> +    dev = qdev_create(NULL, "Bonito-pcihost");
> +    pcihost = FROM_SYSBUS(BonitoState, sysbus_from_qdev(dev));
> +    b = pci_register_bus(&pcihost->busdev.qdev, NULL, pci_bonito_set_irq,
> +                         pci_bonito_map_irq, pic, 0x28, 32);

This function takes a void *irq_opaque, not a qemu_irq.
bonito_init(qemu_irq) should probably changed in bonito_init(qemu_irq
*pic).

> +    pcihost->bus = b;
> +    qdev_init_nofail(dev);
> +    pci_bus_set_mem_base(pcihost->bus, 0x10000000);
> +
> +    d = pci_create_simple(b, 0, "Bonito");
> +    s = DO_UPCAST(PCIBonitoState, dev, d);
> +    s->pcihost = pcihost;
> +    bonito_state = s;
> +
> +    return b;
> +}
> +
> +static PCIDeviceInfo bonito_info = {
> +    .qdev.name    = "Bonito",
> +    .qdev.desc    = "Host bridge",
> +    .qdev.size    = sizeof(PCIBonitoState),
> +    .qdev.vmsd    = &vmstate_bonito,
> +    .qdev.no_user = 1,
> +    .init         = bonito_initfn,
> +};
> +
> +static SysBusDeviceInfo bonito_pcihost_info = {
> +    .init         = bonito_pcihost_initfn,
> +    .qdev.name    = "Bonito-pcihost",
> +    .qdev.size    = sizeof(BonitoState),
> +    .qdev.no_user = 1,
> +};
> +
> +static void bonito_register(void)
> +{
> +    sysbus_register_withprop(&bonito_pcihost_info);
> +    pci_qdev_register(&bonito_info);
> +}
> +device_init(bonito_register);
> diff --git a/hw/mips.h b/hw/mips.h
> index 30791a8..cd4fdf8 100644
> --- a/hw/mips.h
> +++ b/hw/mips.h
> @@ -5,6 +5,9 @@
>  /* gt64xxx.c */
>  PCIBus *pci_gt64120_init(qemu_irq *pic);
>  
> +/* bonito.c */
> +PCIBus *bonito_init(qemu_irq pic);
> +
>  /* ds1225y.c */
>  void *ds1225y_init(target_phys_addr_t mem_base, const char *filename);
>  void ds1225y_set_protection(void *opaque, int protection);
> -- 
> 1.7.0.4
> 
> 
>
chen huacai May 31, 2010, 2:29 p.m. UTC | #2
On Sat, May 29, 2010 at 4:31 AM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> Please find my comments below. Note that I don't feel very comfortable
> with PCI code, so a review from someone know this part of QEMU would be
> nice.
>
> On Wed, May 19, 2010 at 10:26:32PM +0800, Huacai Chen wrote:
>> Signed-off-by: Huacai Chen <zltjiangshi@gmail.com>
>> ---
>>  Makefile.target                      |    1 +
>>  default-configs/mips64el-softmmu.mak |    1 +
>>  hw/bonito.c                          |  950 ++++++++++++++++++++++++++++++++++
>>  hw/mips.h                            |    3 +
>>  4 files changed, 955 insertions(+), 0 deletions(-)
>>  create mode 100644 hw/bonito.c
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index a22484e..247a2eb 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -221,6 +221,7 @@ obj-mips-y += dma.o vga.o i8259.o
>>  obj-mips-y += g364fb.o jazz_led.o
>>  obj-mips-y += gt64xxx.o pckbd.o mc146818rtc.o
>>  obj-mips-y += piix4.o cirrus_vga.o
>> +obj-mips-$(CONFIG_FULONG) += bonito.o
>>
>>  obj-microblaze-y = petalogix_s3adsp1800_mmu.o
>>
>> diff --git a/default-configs/mips64el-softmmu.mak b/default-configs/mips64el-softmmu.mak
>> index 6fa54a3..b731c74 100644
>> --- a/default-configs/mips64el-softmmu.mak
>> +++ b/default-configs/mips64el-softmmu.mak
>> @@ -27,3 +27,4 @@ CONFIG_DP8393X=y
>>  CONFIG_DS1225Y=y
>>  CONFIG_MIPSNET=y
>>  CONFIG_PFLASH_CFI01=y
>> +CONFIG_FULONG=y
>> diff --git a/hw/bonito.c b/hw/bonito.c
>> new file mode 100644
>> index 0000000..246c12a
>> --- /dev/null
>> +++ b/hw/bonito.c
>> @@ -0,0 +1,950 @@
>> +/*
>> + * bonito north bridge support
>> + *
>> + * Copyright (c) 2008 yajin (yajin@vm-kernel.org)
>> + * Copyright (c) 2010 Huacai Chen (zltjiangshi@gmail.com)
>> + *
>> + * This code is licensed under the GNU GPL v2.
>> + */
>> +
>> +/*
>> + * fulong 2e mini pc has a bonito north bridge.
>> + */
>> +
>> +/* what is the meaning of devfn in qemu and IDSEL in bonito northbridge?
>> + *
>> + * devfn   pci_slot<<3  + funno
>> + * one pci bus can have 32 devices and each device can have 8 functions.
>> + *
>> + * In bonito north bridge, pci slot = IDSEL bit - 12.
>> + * For example, PCI_IDSEL_VIA686B = 17,
>> + * pci slot = 17-12=5
>> + *
>> + * so
>> + * VT686B_FUN0's devfn = (5<<3)+0
>> + * VT686B_FUN1's devfn = (5<<3)+1
>> + *
>> + * qemu also uses pci address for north bridge to access pci config register.
>> + * bus_no   [23:16]
>> + * dev_no   [15:11]
>> + * fun_no   [10:8]
>> + * reg_no   [7:2]
>> + *
>> + * so function bonito_sbridge_pciaddr for the translation from
>> + * north bridge address to pci address.
>> + */
>> +
>> +#include <assert.h>
>> +
>> +#include "hw.h"
>> +#include "pci.h"
>> +#include "pc.h"
>> +#include "mips.h"
>> +
>> +typedef target_phys_addr_t pci_addr_t;
>> +#include "pci_host.h"
>> +
>> +//#define DEBUG_BONITO
>> +
>> +#ifdef DEBUG_BONITO
>> +#define DPRINTF(fmt, ...) fprintf(stderr, "%s: " fmt, __FUNCTION__, ##__VA_ARGS__)
>> +#else
>> +#define DPRINTF(fmt, ...)
>> +#endif
>> +
>> +/* from linux soure code. include/asm-mips/mips-boards/bonito64.h*/
>> +#define BONITO_BOOT_BASE        0x1fc00000
>> +#define BONITO_BOOT_SIZE        0x00100000
>> +#define BONITO_BOOT_TOP         (BONITO_BOOT_BASE+BONITO_BOOT_SIZE-1)
>> +#define BONITO_FLASH_BASE       0x1c000000
>> +#define BONITO_FLASH_SIZE       0x03000000
>> +#define BONITO_FLASH_TOP        (BONITO_FLASH_BASE+BONITO_FLASH_SIZE-1)
>> +#define BONITO_SOCKET_BASE      0x1f800000
>> +#define BONITO_SOCKET_SIZE      0x00400000
>> +#define BONITO_SOCKET_TOP       (BONITO_SOCKET_BASE+BONITO_SOCKET_SIZE-1)
>> +#define BONITO_REG_BASE         0x1fe00000
>> +#define BONITO_REG_SIZE         0x00040000
>> +#define BONITO_REG_TOP          (BONITO_REG_BASE+BONITO_REG_SIZE-1)
>> +#define BONITO_DEV_BASE         0x1ff00000
>> +#define BONITO_DEV_SIZE         0x00100000
>> +#define BONITO_DEV_TOP          (BONITO_DEV_BASE+BONITO_DEV_SIZE-1)
>> +#define BONITO_PCILO_BASE       0x10000000
>> +#define BONITO_PCILO_BASE_VA    0xb0000000
>> +#define BONITO_PCILO_SIZE       0x0c000000
>> +#define BONITO_PCILO_TOP        (BONITO_PCILO_BASE+BONITO_PCILO_SIZE-1)
>> +#define BONITO_PCILO0_BASE      0x10000000
>> +#define BONITO_PCILO1_BASE      0x14000000
>> +#define BONITO_PCILO2_BASE      0x18000000
>> +#define BONITO_PCIHI_BASE       0x20000000
>> +#define BONITO_PCIHI_SIZE       0x20000000
>> +#define BONITO_PCIHI_TOP        (BONITO_PCIHI_BASE+BONITO_PCIHI_SIZE-1)
>> +#define BONITO_PCIIO_BASE       0x1fd00000
>> +#define BONITO_PCIIO_BASE_VA    0xbfd00000
>> +#define BONITO_PCIIO_SIZE       0x00010000
>> +#define BONITO_PCIIO_TOP        (BONITO_PCIIO_BASE+BONITO_PCIIO_SIZE-1)
>> +#define BONITO_PCICFG_BASE      0x1fe80000
>> +#define BONITO_PCICFG_SIZE      0x00080000
>> +#define BONITO_PCICFG_TOP       (BONITO_PCICFG_BASE+BONITO_PCICFG_SIZE-1)
>> +
>> +
>> +#define BONITO_PCICONFIGBASE    0x00
>> +#define BONITO_REGBASE          0x100
>> +
>> +#define BONITO_PCICONFIG_BASE   (BONITO_PCICONFIGBASE+BONITO_REG_BASE)
>> +#define BONITO_PCICONFIG_SIZE   (0x100)
>> +
>> +#define BONITO_INTERNAL_REG_BASE  (BONITO_REGBASE+BONITO_REG_BASE)
>> +#define BONITO_INTERNAL_REG_SIZE  (0x70)
>> +
>> +#define BONITO_SPCICONFIG_BASE  (BONITO_PCICFG_BASE)
>> +#define BONITO_SPCICONFIG_SIZE  (BONITO_PCICFG_SIZE)
>> +
>> +
>> +
>> +/* 1. Bonito h/w Configuration */
>> +/* Power on register */
>> +
>> +#define BONITO_BONPONCFG        (0x00 >> 2)      /* 0x100 */
>> +#define BONITO_BONGENCFG_OFFSET 0x4
>> +#define BONITO_BONGENCFG        (BONITO_BONGENCFG_OFFSET>>2)   /*0x104 */
>> +
>> +/* 2. IO & IDE configuration */
>> +#define BONITO_IODEVCFG         (0x08 >> 2)      /* 0x108 */
>> +
>> +/* 3. IO & IDE configuration */
>> +#define BONITO_SDCFG            (0x0c >> 2)      /* 0x10c */
>> +
>> +/* 4. PCI address map control */
>> +#define BONITO_PCIMAP           (0x10 >> 2)      /* 0x110 */
>> +#define BONITO_PCIMEMBASECFG    (0x14 >> 2)      /* 0x114 */
>> +#define BONITO_PCIMAP_CFG       (0x18 >> 2)      /* 0x118 */
>> +
>> +/* 5. ICU & GPIO regs */
>> +/* GPIO Regs - r/w */
>> +#define BONITO_GPIODATA_OFFSET  0x1c
>> +#define BONITO_GPIODATA         (BONITO_GPIODATA_OFFSET >> 2)   /* 0x11c */
>> +#define BONITO_GPIOIE           (0x20 >> 2)      /* 0x120 */
>> +
>> +/* ICU Configuration Regs - r/w */
>> +#define BONITO_INTEDGE          (0x24 >> 2)      /* 0x124 */
>> +#define BONITO_INTSTEER         (0x28 >> 2)      /* 0x128 */
>> +#define BONITO_INTPOL           (0x2c >> 2)      /* 0x12c */
>> +
>> +/* ICU Enable Regs - IntEn & IntISR are r/o. */
>> +#define BONITO_INTENSET         (0x30 >> 2)      /* 0x130 */
>> +#define BONITO_INTENCLR         (0x34 >> 2)      /* 0x134 */
>> +#define BONITO_INTEN            (0x38 >> 2)      /* 0x138 */
>> +#define BONITO_INTISR           (0x3c >> 2)      /* 0x13c */
>> +
>> +/* PCI mail boxes */
>> +#define BONITO_PCIMAIL0_OFFSET    0x40
>> +#define BONITO_PCIMAIL1_OFFSET    0x44
>> +#define BONITO_PCIMAIL2_OFFSET    0x48
>> +#define BONITO_PCIMAIL3_OFFSET    0x4c
>> +#define BONITO_PCIMAIL0         (0x40 >> 2)      /* 0x140 */
>> +#define BONITO_PCIMAIL1         (0x44 >> 2)      /* 0x144 */
>> +#define BONITO_PCIMAIL2         (0x48 >> 2)      /* 0x148 */
>> +#define BONITO_PCIMAIL3         (0x4c >> 2)      /* 0x14c */
>> +
>> +/* 6. PCI cache */
>> +#define BONITO_PCICACHECTRL     (0x50 >> 2)      /* 0x150 */
>> +#define BONITO_PCICACHETAG      (0x54 >> 2)      /* 0x154 */
>> +#define BONITO_PCIBADADDR       (0x58 >> 2)      /* 0x158 */
>> +#define BONITO_PCIMSTAT         (0x5c >> 2)      /* 0x15c */
>> +
>> +/* 7. other*/
>> +#define BONITO_TIMECFG          (0x60 >> 2)      /* 0x160 */
>> +#define BONITO_CPUCFG           (0x64 >> 2)      /* 0x164 */
>> +#define BONITO_DQCFG            (0x68 >> 2)      /* 0x168 */
>> +#define BONITO_MEMSIZE          (0x6C >> 2)      /* 0x16c */
>> +
>> +#define BONITO_REGS             (0x70 >> 2)
>> +
>> +/* PCI config for south bridge. type 0 */
>> +#define BONITO_PCICONF_IDSEL_MASK      0xfffff800     /* [31:11] */
>> +#define BONITO_PCICONF_IDSEL_OFFSET    11
>> +#define BONITO_PCICONF_FUN_MASK        0x700    /* [10:8] */
>> +#define BONITO_PCICONF_FUN_OFFSET      8
>> +#define BONITO_PCICONF_REG_MASK        0xFC
>> +#define BONITO_PCICONF_REG_OFFSET      0
>> +
>> +
>> +/* idsel BIT = pci slot number +12 */
>> +#define PCI_SLOT_BASE              12
>> +#define PCI_IDSEL_VIA686B_BIT      (17)
>> +#define PCI_IDSEL_VIA686B          (1<<PCI_IDSEL_VIA686B_BIT)
>> +
>> +#define PCI_ADDR(busno,devno,funno,regno)  \
>> +    ((((busno)<<16)&0xff0000) + (((devno)<<11)&0xf800) + (((funno)<<8)&0x700) + (regno))
>> +
>> +typedef PCIHostState BonitoState;
>> +
>> +typedef struct PCIBonitoState
>> +{
>> +    PCIDevice dev;
>> +    BonitoState *pcihost;
>> +    uint32_t regs[BONITO_REGS];
>> +
>> +    struct bonldma {
>> +        uint32_t ldmactrl;
>> +        uint32_t ldmastat;
>> +        uint32_t ldmaaddr;
>> +        uint32_t ldmago;
>> +    } bonldma;
>> +
>> +    /* Based at 1fe00300, bonito Copier */
>> +    struct boncop {
>> +        uint32_t copctrl;
>> +        uint32_t copstat;
>> +        uint32_t coppaddr;
>> +        uint32_t copgo;
>> +    } boncop;
>> +
>> +    /* north brige pci config */
>> +    uint8_t config[256];
>
> Why not using the config field from PCIDevice ?
>
>> +
>> +    /* Bonito registers */
>> +    target_phys_addr_t bonito_reg_start;
>> +    target_phys_addr_t bonito_reg_length;
>> +    int bonito_reg_handle;
>> +
>> +    target_phys_addr_t bonito_pciconf_start;
>> +    target_phys_addr_t bonito_pciconf_length;
>> +    int bonito_pciconf_handle;
>> +
>> +    target_phys_addr_t bonito_spciconf_start;
>> +    target_phys_addr_t bonito_spciconf_length;
>> +    int bonito_spciconf_handle;
>> +
>> +    target_phys_addr_t bonito_pciio_start;
>> +    target_phys_addr_t bonito_pciio_length;
>> +    int bonito_pciio_handle;
>> +
>> +    target_phys_addr_t bonito_localio_start;
>> +    target_phys_addr_t bonito_localio_length;
>> +    int bonito_localio_handle;
>> +
>> +    target_phys_addr_t bonito_ldma_start;
>> +    target_phys_addr_t bonito_ldma_length;
>> +    int bonito_ldma_handle;
>> +
>> +    target_phys_addr_t bonito_cop_start;
>> +    target_phys_addr_t bonito_cop_length;
>> +    int bonito_cop_handle;
>> +
>> +} PCIBonitoState;
>> +
>> +PCIBonitoState * bonito_state;
>> +
>> +static void bonito_writeb(void *opaque, target_phys_addr_t addr, uint32_t val)
>> +{
>> +    DPRINTF("bonito_writeb "TARGET_FMT_plx" val %x  \n", addr, val);
>> +}
>> +
>> +static void bonito_writew(void *opaque, target_phys_addr_t addr, uint32_t val)
>> +{
>> +    DPRINTF("bonito_writew "TARGET_FMT_plx" val %x  \n", addr, val);
>> +}
>
> Are byte and word access supported on this chipset? If not, it would be
> better to declare the two first entries of CPUWriteMemoryFunc as NULL.
>
>> +static void bonito_writel(void *opaque, target_phys_addr_t addr, uint32_t val)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +    uint32_t saddr;
>> +    int reset = 0;
>> +
>> +    saddr = (addr - 0x100) >> 2;
>
> Where this 0x100 comes from?
>
>> +
>> +    DPRINTF("bonito_writel "TARGET_FMT_plx" val %x saddr %x \n", addr, val, saddr);
>> +    switch (saddr) {
>> +    case BONITO_BONPONCFG:
>> +    case BONITO_IODEVCFG:
>> +    case BONITO_SDCFG:
>> +    case BONITO_PCIMAP:
>> +    case BONITO_PCIMEMBASECFG:
>> +    case BONITO_PCIMAP_CFG:
>> +    case BONITO_GPIODATA:
>> +    case BONITO_GPIOIE:
>> +    case BONITO_INTEDGE:
>> +    case BONITO_INTSTEER:
>> +    case BONITO_INTPOL:
>> +    case BONITO_PCIMAIL0:
>> +    case BONITO_PCIMAIL1:
>> +    case BONITO_PCIMAIL2:
>> +    case BONITO_PCIMAIL3:
>> +    case BONITO_PCICACHECTRL:
>> +    case BONITO_PCICACHETAG:
>> +    case BONITO_PCIBADADDR:
>> +    case BONITO_PCIMSTAT:
>> +    case BONITO_TIMECFG:
>> +    case BONITO_CPUCFG:
>> +    case BONITO_DQCFG:
>> +    case BONITO_MEMSIZE:
>> +        s->regs[saddr] = val;
>> +        break;
>> +    case BONITO_BONGENCFG:
>> +        if (!(s->regs[saddr] & 0x04) && (val & 0x04)) {
>> +            reset = 1; /* bit 2 jump from 0 to 1 cause reset */
>> +        }
>> +        s->regs[saddr] = val;
>> +        if (reset) {
>> +            qemu_system_reset_request();
>> +        }
>> +        break;
>> +    case BONITO_INTENSET:
>> +        s->regs[BONITO_INTENSET] = val;
>> +        s->regs[BONITO_INTEN] |= val;
>> +        break;
>> +    case BONITO_INTENCLR:
>> +        s->regs[BONITO_INTENCLR] = val;
>> +        s->regs[BONITO_INTEN] &= ~val;
>> +        break;
>> +    case BONITO_INTEN:
>> +    case BONITO_INTISR:
>> +    DPRINTF("write to readonly bonito register %x \n", saddr);
>
> indentation issue
>
>> +        break;
>> +    default:
>> +    DPRINTF("write to unknown bonito register %x \n", saddr);
>
> indentation issue
>
>> +        break;
>> +    }
>> +}
>> +
>> +static uint32_t bonito_readb(void *opaque, target_phys_addr_t addr)
>> +{
>> +    DPRINTF("bonito_readb "TARGET_FMT_plx"  \n", addr);
>> +    return 0;
>> +}
>> +
>> +static uint32_t bonito_readw(void *opaque, target_phys_addr_t addr)
>> +{
>> +    DPRINTF("bonito_readw "TARGET_FMT_plx"  \n", addr);
>> +    return 0;
>> +}
>
> Same as for write.
>
>> +static uint32_t bonito_readl(void *opaque, target_phys_addr_t addr)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +    uint32_t saddr;
>> +
>> +    saddr = (addr - 0x100) >> 2;
>> +
>> +    DPRINTF("bonito_readl "TARGET_FMT_plx"  \n", addr);
>> +    switch (saddr) {
>> +    case BONITO_INTISR:
>> +        return s->regs[saddr];
>> +    default:
>> +        return s->regs[saddr];
>> +    }
>> +}
>> +
>> +static CPUWriteMemoryFunc * const bonito_write[] = {
>> +    bonito_writeb,
>> +    bonito_writew,
>> +    bonito_writel,
>> +};
>> +
>> +static CPUReadMemoryFunc * const bonito_read[] = {
>> +    bonito_readb,
>> +    bonito_readw,
>> +    bonito_readl,
>> +};
>> +
>> +static void bonito_pciconf_writeb(void *opaque, target_phys_addr_t addr,
>> +                                  uint32_t val)
>> +{
>> +    DPRINTF("bonito_pciconf_writeb "TARGET_FMT_plx" val %x \n", addr, val);
>> +}
>> +
>> +static void bonito_pciconf_writew(void *opaque, target_phys_addr_t addr,
>> +                                  uint32_t val)
>> +{
>> +    DPRINTF("bonito_pciconf_writew "TARGET_FMT_plx" val %x \n", addr, val);
>> +}
>
> Same as previously.
>
>> +static void bonito_pciconf_writel(void *opaque, target_phys_addr_t addr,
>> +                                  uint32_t val)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +    uint32_t saddr;
>> +    uint32_t *ptr = (uint32_t *) s->config;
>> +
>> +    saddr = (addr) >> 2;
>> +    DPRINTF("bonito_pciconf_writel "TARGET_FMT_plx" val %x \n", addr, val);
>> +    ptr += saddr;
>> +    *ptr = val;
>> +}
>> +
>> +static uint32_t bonito_pciconf_readb(void *opaque, target_phys_addr_t addr)
>> +{
>> +    DPRINTF("bonito_pciconf_readb "TARGET_FMT_plx"\n", addr);
>> +    return 0;
>> +}
>> +static uint32_t bonito_pciconf_readw(void *opaque, target_phys_addr_t addr)
>> +{
>> +    DPRINTF("bonito_pciconf_readw "TARGET_FMT_plx"\n", addr);
>> +    return 0;
>> +}
>> +
>> +static uint32_t bonito_pciconf_readl(void *opaque, target_phys_addr_t addr)
>> +{
>> +
>> +    PCIBonitoState *s = opaque;
>> +    uint32_t saddr;
>> +    uint32_t *ptr = (uint32_t *) s->config;
>> +
>> +    saddr = (addr) >> 2;
>> +    DPRINTF("bonito_pciconf_readl "TARGET_FMT_plx"\n", addr);
>> +    ptr += saddr;
>> +
>> +    return (*ptr);
>> +}
>> +
>> +/* north bridge PCI configure space. 0x1fe0 0000 - 0x1fe0 00ff */
>> +static CPUWriteMemoryFunc * const bonito_pciconf_write[] = {
>> +    bonito_pciconf_writeb,
>> +    bonito_pciconf_writew,
>> +    bonito_pciconf_writel,
>> +};
>> +
>> +static CPUReadMemoryFunc * const bonito_pciconf_read[] = {
>> +    bonito_pciconf_readb,
>> +    bonito_pciconf_readw,
>> +    bonito_pciconf_readl,
>> +};
>> +
>> +static uint32_t bonito_localio_readb(void *opaque, target_phys_addr_t addr)
>> +{
>> +    uint32_t val;
>> +
>> +    DPRINTF("bonito_localio_readb "TARGET_FMT_plx"\n", addr);
>> +    val = cpu_inb(addr & 0xffff);
>> +    return val;
>> +}
>
> This function and the related ones below should probably use isa_mmio
> instead.
>
>> +static uint32_t bonito_localio_readw(void *opaque, target_phys_addr_t addr)
>> +{
>> +    uint32_t val;
>> +
>> +    DPRINTF("bonito_localio_readw "TARGET_FMT_plx"\n", addr);
>> +    val = cpu_inw(addr & 0xffff);
>> +#ifdef TARGET_WORDS_BIGENDIAN
>> +    val = bswap16(val);
>> +#endif
>> +    return val;
>> +}
>> +
>> +static uint32_t bonito_localio_readl(void *opaque, target_phys_addr_t addr)
>> +{
>> +    uint32_t val;
>> +
>> +    DPRINTF("bonito_localio_readl "TARGET_FMT_plx"\n", addr);
>> +    val = cpu_inl(addr & 0xffff);
>> +#ifdef TARGET_WORDS_BIGENDIAN
>> +    val = bswap32(val);
>> +#endif
>> +    return val;
>> +}
>> +
>> +static void bonito_localio_writeb(void *opaque, target_phys_addr_t addr,
>> +                                  uint32_t val)
>> +{
>> +    DPRINTF("bonito_localio_writeb "TARGET_FMT_plx"\n", addr);
>> +    cpu_outb(addr & 0xffff, val);
>> +}
>> +
>> +static void bonito_localio_writew(void *opaque, target_phys_addr_t addr,
>> +                                  uint32_t val)
>> +{
>> +    DPRINTF("bonito_localio_writew "TARGET_FMT_plx"\n", addr);
>> +#ifdef TARGET_WORDS_BIGENDIAN
>> +    val = bswap16(val);
>> +#endif
>> +    cpu_outw(addr & 0xffff, val);
>> +}
>> +
>> +static void bonito_localio_writel(void *opaque, target_phys_addr_t addr,
>> +                                  uint32_t val)
>> +{
>> +    DPRINTF("bonito_localio_writel "TARGET_FMT_plx"\n", addr);
>> +#ifdef TARGET_WORDS_BIGENDIAN
>> +    val = bswap32(val);
>> +#endif
>> +    cpu_outl(addr & 0xffff, val);
>> +}
>> +
>> +static CPUReadMemoryFunc * const bonito_localio_read[] = {
>> +    bonito_localio_readb,
>> +    bonito_localio_readw,
>> +    bonito_localio_readl,
>> +};
>> +
>> +static CPUWriteMemoryFunc * const bonito_localio_write[] = {
>> +    bonito_localio_writeb,
>> +    bonito_localio_writew,
>> +    bonito_localio_writel,
>> +};
>> +
>> +static uint32_t bonito_ldma_readl(void *opaque, target_phys_addr_t addr)
>> +{
>> +    uint32_t val;
>> +    PCIBonitoState *s = opaque;
>> +
>> +    val = ((uint32_t *)(&s->bonldma))[addr/sizeof(uint32_t)];
>> +
>> +    return val;
>> +}
>> +
>> +static void bonito_ldma_writel(void *opaque, target_phys_addr_t addr,
>> +                               uint32_t val)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +
>> +    ((uint32_t *)(&s->bonldma))[addr/sizeof(uint32_t)] = val & 0xffffffff;
>> +}
>> +
>> +static CPUWriteMemoryFunc * const bonito_ldma_write[] = {
>> +    bonito_ldma_writel,
>> +    bonito_ldma_writel,
>> +    bonito_ldma_writel,
>> +};
>> +
>> +static CPUReadMemoryFunc * const bonito_ldma_read[] = {
>> +    bonito_ldma_readl,
>> +    bonito_ldma_readl,
>> +    bonito_ldma_readl,
>> +};
>> +
>> +static uint32_t bonito_cop_readl(void *opaque, target_phys_addr_t addr)
>> +{
>> +    uint32_t val;
>> +    PCIBonitoState *s = opaque;
>> +
>> +    val = ((uint32_t *)(&s->boncop))[addr/sizeof(uint32_t)];
>> +
>> +    return val;
>> +}
>> +
>> +static void bonito_cop_writel(void *opaque, target_phys_addr_t addr,
>> +                              uint32_t val)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +
>> +    ((uint32_t *)(&s->boncop))[addr/sizeof(uint32_t)] = val & 0xffffffff;
>> +}
>> +
>> +static CPUWriteMemoryFunc * const bonito_cop_write[] = {
>> +    bonito_cop_writel,
>> +    bonito_cop_writel,
>> +    bonito_cop_writel,
>> +};
>> +
>> +static CPUReadMemoryFunc * const bonito_cop_read[] = {
>> +    bonito_cop_readl,
>> +    bonito_cop_readl,
>> +    bonito_cop_readl,
>> +};
>> +
>> +static uint32_t bonito_sbridge_pciaddr(void *opaque, target_phys_addr_t addr)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +    uint32_t cfgaddr;
>> +    uint32_t idsel;
>> +    uint32_t devno;
>> +    uint32_t funno;
>> +    uint32_t regno;
>> +    uint32_t pciaddr;
>> +
>> +    /* support type0 pci config */
>> +    if ((s->regs[BONITO_PCIMAP_CFG] & 0x10000) != 0x0) {
>> +        return 0xffffffff;
>> +    }
>> +
>> +    cfgaddr = addr & 0xffff;
>> +    cfgaddr |= (s->regs[BONITO_PCIMAP_CFG] & 0xffff) << 16;
>> +
>> +    idsel = (cfgaddr & BONITO_PCICONF_IDSEL_MASK) >> BONITO_PCICONF_IDSEL_OFFSET;
>> +    devno = ffs(idsel) - 1;
>> +    funno = (cfgaddr & BONITO_PCICONF_FUN_MASK) >> BONITO_PCICONF_FUN_OFFSET;
>> +    regno = (cfgaddr & BONITO_PCICONF_REG_MASK) >> BONITO_PCICONF_REG_OFFSET;
>> +
>> +    if (idsel == 0) {
>> +        fprintf(stderr, "error in bonito pci config address" TARGET_FMT_plx
>> +            ",pcimap_cfg=%x\n", addr, s->regs[BONITO_PCIMAP_CFG]);
>> +        exit(1);
>> +    }
>> +    pciaddr = PCI_ADDR(pci_bus_num(s->pcihost->bus), devno, funno, regno);
>> +    DPRINTF("cfgaddr %x pciaddr %x busno %x devno %d funno %d regno %d \n",
>> +        cfgaddr, pciaddr, pci_bus_num(s->pcihost->bus), devno, funno, regno);
>> +
>> +    return pciaddr;
>> +}
>> +
>> +static void bonito_spciconf_writeb(void *opaque, target_phys_addr_t addr,
>> +                                   uint32_t val)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +    uint32_t pciaddr;
>> +    uint16_t status;
>> +
>> +    DPRINTF("bonito_spciconf_writeb "TARGET_FMT_plx" val %x \n", addr, val);
>> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
>> +
>> +    if (pciaddr == 0xffffffff) {
>> +        return;
>> +    }
>> +
>> +    /* set the pci address in s->config_reg */
>> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
>> +    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val & 0xff, 1);
>> +
>> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
>> +    status = pci_get_word(s->config + PCI_STATUS);
>> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
>> +    pci_set_word(s->config + PCI_STATUS, status);
>> +}
>> +
>> +static void bonito_spciconf_writew(void *opaque, target_phys_addr_t addr,
>> +                                   uint32_t val)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +    uint32_t pciaddr;
>> +    uint16_t status;
>> +
>> +    DPRINTF("bonito_spciconf_writew "TARGET_FMT_plx" val %x \n", addr, val);
>> +    assert((addr&0x1)==0);
>> +
>> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
>> +
>> +    if (pciaddr == 0xffffffff) {
>> +        return;
>> +    }
>> +
>> +    /* set the pci address in s->config_reg */
>> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
>> +    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val, 2);
>> +
>> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
>> +    status = pci_get_word(s->config + PCI_STATUS);
>> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
>> +    pci_set_word(s->config + PCI_STATUS, status);
>> +}
>> +
>> +static void bonito_spciconf_writel(void *opaque, target_phys_addr_t addr,
>> +                                   uint32_t val)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +    uint32_t pciaddr;
>> +    uint16_t status;
>> +
>> +    DPRINTF("bonito_spciconf_writel "TARGET_FMT_plx" val %x \n", addr, val);
>> +    assert((addr&0x3)==0);
>> +
>> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
>> +
>> +    if (pciaddr == 0xffffffff) {
>> +        return;
>> +    }
>> +
>> +    /* set the pci address in s->config_reg */
>> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
>> +    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val, 4);
>> +
>> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
>> +    status = pci_get_word(s->config + PCI_STATUS);
>> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
>> +    pci_set_word(s->config + PCI_STATUS, status);
>> +}
>> +
>> +static uint32_t bonito_spciconf_readb(void *opaque, target_phys_addr_t addr)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +    uint32_t pciaddr;
>> +    uint16_t status;
>> +
>> +    DPRINTF("bonito_spciconf_readb "TARGET_FMT_plx"  \n", addr);
>> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
>> +
>> +    if (pciaddr == 0xffffffff) {
>> +        return 0xff;
>> +    }
>> +
>> +    /* set the pci address in s->config_reg */
>> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
>> +
>> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
>> +    status = pci_get_word(s->config + PCI_STATUS);
>> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
>> +    pci_set_word(s->config + PCI_STATUS, status);
>> +
>> +    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 1);
>> +}
>> +
>> +static uint32_t bonito_spciconf_readw(void *opaque, target_phys_addr_t addr)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +    uint32_t pciaddr;
>> +    uint16_t status;
>> +
>> +    DPRINTF("bonito_spciconf_readw "TARGET_FMT_plx"  \n", addr);
>> +    assert((addr&0x1)==0);
>> +
>> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
>> +
>> +    if (pciaddr == 0xffffffff) {
>> +        return 0xffff;
>> +    }
>> +
>> +    /* set the pci address in s->config_reg */
>> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
>> +
>> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
>> +    status = pci_get_word(s->config + PCI_STATUS);
>> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
>> +    pci_set_word(s->config + PCI_STATUS, status);
>> +
>> +    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 2);
>> +}
>> +
>> +static uint32_t bonito_spciconf_readl(void *opaque, target_phys_addr_t addr)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +    uint32_t pciaddr;
>> +    uint16_t status;
>> +
>> +    DPRINTF("bonito_spciconf_readl "TARGET_FMT_plx"  \n", addr);
>> +    assert((addr&0x3) == 0);
>> +
>> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
>> +
>> +    if (pciaddr == 0xffffffff) {
>> +        return 0xffffffff;
>> +    }
>> +
>> +    /* set the pci address in s->config_reg */
>> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
>> +
>> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
>> +    status = pci_get_word(s->config + PCI_STATUS);
>> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
>> +    pci_set_word(s->config + PCI_STATUS, status);
>> +
>> +    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 4);
>> +}
>> +
>> +/* south bridge PCI configure space. 0x1fe8 0000 - 0x1fef ffff */
>> +static CPUWriteMemoryFunc * const bonito_spciconf_write[] = {
>> +    bonito_spciconf_writeb,
>> +    bonito_spciconf_writew,
>> +    bonito_spciconf_writel,
>> +};
>> +
>> +static CPUReadMemoryFunc * const bonito_spciconf_read[] = {
>> +    bonito_spciconf_readb,
>> +    bonito_spciconf_readw,
>> +    bonito_spciconf_readl,
>> +};
>> +
>> +#define BONITO_IRQ_BASE 32
>> +
>> +static void pci_bonito_set_irq(void *opaque, int irq_num, int level)
>> +{
>> +    qemu_irq pic = opaque;
>> +    int internal_irq = irq_num - BONITO_IRQ_BASE;
>> +
>> +    if (bonito_state->regs[BONITO_INTEDGE] & (1<<internal_irq)) {
>> +        qemu_irq_pulse(pic);
>> +    } else {   /* level triggered */
>> +        if (bonito_state->regs[BONITO_INTPOL] & (1<<internal_irq)) {
>> +            qemu_irq_raise(pic);
>> +        } else {
>> +            qemu_irq_lower(pic);
>> +        }
>> +    }
>> +}
>> +
>> +/* map the original irq (0~3) to bonito irq (16~47, but 16~31 are unused) */
>> +static int pci_bonito_map_irq(PCIDevice * pci_dev, int irq_num)
>> +{
>> +    int slot;
>> +
>> +    slot = (pci_dev->devfn >> 3);
>> +
>> +    switch (slot) {
>> +    case 5:   /* FULONG2E_VIA_SLOT, SouthBridge, IDE, USB, ACPI, AC97, MC97 */
>> +        return irq_num % 4 + BONITO_IRQ_BASE;
>> +    case 6:   /* FULONG2E_ATI_SLOT, VGA */
>> +        return 4 + BONITO_IRQ_BASE;
>> +    case 7:   /* FULONG2E_RTL_SLOT, RTL8139 */
>> +        return 5 + BONITO_IRQ_BASE;
>> +    case 8 ... 12: /* PCI slot 1 to 4 */
>> +        return (slot - 8 + irq_num) + 6 + BONITO_IRQ_BASE;
>> +    default:  /* Unknown device, don't do any translation */
>> +        return irq_num;
>> +    }
>> +}
>> +
>> +static void bonito_reset(void *opaque)
>> +{
>> +    PCIBonitoState *s = opaque;
>> +
>> +    /* set the default value of north bridge pci config */
>> +    s->config[0x04] = 0x00;
>> +    s->config[0x05] = 0x00;
>> +    s->config[0x06] = 0x00;
>> +    s->config[0x07] = 0x00;
>> +
>> +    s->config[0x08] = 0x01;
>> +    s->config[0x09] = 0x00;
>> +    s->config[0x0a] = 0x00;
>> +    s->config[0x0b] = 0x06;
>> +
>> +    s->config[0x2c] = 0x00;
>> +    s->config[0x2d] = 0x00;
>> +    s->config[0x2e] = 0x00;
>> +    s->config[0x2f] = 0x00;
>> +
>> +    s->config[0x3c] = 0x00;
>> +    s->config[0x3d] = 0x01;
>> +    s->config[0x3e] = 0x3c;
>> +    s->config[0x3f] = 0x00;
>> +
>> +    /* set the default value of north bridge registers */
>> +
>> +    s->regs[BONITO_BONPONCFG] = 0xc40;
>> +    s->regs[BONITO_BONGENCFG] = 0x1384;
>
> Is it the correct reset value? I am surprised the reset bit (0x04) is
> enabled.
>
This is correct, the reset signal only triggered when reset_bit jump
from 0 to 1, it is edge triggered rather than level triggered.

>> +    s->regs[BONITO_IODEVCFG] = 0x2bff8010;
>> +    s->regs[BONITO_SDCFG] = 0x255e0091;
>> +
>> +    s->regs[BONITO_GPIODATA] = 0x1ff;
>> +    s->regs[BONITO_GPIOIE] = 0x1ff;
>> +    s->regs[BONITO_DQCFG] = 0x8;
>> +    s->regs[BONITO_MEMSIZE] = 0x10000000;
>> +    s->regs[BONITO_PCIMAP] = 0x6140;
>> +}
>> +
>> +static const VMStateDescription vmstate_bonito = {
>> +    .name = "Bonito",
>> +    .version_id = 1,
>> +    .minimum_version_id = 1,
>> +    .minimum_version_id_old = 1,
>> +    .fields      = (VMStateField []) {
>> +        VMSTATE_PCI_DEVICE(dev, PCIBonitoState),
>> +        VMSTATE_END_OF_LIST()
>> +    }
>> +};
>> +
>> +static int bonito_pcihost_initfn(SysBusDevice *dev)
>> +{
>> +    return 0;
>> +}
>> +
>> +static int bonito_initfn(PCIDevice *dev)
>> +{
>> +    PCIBonitoState *s = DO_UPCAST(PCIBonitoState, dev, dev);
>> +
>> +    /* Bonito North Bridge, built on FPGA, VENDOR_ID/DEVICE_ID are "undefined" */
>> +    pci_config_set_vendor_id(dev->config, 0xdf53);
>> +    pci_config_set_device_id(dev->config, 0x00d5);
>> +    pci_config_set_class(dev->config, PCI_CLASS_BRIDGE_HOST);
>> +
>> +    /* set the north bridge register mapping */
>> +    s->bonito_reg_handle = cpu_register_io_memory(bonito_read, bonito_write, s);
>> +    s->bonito_reg_start = BONITO_INTERNAL_REG_BASE;
>> +    s->bonito_reg_length = BONITO_INTERNAL_REG_SIZE;
>> +    cpu_register_physical_memory(s->bonito_reg_start, s->bonito_reg_length,
>> +                                 s->bonito_reg_handle);
>> +
>> +    /* set the north bridge pci configure  mapping */
>> +    s->bonito_pciconf_handle = cpu_register_io_memory(bonito_pciconf_read,
>> +                                                      bonito_pciconf_write, s);
>> +    s->bonito_pciconf_start = BONITO_PCICONFIG_BASE;
>> +    s->bonito_pciconf_length = BONITO_PCICONFIG_SIZE;
>> +    cpu_register_physical_memory(s->bonito_pciconf_start, s->bonito_pciconf_length,
>> +                                 s->bonito_pciconf_handle);
>> +
>> +    /* set the south bridge pci configure  mapping */
>> +    s->bonito_spciconf_handle = cpu_register_io_memory(bonito_spciconf_read,
>> +                                                       bonito_spciconf_write, s);
>> +    s->bonito_spciconf_start = BONITO_SPCICONFIG_BASE;
>> +    s->bonito_spciconf_length = BONITO_SPCICONFIG_SIZE;
>> +    cpu_register_physical_memory(s->bonito_spciconf_start, s->bonito_spciconf_length,
>> +                                 s->bonito_spciconf_handle);
>> +
>> +    /* add pci local io mapping */
>> +    s->bonito_localio_handle = cpu_register_io_memory(bonito_localio_read,
>> +                                                      bonito_localio_write, s);
>> +    s->bonito_localio_start = BONITO_DEV_BASE;
>> +    s->bonito_localio_length = BONITO_DEV_SIZE;
>> +    cpu_register_physical_memory(s->bonito_localio_start, s->bonito_localio_length,
>> +                                 s->bonito_localio_handle);
>> +
>> +    s->bonito_ldma_handle = cpu_register_io_memory(bonito_ldma_read,
>> +                                                   bonito_ldma_write, s);
>> +    s->bonito_ldma_start = 0xbfe00200;
>> +    s->bonito_ldma_length = 0x100;
>> +    cpu_register_physical_memory(s->bonito_ldma_start, s->bonito_ldma_length,
>> +                                 s->bonito_ldma_handle);
>> +
>> +    s->bonito_cop_handle = cpu_register_io_memory(bonito_cop_read,
>> +                                                  bonito_cop_write, s);
>> +    s->bonito_cop_start = 0xbfe00300;
>> +    s->bonito_cop_length = 0x100;
>> +    cpu_register_physical_memory(s->bonito_cop_start, s->bonito_cop_length,
>> +                                 s->bonito_cop_handle);
>> +
>> +    /* Map PCI IO Space  0x1fd0 0000 - 0x1fd1 0000 */
>> +    s->bonito_pciio_start = BONITO_PCIIO_BASE;
>> +    s->bonito_pciio_length = BONITO_PCIIO_SIZE;
>> +    isa_mem_base = s->bonito_pciio_start;
>> +    isa_mmio_init(s->bonito_pciio_start, s->bonito_pciio_length, 0);
>> +
>> +    qemu_register_reset(bonito_reset, s);
>> +
>> +    return 0;
>> +}
>> +
>> +PCIBus *bonito_init(qemu_irq pic)
>> +{
>> +    DeviceState *dev;
>> +    PCIBus *b;
>> +    BonitoState *pcihost;
>> +    PCIBonitoState *s;
>> +    PCIDevice *d;
>> +
>> +    dev = qdev_create(NULL, "Bonito-pcihost");
>> +    pcihost = FROM_SYSBUS(BonitoState, sysbus_from_qdev(dev));
>> +    b = pci_register_bus(&pcihost->busdev.qdev, NULL, pci_bonito_set_irq,
>> +                         pci_bonito_map_irq, pic, 0x28, 32);
>
> This function takes a void *irq_opaque, not a qemu_irq.
> bonito_init(qemu_irq) should probably changed in bonito_init(qemu_irq
> *pic).
>
>> +    pcihost->bus = b;
>> +    qdev_init_nofail(dev);
>> +    pci_bus_set_mem_base(pcihost->bus, 0x10000000);
>> +
>> +    d = pci_create_simple(b, 0, "Bonito");
>> +    s = DO_UPCAST(PCIBonitoState, dev, d);
>> +    s->pcihost = pcihost;
>> +    bonito_state = s;
>> +
>> +    return b;
>> +}
>> +
>> +static PCIDeviceInfo bonito_info = {
>> +    .qdev.name    = "Bonito",
>> +    .qdev.desc    = "Host bridge",
>> +    .qdev.size    = sizeof(PCIBonitoState),
>> +    .qdev.vmsd    = &vmstate_bonito,
>> +    .qdev.no_user = 1,
>> +    .init         = bonito_initfn,
>> +};
>> +
>> +static SysBusDeviceInfo bonito_pcihost_info = {
>> +    .init         = bonito_pcihost_initfn,
>> +    .qdev.name    = "Bonito-pcihost",
>> +    .qdev.size    = sizeof(BonitoState),
>> +    .qdev.no_user = 1,
>> +};
>> +
>> +static void bonito_register(void)
>> +{
>> +    sysbus_register_withprop(&bonito_pcihost_info);
>> +    pci_qdev_register(&bonito_info);
>> +}
>> +device_init(bonito_register);
>> diff --git a/hw/mips.h b/hw/mips.h
>> index 30791a8..cd4fdf8 100644
>> --- a/hw/mips.h
>> +++ b/hw/mips.h
>> @@ -5,6 +5,9 @@
>>  /* gt64xxx.c */
>>  PCIBus *pci_gt64120_init(qemu_irq *pic);
>>
>> +/* bonito.c */
>> +PCIBus *bonito_init(qemu_irq pic);
>> +
>>  /* ds1225y.c */
>>  void *ds1225y_init(target_phys_addr_t mem_base, const char *filename);
>>  void ds1225y_set_protection(void *opaque, int protection);
>> --
>> 1.7.0.4
>>
>>
>>
>
> --
> Aurelien Jarno                          GPG: 1024D/F1BCDB73
> aurelien@aurel32.net                 http://www.aurel32.net
>
Isaku Yamahata June 3, 2010, 8:40 a.m. UTC | #3
Maybe it is time to enhance pci_host.c to take a callback
to decode the address, so that you can use pci_host helper functions.
It would simplify this patch and eliminates code duplication.

Some comments below.

On Wed, May 19, 2010 at 10:26:32PM +0800, Huacai Chen wrote:
> Signed-off-by: Huacai Chen <zltjiangshi@gmail.com>
> ---
>  Makefile.target                      |    1 +
>  default-configs/mips64el-softmmu.mak |    1 +
>  hw/bonito.c                          |  950 ++++++++++++++++++++++++++++++++++
>  hw/mips.h                            |    3 +
>  4 files changed, 955 insertions(+), 0 deletions(-)
>  create mode 100644 hw/bonito.c
> 
> diff --git a/Makefile.target b/Makefile.target
> index a22484e..247a2eb 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -221,6 +221,7 @@ obj-mips-y += dma.o vga.o i8259.o
>  obj-mips-y += g364fb.o jazz_led.o
>  obj-mips-y += gt64xxx.o pckbd.o mc146818rtc.o
>  obj-mips-y += piix4.o cirrus_vga.o
> +obj-mips-$(CONFIG_FULONG) += bonito.o
>  
>  obj-microblaze-y = petalogix_s3adsp1800_mmu.o
>  
> diff --git a/default-configs/mips64el-softmmu.mak b/default-configs/mips64el-softmmu.mak
> index 6fa54a3..b731c74 100644
> --- a/default-configs/mips64el-softmmu.mak
> +++ b/default-configs/mips64el-softmmu.mak
> @@ -27,3 +27,4 @@ CONFIG_DP8393X=y
>  CONFIG_DS1225Y=y
>  CONFIG_MIPSNET=y
>  CONFIG_PFLASH_CFI01=y
> +CONFIG_FULONG=y
> diff --git a/hw/bonito.c b/hw/bonito.c
> new file mode 100644
> index 0000000..246c12a
> --- /dev/null
> +++ b/hw/bonito.c
> @@ -0,0 +1,950 @@
> +/*
> + * bonito north bridge support
> + *
> + * Copyright (c) 2008 yajin (yajin@vm-kernel.org)
> + * Copyright (c) 2010 Huacai Chen (zltjiangshi@gmail.com)
> + *
> + * This code is licensed under the GNU GPL v2.
> + */
> +
> +/*
> + * fulong 2e mini pc has a bonito north bridge.
> + */
> +
> +/* what is the meaning of devfn in qemu and IDSEL in bonito northbridge?
> + *
> + * devfn   pci_slot<<3  + funno
> + * one pci bus can have 32 devices and each device can have 8 functions.
> + *
> + * In bonito north bridge, pci slot = IDSEL bit - 12.
> + * For example, PCI_IDSEL_VIA686B = 17,
> + * pci slot = 17-12=5
> + *
> + * so
> + * VT686B_FUN0's devfn = (5<<3)+0
> + * VT686B_FUN1's devfn = (5<<3)+1
> + *
> + * qemu also uses pci address for north bridge to access pci config register.
> + * bus_no   [23:16]
> + * dev_no   [15:11]
> + * fun_no   [10:8]
> + * reg_no   [7:2]
> + *
> + * so function bonito_sbridge_pciaddr for the translation from
> + * north bridge address to pci address.
> + */
> +
> +#include <assert.h>
> +
> +#include "hw.h"
> +#include "pci.h"
> +#include "pc.h"
> +#include "mips.h"
> +
> +typedef target_phys_addr_t pci_addr_t;

This isn't necessary anymore.
Perhaps you wrote this patch before the pci host clean ups.


> +#include "pci_host.h"
> +
> +//#define DEBUG_BONITO
> +
> +#ifdef DEBUG_BONITO
> +#define DPRINTF(fmt, ...) fprintf(stderr, "%s: " fmt, __FUNCTION__, ##__VA_ARGS__)
> +#else
> +#define DPRINTF(fmt, ...)
> +#endif
> +
> +/* from linux soure code. include/asm-mips/mips-boards/bonito64.h*/
> +#define BONITO_BOOT_BASE        0x1fc00000
> +#define BONITO_BOOT_SIZE        0x00100000
> +#define BONITO_BOOT_TOP         (BONITO_BOOT_BASE+BONITO_BOOT_SIZE-1)
> +#define BONITO_FLASH_BASE       0x1c000000
> +#define BONITO_FLASH_SIZE       0x03000000
> +#define BONITO_FLASH_TOP        (BONITO_FLASH_BASE+BONITO_FLASH_SIZE-1)
> +#define BONITO_SOCKET_BASE      0x1f800000
> +#define BONITO_SOCKET_SIZE      0x00400000
> +#define BONITO_SOCKET_TOP       (BONITO_SOCKET_BASE+BONITO_SOCKET_SIZE-1)
> +#define BONITO_REG_BASE         0x1fe00000
> +#define BONITO_REG_SIZE         0x00040000
> +#define BONITO_REG_TOP          (BONITO_REG_BASE+BONITO_REG_SIZE-1)
> +#define BONITO_DEV_BASE         0x1ff00000
> +#define BONITO_DEV_SIZE         0x00100000
> +#define BONITO_DEV_TOP          (BONITO_DEV_BASE+BONITO_DEV_SIZE-1)
> +#define BONITO_PCILO_BASE       0x10000000
> +#define BONITO_PCILO_BASE_VA    0xb0000000
> +#define BONITO_PCILO_SIZE       0x0c000000
> +#define BONITO_PCILO_TOP        (BONITO_PCILO_BASE+BONITO_PCILO_SIZE-1)
> +#define BONITO_PCILO0_BASE      0x10000000
> +#define BONITO_PCILO1_BASE      0x14000000
> +#define BONITO_PCILO2_BASE      0x18000000
> +#define BONITO_PCIHI_BASE       0x20000000
> +#define BONITO_PCIHI_SIZE       0x20000000
> +#define BONITO_PCIHI_TOP        (BONITO_PCIHI_BASE+BONITO_PCIHI_SIZE-1)
> +#define BONITO_PCIIO_BASE       0x1fd00000
> +#define BONITO_PCIIO_BASE_VA    0xbfd00000
> +#define BONITO_PCIIO_SIZE       0x00010000
> +#define BONITO_PCIIO_TOP        (BONITO_PCIIO_BASE+BONITO_PCIIO_SIZE-1)
> +#define BONITO_PCICFG_BASE      0x1fe80000
> +#define BONITO_PCICFG_SIZE      0x00080000
> +#define BONITO_PCICFG_TOP       (BONITO_PCICFG_BASE+BONITO_PCICFG_SIZE-1)
> +
> +
> +#define BONITO_PCICONFIGBASE    0x00
> +#define BONITO_REGBASE          0x100
> +
> +#define BONITO_PCICONFIG_BASE   (BONITO_PCICONFIGBASE+BONITO_REG_BASE)
> +#define BONITO_PCICONFIG_SIZE   (0x100)
> +
> +#define BONITO_INTERNAL_REG_BASE  (BONITO_REGBASE+BONITO_REG_BASE)
> +#define BONITO_INTERNAL_REG_SIZE  (0x70)
> +
> +#define BONITO_SPCICONFIG_BASE  (BONITO_PCICFG_BASE)
> +#define BONITO_SPCICONFIG_SIZE  (BONITO_PCICFG_SIZE)
> +
> +
> +
> +/* 1. Bonito h/w Configuration */
> +/* Power on register */
> +
> +#define BONITO_BONPONCFG        (0x00 >> 2)      /* 0x100 */
> +#define BONITO_BONGENCFG_OFFSET 0x4
> +#define BONITO_BONGENCFG        (BONITO_BONGENCFG_OFFSET>>2)   /*0x104 */
> +
> +/* 2. IO & IDE configuration */
> +#define BONITO_IODEVCFG         (0x08 >> 2)      /* 0x108 */
> +
> +/* 3. IO & IDE configuration */
> +#define BONITO_SDCFG            (0x0c >> 2)      /* 0x10c */
> +
> +/* 4. PCI address map control */
> +#define BONITO_PCIMAP           (0x10 >> 2)      /* 0x110 */
> +#define BONITO_PCIMEMBASECFG    (0x14 >> 2)      /* 0x114 */
> +#define BONITO_PCIMAP_CFG       (0x18 >> 2)      /* 0x118 */
> +
> +/* 5. ICU & GPIO regs */
> +/* GPIO Regs - r/w */
> +#define BONITO_GPIODATA_OFFSET  0x1c
> +#define BONITO_GPIODATA         (BONITO_GPIODATA_OFFSET >> 2)   /* 0x11c */
> +#define BONITO_GPIOIE           (0x20 >> 2)      /* 0x120 */
> +
> +/* ICU Configuration Regs - r/w */
> +#define BONITO_INTEDGE          (0x24 >> 2)      /* 0x124 */
> +#define BONITO_INTSTEER         (0x28 >> 2)      /* 0x128 */
> +#define BONITO_INTPOL           (0x2c >> 2)      /* 0x12c */
> +
> +/* ICU Enable Regs - IntEn & IntISR are r/o. */
> +#define BONITO_INTENSET         (0x30 >> 2)      /* 0x130 */
> +#define BONITO_INTENCLR         (0x34 >> 2)      /* 0x134 */
> +#define BONITO_INTEN            (0x38 >> 2)      /* 0x138 */
> +#define BONITO_INTISR           (0x3c >> 2)      /* 0x13c */
> +
> +/* PCI mail boxes */
> +#define BONITO_PCIMAIL0_OFFSET    0x40
> +#define BONITO_PCIMAIL1_OFFSET    0x44
> +#define BONITO_PCIMAIL2_OFFSET    0x48
> +#define BONITO_PCIMAIL3_OFFSET    0x4c
> +#define BONITO_PCIMAIL0         (0x40 >> 2)      /* 0x140 */
> +#define BONITO_PCIMAIL1         (0x44 >> 2)      /* 0x144 */
> +#define BONITO_PCIMAIL2         (0x48 >> 2)      /* 0x148 */
> +#define BONITO_PCIMAIL3         (0x4c >> 2)      /* 0x14c */
> +
> +/* 6. PCI cache */
> +#define BONITO_PCICACHECTRL     (0x50 >> 2)      /* 0x150 */
> +#define BONITO_PCICACHETAG      (0x54 >> 2)      /* 0x154 */
> +#define BONITO_PCIBADADDR       (0x58 >> 2)      /* 0x158 */
> +#define BONITO_PCIMSTAT         (0x5c >> 2)      /* 0x15c */
> +
> +/* 7. other*/
> +#define BONITO_TIMECFG          (0x60 >> 2)      /* 0x160 */
> +#define BONITO_CPUCFG           (0x64 >> 2)      /* 0x164 */
> +#define BONITO_DQCFG            (0x68 >> 2)      /* 0x168 */
> +#define BONITO_MEMSIZE          (0x6C >> 2)      /* 0x16c */
> +
> +#define BONITO_REGS             (0x70 >> 2)
> +
> +/* PCI config for south bridge. type 0 */
> +#define BONITO_PCICONF_IDSEL_MASK      0xfffff800     /* [31:11] */
> +#define BONITO_PCICONF_IDSEL_OFFSET    11
> +#define BONITO_PCICONF_FUN_MASK        0x700    /* [10:8] */
> +#define BONITO_PCICONF_FUN_OFFSET      8
> +#define BONITO_PCICONF_REG_MASK        0xFC
> +#define BONITO_PCICONF_REG_OFFSET      0
> +
> +
> +/* idsel BIT = pci slot number +12 */
> +#define PCI_SLOT_BASE              12
> +#define PCI_IDSEL_VIA686B_BIT      (17)
> +#define PCI_IDSEL_VIA686B          (1<<PCI_IDSEL_VIA686B_BIT)
> +
> +#define PCI_ADDR(busno,devno,funno,regno)  \
> +    ((((busno)<<16)&0xff0000) + (((devno)<<11)&0xf800) + (((funno)<<8)&0x700) + (regno))
> +
> +typedef PCIHostState BonitoState;
> +
> +typedef struct PCIBonitoState
> +{
> +    PCIDevice dev;
> +    BonitoState *pcihost;
> +    uint32_t regs[BONITO_REGS];
> +
> +    struct bonldma {
> +        uint32_t ldmactrl;
> +        uint32_t ldmastat;
> +        uint32_t ldmaaddr;
> +        uint32_t ldmago;
> +    } bonldma;
> +
> +    /* Based at 1fe00300, bonito Copier */
> +    struct boncop {
> +        uint32_t copctrl;
> +        uint32_t copstat;
> +        uint32_t coppaddr;
> +        uint32_t copgo;
> +    } boncop;
> +
> +    /* north brige pci config */
> +    uint8_t config[256];

Why is PCIDevice::config duplicated?
	
> +
> +    /* Bonito registers */
> +    target_phys_addr_t bonito_reg_start;
> +    target_phys_addr_t bonito_reg_length;
> +    int bonito_reg_handle;
> +
> +    target_phys_addr_t bonito_pciconf_start;
> +    target_phys_addr_t bonito_pciconf_length;
> +    int bonito_pciconf_handle;
> +
> +    target_phys_addr_t bonito_spciconf_start;
> +    target_phys_addr_t bonito_spciconf_length;
> +    int bonito_spciconf_handle;
> +
> +    target_phys_addr_t bonito_pciio_start;
> +    target_phys_addr_t bonito_pciio_length;
> +    int bonito_pciio_handle;
> +
> +    target_phys_addr_t bonito_localio_start;
> +    target_phys_addr_t bonito_localio_length;
> +    int bonito_localio_handle;
> +
> +    target_phys_addr_t bonito_ldma_start;
> +    target_phys_addr_t bonito_ldma_length;
> +    int bonito_ldma_handle;
> +
> +    target_phys_addr_t bonito_cop_start;
> +    target_phys_addr_t bonito_cop_length;
> +    int bonito_cop_handle;
> +
> +} PCIBonitoState;
> +
> +PCIBonitoState * bonito_state;
> +
> +static void bonito_writeb(void *opaque, target_phys_addr_t addr, uint32_t val)
> +{
> +    DPRINTF("bonito_writeb "TARGET_FMT_plx" val %x  \n", addr, val);
> +}
> +
> +static void bonito_writew(void *opaque, target_phys_addr_t addr, uint32_t val)
> +{
> +    DPRINTF("bonito_writew "TARGET_FMT_plx" val %x  \n", addr, val);
> +}
> +
> +static void bonito_writel(void *opaque, target_phys_addr_t addr, uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t saddr;
> +    int reset = 0;
> +
> +    saddr = (addr - 0x100) >> 2;
> +
> +    DPRINTF("bonito_writel "TARGET_FMT_plx" val %x saddr %x \n", addr, val, saddr);
> +    switch (saddr) {
> +    case BONITO_BONPONCFG:
> +    case BONITO_IODEVCFG:
> +    case BONITO_SDCFG:
> +    case BONITO_PCIMAP:
> +    case BONITO_PCIMEMBASECFG:
> +    case BONITO_PCIMAP_CFG:
> +    case BONITO_GPIODATA:
> +    case BONITO_GPIOIE:
> +    case BONITO_INTEDGE:
> +    case BONITO_INTSTEER:
> +    case BONITO_INTPOL:
> +    case BONITO_PCIMAIL0:
> +    case BONITO_PCIMAIL1:
> +    case BONITO_PCIMAIL2:
> +    case BONITO_PCIMAIL3:
> +    case BONITO_PCICACHECTRL:
> +    case BONITO_PCICACHETAG:
> +    case BONITO_PCIBADADDR:
> +    case BONITO_PCIMSTAT:
> +    case BONITO_TIMECFG:
> +    case BONITO_CPUCFG:
> +    case BONITO_DQCFG:
> +    case BONITO_MEMSIZE:
> +        s->regs[saddr] = val;
> +        break;
> +    case BONITO_BONGENCFG:
> +        if (!(s->regs[saddr] & 0x04) && (val & 0x04)) {
> +            reset = 1; /* bit 2 jump from 0 to 1 cause reset */
> +        }
> +        s->regs[saddr] = val;
> +        if (reset) {
> +            qemu_system_reset_request();
> +        }
> +        break;
> +    case BONITO_INTENSET:
> +        s->regs[BONITO_INTENSET] = val;
> +        s->regs[BONITO_INTEN] |= val;
> +        break;
> +    case BONITO_INTENCLR:
> +        s->regs[BONITO_INTENCLR] = val;
> +        s->regs[BONITO_INTEN] &= ~val;
> +        break;
> +    case BONITO_INTEN:
> +    case BONITO_INTISR:
> +    DPRINTF("write to readonly bonito register %x \n", saddr);
> +        break;
> +    default:
> +    DPRINTF("write to unknown bonito register %x \n", saddr);
> +        break;
> +    }
> +}
> +
> +static uint32_t bonito_readb(void *opaque, target_phys_addr_t addr)
> +{
> +    DPRINTF("bonito_readb "TARGET_FMT_plx"  \n", addr);
> +    return 0;
> +}
> +
> +static uint32_t bonito_readw(void *opaque, target_phys_addr_t addr)
> +{
> +    DPRINTF("bonito_readw "TARGET_FMT_plx"  \n", addr);
> +    return 0;
> +}
> +
> +static uint32_t bonito_readl(void *opaque, target_phys_addr_t addr)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t saddr;
> +
> +    saddr = (addr - 0x100) >> 2;
> +
> +    DPRINTF("bonito_readl "TARGET_FMT_plx"  \n", addr);
> +    switch (saddr) {
> +    case BONITO_INTISR:
> +        return s->regs[saddr];
> +    default:
> +        return s->regs[saddr];
> +    }
> +}
> +
> +static CPUWriteMemoryFunc * const bonito_write[] = {
> +    bonito_writeb,
> +    bonito_writew,
> +    bonito_writel,
> +};
> +
> +static CPUReadMemoryFunc * const bonito_read[] = {
> +    bonito_readb,
> +    bonito_readw,
> +    bonito_readl,
> +};
> +
> +static void bonito_pciconf_writeb(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    DPRINTF("bonito_pciconf_writeb "TARGET_FMT_plx" val %x \n", addr, val);
> +}
> +
> +static void bonito_pciconf_writew(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    DPRINTF("bonito_pciconf_writew "TARGET_FMT_plx" val %x \n", addr, val);
> +}
> +
> +static void bonito_pciconf_writel(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t saddr;
> +    uint32_t *ptr = (uint32_t *) s->config;
> +
> +    saddr = (addr) >> 2;
> +    DPRINTF("bonito_pciconf_writel "TARGET_FMT_plx" val %x \n", addr, val);
> +    ptr += saddr;
> +    *ptr = val;
> +}

s->dev->config_read(s->dev, addr, val, len)?

> +
> +static uint32_t bonito_pciconf_readb(void *opaque, target_phys_addr_t addr)
> +{
> +    DPRINTF("bonito_pciconf_readb "TARGET_FMT_plx"\n", addr);
> +    return 0;
> +}
> +static uint32_t bonito_pciconf_readw(void *opaque, target_phys_addr_t addr)
> +{
> +    DPRINTF("bonito_pciconf_readw "TARGET_FMT_plx"\n", addr);
> +    return 0;
> +}
> +
> +static uint32_t bonito_pciconf_readl(void *opaque, target_phys_addr_t addr)
> +{
> +
> +    PCIBonitoState *s = opaque;
> +    uint32_t saddr;
> +    uint32_t *ptr = (uint32_t *) s->config;
> +
> +    saddr = (addr) >> 2;
> +    DPRINTF("bonito_pciconf_readl "TARGET_FMT_plx"\n", addr);
> +    ptr += saddr;
> +
> +    return (*ptr);
> +}

s->dev->config_write(s->dev, addr, val, len)?

> +
> +/* north bridge PCI configure space. 0x1fe0 0000 - 0x1fe0 00ff */
> +static CPUWriteMemoryFunc * const bonito_pciconf_write[] = {
> +    bonito_pciconf_writeb,
> +    bonito_pciconf_writew,
> +    bonito_pciconf_writel,
> +};
> +
> +static CPUReadMemoryFunc * const bonito_pciconf_read[] = {
> +    bonito_pciconf_readb,
> +    bonito_pciconf_readw,
> +    bonito_pciconf_readl,
> +};
> +
> +static uint32_t bonito_localio_readb(void *opaque, target_phys_addr_t addr)
> +{
> +    uint32_t val;
> +
> +    DPRINTF("bonito_localio_readb "TARGET_FMT_plx"\n", addr);
> +    val = cpu_inb(addr & 0xffff);
> +    return val;
> +}
> +
> +static uint32_t bonito_localio_readw(void *opaque, target_phys_addr_t addr)
> +{
> +    uint32_t val;
> +
> +    DPRINTF("bonito_localio_readw "TARGET_FMT_plx"\n", addr);
> +    val = cpu_inw(addr & 0xffff);
> +#ifdef TARGET_WORDS_BIGENDIAN
> +    val = bswap16(val);
> +#endif
> +    return val;
> +}
> +
> +static uint32_t bonito_localio_readl(void *opaque, target_phys_addr_t addr)
> +{
> +    uint32_t val;
> +
> +    DPRINTF("bonito_localio_readl "TARGET_FMT_plx"\n", addr);
> +    val = cpu_inl(addr & 0xffff);
> +#ifdef TARGET_WORDS_BIGENDIAN
> +    val = bswap32(val);
> +#endif
> +    return val;
> +}
> +
> +static void bonito_localio_writeb(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    DPRINTF("bonito_localio_writeb "TARGET_FMT_plx"\n", addr);
> +    cpu_outb(addr & 0xffff, val);
> +}
> +
> +static void bonito_localio_writew(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    DPRINTF("bonito_localio_writew "TARGET_FMT_plx"\n", addr);
> +#ifdef TARGET_WORDS_BIGENDIAN
> +    val = bswap16(val);
> +#endif
> +    cpu_outw(addr & 0xffff, val);
> +}
> +
> +static void bonito_localio_writel(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val)
> +{
> +    DPRINTF("bonito_localio_writel "TARGET_FMT_plx"\n", addr);
> +#ifdef TARGET_WORDS_BIGENDIAN
> +    val = bswap32(val);
> +#endif
> +    cpu_outl(addr & 0xffff, val);
> +}
> +
> +static CPUReadMemoryFunc * const bonito_localio_read[] = {
> +    bonito_localio_readb,
> +    bonito_localio_readw,
> +    bonito_localio_readl,
> +};
> +
> +static CPUWriteMemoryFunc * const bonito_localio_write[] = {
> +    bonito_localio_writeb,
> +    bonito_localio_writew,
> +    bonito_localio_writel,
> +};
> +
> +static uint32_t bonito_ldma_readl(void *opaque, target_phys_addr_t addr)
> +{
> +    uint32_t val;
> +    PCIBonitoState *s = opaque;
> +
> +    val = ((uint32_t *)(&s->bonldma))[addr/sizeof(uint32_t)];
> +
> +    return val;
> +}
> +
> +static void bonito_ldma_writel(void *opaque, target_phys_addr_t addr,
> +                               uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +
> +    ((uint32_t *)(&s->bonldma))[addr/sizeof(uint32_t)] = val & 0xffffffff;
> +}
> +
> +static CPUWriteMemoryFunc * const bonito_ldma_write[] = {
> +    bonito_ldma_writel,
> +    bonito_ldma_writel,
> +    bonito_ldma_writel,
> +};
> +
> +static CPUReadMemoryFunc * const bonito_ldma_read[] = {
> +    bonito_ldma_readl,
> +    bonito_ldma_readl,
> +    bonito_ldma_readl,
> +};
> +
> +static uint32_t bonito_cop_readl(void *opaque, target_phys_addr_t addr)
> +{
> +    uint32_t val;
> +    PCIBonitoState *s = opaque;
> +
> +    val = ((uint32_t *)(&s->boncop))[addr/sizeof(uint32_t)];
> +
> +    return val;
> +}
> +
> +static void bonito_cop_writel(void *opaque, target_phys_addr_t addr,
> +                              uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +
> +    ((uint32_t *)(&s->boncop))[addr/sizeof(uint32_t)] = val & 0xffffffff;
> +}
> +
> +static CPUWriteMemoryFunc * const bonito_cop_write[] = {
> +    bonito_cop_writel,
> +    bonito_cop_writel,
> +    bonito_cop_writel,
> +};
> +
> +static CPUReadMemoryFunc * const bonito_cop_read[] = {
> +    bonito_cop_readl,
> +    bonito_cop_readl,
> +    bonito_cop_readl,
> +};
> +
> +static uint32_t bonito_sbridge_pciaddr(void *opaque, target_phys_addr_t addr)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t cfgaddr;
> +    uint32_t idsel;
> +    uint32_t devno;
> +    uint32_t funno;
> +    uint32_t regno;
> +    uint32_t pciaddr;
> +
> +    /* support type0 pci config */
> +    if ((s->regs[BONITO_PCIMAP_CFG] & 0x10000) != 0x0) {
> +        return 0xffffffff;
> +    }
> +
> +    cfgaddr = addr & 0xffff;
> +    cfgaddr |= (s->regs[BONITO_PCIMAP_CFG] & 0xffff) << 16;
> +
> +    idsel = (cfgaddr & BONITO_PCICONF_IDSEL_MASK) >> BONITO_PCICONF_IDSEL_OFFSET;
> +    devno = ffs(idsel) - 1;
> +    funno = (cfgaddr & BONITO_PCICONF_FUN_MASK) >> BONITO_PCICONF_FUN_OFFSET;
> +    regno = (cfgaddr & BONITO_PCICONF_REG_MASK) >> BONITO_PCICONF_REG_OFFSET;
> +
> +    if (idsel == 0) {
> +        fprintf(stderr, "error in bonito pci config address" TARGET_FMT_plx
> +            ",pcimap_cfg=%x\n", addr, s->regs[BONITO_PCIMAP_CFG]);
> +        exit(1);
> +    }
> +    pciaddr = PCI_ADDR(pci_bus_num(s->pcihost->bus), devno, funno, regno);
> +    DPRINTF("cfgaddr %x pciaddr %x busno %x devno %d funno %d regno %d \n",
> +        cfgaddr, pciaddr, pci_bus_num(s->pcihost->bus), devno, funno, regno);
> +
> +    return pciaddr;
> +}
> +
> +static void bonito_spciconf_writeb(void *opaque, target_phys_addr_t addr,
> +                                   uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_writeb "TARGET_FMT_plx" val %x \n", addr, val);
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val & 0xff, 1);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +}
> +
> +static void bonito_spciconf_writew(void *opaque, target_phys_addr_t addr,
> +                                   uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_writew "TARGET_FMT_plx" val %x \n", addr, val);
> +    assert((addr&0x1)==0);
> +
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val, 2);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +}
> +
> +static void bonito_spciconf_writel(void *opaque, target_phys_addr_t addr,
> +                                   uint32_t val)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_writel "TARGET_FMT_plx" val %x \n", addr, val);
> +    assert((addr&0x3)==0);
> +
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val, 4);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +}
> +
> +static uint32_t bonito_spciconf_readb(void *opaque, target_phys_addr_t addr)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_readb "TARGET_FMT_plx"  \n", addr);
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return 0xff;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +
> +    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 1);
> +}
> +
> +static uint32_t bonito_spciconf_readw(void *opaque, target_phys_addr_t addr)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_readw "TARGET_FMT_plx"  \n", addr);
> +    assert((addr&0x1)==0);
> +
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return 0xffff;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +
> +    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 2);
> +}
> +
> +static uint32_t bonito_spciconf_readl(void *opaque, target_phys_addr_t addr)
> +{
> +    PCIBonitoState *s = opaque;
> +    uint32_t pciaddr;
> +    uint16_t status;
> +
> +    DPRINTF("bonito_spciconf_readl "TARGET_FMT_plx"  \n", addr);
> +    assert((addr&0x3) == 0);
> +
> +    pciaddr = bonito_sbridge_pciaddr(s, addr);
> +
> +    if (pciaddr == 0xffffffff) {
> +        return 0xffffffff;
> +    }
> +
> +    /* set the pci address in s->config_reg */
> +    s->pcihost->config_reg = (pciaddr) | (1u << 31);
> +
> +    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
> +    status = pci_get_word(s->config + PCI_STATUS);
> +    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
> +    pci_set_word(s->config + PCI_STATUS, status);
> +
> +    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 4);
> +}
> +
> +/* south bridge PCI configure space. 0x1fe8 0000 - 0x1fef ffff */
> +static CPUWriteMemoryFunc * const bonito_spciconf_write[] = {
> +    bonito_spciconf_writeb,
> +    bonito_spciconf_writew,
> +    bonito_spciconf_writel,
> +};
> +
> +static CPUReadMemoryFunc * const bonito_spciconf_read[] = {
> +    bonito_spciconf_readb,
> +    bonito_spciconf_readw,
> +    bonito_spciconf_readl,
> +};

Maybe it would simply those code much to enhance pci_host
to get address decoding callback.


> +
> +#define BONITO_IRQ_BASE 32
> +
> +static void pci_bonito_set_irq(void *opaque, int irq_num, int level)
> +{
> +    qemu_irq pic = opaque;
> +    int internal_irq = irq_num - BONITO_IRQ_BASE;
> +
> +    if (bonito_state->regs[BONITO_INTEDGE] & (1<<internal_irq)) {
> +        qemu_irq_pulse(pic);
> +    } else {   /* level triggered */
> +        if (bonito_state->regs[BONITO_INTPOL] & (1<<internal_irq)) {
> +            qemu_irq_raise(pic);
> +        } else {
> +            qemu_irq_lower(pic);
> +        }
> +    }
> +}
> +
> +/* map the original irq (0~3) to bonito irq (16~47, but 16~31 are unused) */
> +static int pci_bonito_map_irq(PCIDevice * pci_dev, int irq_num)
> +{
> +    int slot;
> +
> +    slot = (pci_dev->devfn >> 3);
> +
> +    switch (slot) {
> +    case 5:   /* FULONG2E_VIA_SLOT, SouthBridge, IDE, USB, ACPI, AC97, MC97 */
> +        return irq_num % 4 + BONITO_IRQ_BASE;
> +    case 6:   /* FULONG2E_ATI_SLOT, VGA */
> +        return 4 + BONITO_IRQ_BASE;
> +    case 7:   /* FULONG2E_RTL_SLOT, RTL8139 */
> +        return 5 + BONITO_IRQ_BASE;
> +    case 8 ... 12: /* PCI slot 1 to 4 */
> +        return (slot - 8 + irq_num) + 6 + BONITO_IRQ_BASE;
> +    default:  /* Unknown device, don't do any translation */
> +        return irq_num;
> +    }
> +}
> +
> +static void bonito_reset(void *opaque)
> +{
> +    PCIBonitoState *s = opaque;
> +
> +    /* set the default value of north bridge pci config */
> +    s->config[0x04] = 0x00;
> +    s->config[0x05] = 0x00;
> +    s->config[0x06] = 0x00;
> +    s->config[0x07] = 0x00;
> +
> +    s->config[0x08] = 0x01;
> +    s->config[0x09] = 0x00;
> +    s->config[0x0a] = 0x00;
> +    s->config[0x0b] = 0x06;
> +
> +    s->config[0x2c] = 0x00;
> +    s->config[0x2d] = 0x00;
> +    s->config[0x2e] = 0x00;
> +    s->config[0x2f] = 0x00;
> +
> +    s->config[0x3c] = 0x00;
> +    s->config[0x3d] = 0x01;
> +    s->config[0x3e] = 0x3c;
> +    s->config[0x3f] = 0x00;

Please use symbols defined in pci_regs.h


> +
> +    /* set the default value of north bridge registers */
> +
> +    s->regs[BONITO_BONPONCFG] = 0xc40;
> +    s->regs[BONITO_BONGENCFG] = 0x1384;
> +    s->regs[BONITO_IODEVCFG] = 0x2bff8010;
> +    s->regs[BONITO_SDCFG] = 0x255e0091;
> +
> +    s->regs[BONITO_GPIODATA] = 0x1ff;
> +    s->regs[BONITO_GPIOIE] = 0x1ff;
> +    s->regs[BONITO_DQCFG] = 0x8;
> +    s->regs[BONITO_MEMSIZE] = 0x10000000;
> +    s->regs[BONITO_PCIMAP] = 0x6140;
> +}
> +
> +static const VMStateDescription vmstate_bonito = {
> +    .name = "Bonito",
> +    .version_id = 1,
> +    .minimum_version_id = 1,
> +    .minimum_version_id_old = 1,
> +    .fields      = (VMStateField []) {
> +        VMSTATE_PCI_DEVICE(dev, PCIBonitoState),
> +        VMSTATE_END_OF_LIST()
> +    }
> +};
> +
> +static int bonito_pcihost_initfn(SysBusDevice *dev)
> +{
> +    return 0;
> +}
> +
> +static int bonito_initfn(PCIDevice *dev)
> +{
> +    PCIBonitoState *s = DO_UPCAST(PCIBonitoState, dev, dev);
> +
> +    /* Bonito North Bridge, built on FPGA, VENDOR_ID/DEVICE_ID are "undefined" */
> +    pci_config_set_vendor_id(dev->config, 0xdf53);
> +    pci_config_set_device_id(dev->config, 0x00d5);
> +    pci_config_set_class(dev->config, PCI_CLASS_BRIDGE_HOST);
> +
> +    /* set the north bridge register mapping */
> +    s->bonito_reg_handle = cpu_register_io_memory(bonito_read, bonito_write, s);
> +    s->bonito_reg_start = BONITO_INTERNAL_REG_BASE;
> +    s->bonito_reg_length = BONITO_INTERNAL_REG_SIZE;
> +    cpu_register_physical_memory(s->bonito_reg_start, s->bonito_reg_length,
> +                                 s->bonito_reg_handle);
> +
> +    /* set the north bridge pci configure  mapping */
> +    s->bonito_pciconf_handle = cpu_register_io_memory(bonito_pciconf_read,
> +                                                      bonito_pciconf_write, s);
> +    s->bonito_pciconf_start = BONITO_PCICONFIG_BASE;
> +    s->bonito_pciconf_length = BONITO_PCICONFIG_SIZE;
> +    cpu_register_physical_memory(s->bonito_pciconf_start, s->bonito_pciconf_length,
> +                                 s->bonito_pciconf_handle);
> +
> +    /* set the south bridge pci configure  mapping */
> +    s->bonito_spciconf_handle = cpu_register_io_memory(bonito_spciconf_read,
> +                                                       bonito_spciconf_write, s);
> +    s->bonito_spciconf_start = BONITO_SPCICONFIG_BASE;
> +    s->bonito_spciconf_length = BONITO_SPCICONFIG_SIZE;
> +    cpu_register_physical_memory(s->bonito_spciconf_start, s->bonito_spciconf_length,
> +                                 s->bonito_spciconf_handle);
> +
> +    /* add pci local io mapping */
> +    s->bonito_localio_handle = cpu_register_io_memory(bonito_localio_read,
> +                                                      bonito_localio_write, s);
> +    s->bonito_localio_start = BONITO_DEV_BASE;
> +    s->bonito_localio_length = BONITO_DEV_SIZE;
> +    cpu_register_physical_memory(s->bonito_localio_start, s->bonito_localio_length,
> +                                 s->bonito_localio_handle);
> +
> +    s->bonito_ldma_handle = cpu_register_io_memory(bonito_ldma_read,
> +                                                   bonito_ldma_write, s);
> +    s->bonito_ldma_start = 0xbfe00200;
> +    s->bonito_ldma_length = 0x100;
> +    cpu_register_physical_memory(s->bonito_ldma_start, s->bonito_ldma_length,
> +                                 s->bonito_ldma_handle);
> +
> +    s->bonito_cop_handle = cpu_register_io_memory(bonito_cop_read,
> +                                                  bonito_cop_write, s);
> +    s->bonito_cop_start = 0xbfe00300;
> +    s->bonito_cop_length = 0x100;
> +    cpu_register_physical_memory(s->bonito_cop_start, s->bonito_cop_length,
> +                                 s->bonito_cop_handle);
> +
> +    /* Map PCI IO Space  0x1fd0 0000 - 0x1fd1 0000 */
> +    s->bonito_pciio_start = BONITO_PCIIO_BASE;
> +    s->bonito_pciio_length = BONITO_PCIIO_SIZE;
> +    isa_mem_base = s->bonito_pciio_start;
> +    isa_mmio_init(s->bonito_pciio_start, s->bonito_pciio_length, 0);
> +
> +    qemu_register_reset(bonito_reset, s);
> +
> +    return 0;
> +}
> +
> +PCIBus *bonito_init(qemu_irq pic)
> +{
> +    DeviceState *dev;
> +    PCIBus *b;
> +    BonitoState *pcihost;
> +    PCIBonitoState *s;
> +    PCIDevice *d;
> +
> +    dev = qdev_create(NULL, "Bonito-pcihost");
> +    pcihost = FROM_SYSBUS(BonitoState, sysbus_from_qdev(dev));
> +    b = pci_register_bus(&pcihost->busdev.qdev, NULL, pci_bonito_set_irq,
> +                         pci_bonito_map_irq, pic, 0x28, 32);

Please supply bus name. "pci" or "pci.0"?


> +    pcihost->bus = b;
> +    qdev_init_nofail(dev);
> +    pci_bus_set_mem_base(pcihost->bus, 0x10000000);
> +
> +    d = pci_create_simple(b, 0, "Bonito");

PCI_DEVFN(0, 0) would be more descriptive a bit, but 0 is okay.


> +    s = DO_UPCAST(PCIBonitoState, dev, d);
> +    s->pcihost = pcihost;
> +    bonito_state = s;
> +
> +    return b;
> +}
> +
> +static PCIDeviceInfo bonito_info = {
> +    .qdev.name    = "Bonito",
> +    .qdev.desc    = "Host bridge",
> +    .qdev.size    = sizeof(PCIBonitoState),
> +    .qdev.vmsd    = &vmstate_bonito,
> +    .qdev.no_user = 1,
> +    .init         = bonito_initfn,
> +};
> +
> +static SysBusDeviceInfo bonito_pcihost_info = {
> +    .init         = bonito_pcihost_initfn,
> +    .qdev.name    = "Bonito-pcihost",
> +    .qdev.size    = sizeof(BonitoState),
> +    .qdev.no_user = 1,
> +};
> +
> +static void bonito_register(void)
> +{
> +    sysbus_register_withprop(&bonito_pcihost_info);
> +    pci_qdev_register(&bonito_info);
> +}
> +device_init(bonito_register);
> diff --git a/hw/mips.h b/hw/mips.h
> index 30791a8..cd4fdf8 100644
> --- a/hw/mips.h
> +++ b/hw/mips.h
> @@ -5,6 +5,9 @@
>  /* gt64xxx.c */
>  PCIBus *pci_gt64120_init(qemu_irq *pic);
>  
> +/* bonito.c */
> +PCIBus *bonito_init(qemu_irq pic);
> +
>  /* ds1225y.c */
>  void *ds1225y_init(target_phys_addr_t mem_base, const char *filename);
>  void ds1225y_set_protection(void *opaque, int protection);
> -- 
> 1.7.0.4
> 
>
diff mbox

Patch

diff --git a/Makefile.target b/Makefile.target
index a22484e..247a2eb 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -221,6 +221,7 @@  obj-mips-y += dma.o vga.o i8259.o
 obj-mips-y += g364fb.o jazz_led.o
 obj-mips-y += gt64xxx.o pckbd.o mc146818rtc.o
 obj-mips-y += piix4.o cirrus_vga.o
+obj-mips-$(CONFIG_FULONG) += bonito.o
 
 obj-microblaze-y = petalogix_s3adsp1800_mmu.o
 
diff --git a/default-configs/mips64el-softmmu.mak b/default-configs/mips64el-softmmu.mak
index 6fa54a3..b731c74 100644
--- a/default-configs/mips64el-softmmu.mak
+++ b/default-configs/mips64el-softmmu.mak
@@ -27,3 +27,4 @@  CONFIG_DP8393X=y
 CONFIG_DS1225Y=y
 CONFIG_MIPSNET=y
 CONFIG_PFLASH_CFI01=y
+CONFIG_FULONG=y
diff --git a/hw/bonito.c b/hw/bonito.c
new file mode 100644
index 0000000..246c12a
--- /dev/null
+++ b/hw/bonito.c
@@ -0,0 +1,950 @@ 
+/*
+ * bonito north bridge support
+ *
+ * Copyright (c) 2008 yajin (yajin@vm-kernel.org)
+ * Copyright (c) 2010 Huacai Chen (zltjiangshi@gmail.com)
+ *
+ * This code is licensed under the GNU GPL v2.
+ */
+
+/*
+ * fulong 2e mini pc has a bonito north bridge.
+ */
+
+/* what is the meaning of devfn in qemu and IDSEL in bonito northbridge?
+ *
+ * devfn   pci_slot<<3  + funno
+ * one pci bus can have 32 devices and each device can have 8 functions.
+ *
+ * In bonito north bridge, pci slot = IDSEL bit - 12.
+ * For example, PCI_IDSEL_VIA686B = 17,
+ * pci slot = 17-12=5
+ *
+ * so
+ * VT686B_FUN0's devfn = (5<<3)+0
+ * VT686B_FUN1's devfn = (5<<3)+1
+ *
+ * qemu also uses pci address for north bridge to access pci config register.
+ * bus_no   [23:16]
+ * dev_no   [15:11]
+ * fun_no   [10:8]
+ * reg_no   [7:2]
+ *
+ * so function bonito_sbridge_pciaddr for the translation from
+ * north bridge address to pci address.
+ */
+
+#include <assert.h>
+
+#include "hw.h"
+#include "pci.h"
+#include "pc.h"
+#include "mips.h"
+
+typedef target_phys_addr_t pci_addr_t;
+#include "pci_host.h"
+
+//#define DEBUG_BONITO
+
+#ifdef DEBUG_BONITO
+#define DPRINTF(fmt, ...) fprintf(stderr, "%s: " fmt, __FUNCTION__, ##__VA_ARGS__)
+#else
+#define DPRINTF(fmt, ...)
+#endif
+
+/* from linux soure code. include/asm-mips/mips-boards/bonito64.h*/
+#define BONITO_BOOT_BASE        0x1fc00000
+#define BONITO_BOOT_SIZE        0x00100000
+#define BONITO_BOOT_TOP         (BONITO_BOOT_BASE+BONITO_BOOT_SIZE-1)
+#define BONITO_FLASH_BASE       0x1c000000
+#define BONITO_FLASH_SIZE       0x03000000
+#define BONITO_FLASH_TOP        (BONITO_FLASH_BASE+BONITO_FLASH_SIZE-1)
+#define BONITO_SOCKET_BASE      0x1f800000
+#define BONITO_SOCKET_SIZE      0x00400000
+#define BONITO_SOCKET_TOP       (BONITO_SOCKET_BASE+BONITO_SOCKET_SIZE-1)
+#define BONITO_REG_BASE         0x1fe00000
+#define BONITO_REG_SIZE         0x00040000
+#define BONITO_REG_TOP          (BONITO_REG_BASE+BONITO_REG_SIZE-1)
+#define BONITO_DEV_BASE         0x1ff00000
+#define BONITO_DEV_SIZE         0x00100000
+#define BONITO_DEV_TOP          (BONITO_DEV_BASE+BONITO_DEV_SIZE-1)
+#define BONITO_PCILO_BASE       0x10000000
+#define BONITO_PCILO_BASE_VA    0xb0000000
+#define BONITO_PCILO_SIZE       0x0c000000
+#define BONITO_PCILO_TOP        (BONITO_PCILO_BASE+BONITO_PCILO_SIZE-1)
+#define BONITO_PCILO0_BASE      0x10000000
+#define BONITO_PCILO1_BASE      0x14000000
+#define BONITO_PCILO2_BASE      0x18000000
+#define BONITO_PCIHI_BASE       0x20000000
+#define BONITO_PCIHI_SIZE       0x20000000
+#define BONITO_PCIHI_TOP        (BONITO_PCIHI_BASE+BONITO_PCIHI_SIZE-1)
+#define BONITO_PCIIO_BASE       0x1fd00000
+#define BONITO_PCIIO_BASE_VA    0xbfd00000
+#define BONITO_PCIIO_SIZE       0x00010000
+#define BONITO_PCIIO_TOP        (BONITO_PCIIO_BASE+BONITO_PCIIO_SIZE-1)
+#define BONITO_PCICFG_BASE      0x1fe80000
+#define BONITO_PCICFG_SIZE      0x00080000
+#define BONITO_PCICFG_TOP       (BONITO_PCICFG_BASE+BONITO_PCICFG_SIZE-1)
+
+
+#define BONITO_PCICONFIGBASE    0x00
+#define BONITO_REGBASE          0x100
+
+#define BONITO_PCICONFIG_BASE   (BONITO_PCICONFIGBASE+BONITO_REG_BASE)
+#define BONITO_PCICONFIG_SIZE   (0x100)
+
+#define BONITO_INTERNAL_REG_BASE  (BONITO_REGBASE+BONITO_REG_BASE)
+#define BONITO_INTERNAL_REG_SIZE  (0x70)
+
+#define BONITO_SPCICONFIG_BASE  (BONITO_PCICFG_BASE)
+#define BONITO_SPCICONFIG_SIZE  (BONITO_PCICFG_SIZE)
+
+
+
+/* 1. Bonito h/w Configuration */
+/* Power on register */
+
+#define BONITO_BONPONCFG        (0x00 >> 2)      /* 0x100 */
+#define BONITO_BONGENCFG_OFFSET 0x4
+#define BONITO_BONGENCFG        (BONITO_BONGENCFG_OFFSET>>2)   /*0x104 */
+
+/* 2. IO & IDE configuration */
+#define BONITO_IODEVCFG         (0x08 >> 2)      /* 0x108 */
+
+/* 3. IO & IDE configuration */
+#define BONITO_SDCFG            (0x0c >> 2)      /* 0x10c */
+
+/* 4. PCI address map control */
+#define BONITO_PCIMAP           (0x10 >> 2)      /* 0x110 */
+#define BONITO_PCIMEMBASECFG    (0x14 >> 2)      /* 0x114 */
+#define BONITO_PCIMAP_CFG       (0x18 >> 2)      /* 0x118 */
+
+/* 5. ICU & GPIO regs */
+/* GPIO Regs - r/w */
+#define BONITO_GPIODATA_OFFSET  0x1c
+#define BONITO_GPIODATA         (BONITO_GPIODATA_OFFSET >> 2)   /* 0x11c */
+#define BONITO_GPIOIE           (0x20 >> 2)      /* 0x120 */
+
+/* ICU Configuration Regs - r/w */
+#define BONITO_INTEDGE          (0x24 >> 2)      /* 0x124 */
+#define BONITO_INTSTEER         (0x28 >> 2)      /* 0x128 */
+#define BONITO_INTPOL           (0x2c >> 2)      /* 0x12c */
+
+/* ICU Enable Regs - IntEn & IntISR are r/o. */
+#define BONITO_INTENSET         (0x30 >> 2)      /* 0x130 */
+#define BONITO_INTENCLR         (0x34 >> 2)      /* 0x134 */
+#define BONITO_INTEN            (0x38 >> 2)      /* 0x138 */
+#define BONITO_INTISR           (0x3c >> 2)      /* 0x13c */
+
+/* PCI mail boxes */
+#define BONITO_PCIMAIL0_OFFSET    0x40
+#define BONITO_PCIMAIL1_OFFSET    0x44
+#define BONITO_PCIMAIL2_OFFSET    0x48
+#define BONITO_PCIMAIL3_OFFSET    0x4c
+#define BONITO_PCIMAIL0         (0x40 >> 2)      /* 0x140 */
+#define BONITO_PCIMAIL1         (0x44 >> 2)      /* 0x144 */
+#define BONITO_PCIMAIL2         (0x48 >> 2)      /* 0x148 */
+#define BONITO_PCIMAIL3         (0x4c >> 2)      /* 0x14c */
+
+/* 6. PCI cache */
+#define BONITO_PCICACHECTRL     (0x50 >> 2)      /* 0x150 */
+#define BONITO_PCICACHETAG      (0x54 >> 2)      /* 0x154 */
+#define BONITO_PCIBADADDR       (0x58 >> 2)      /* 0x158 */
+#define BONITO_PCIMSTAT         (0x5c >> 2)      /* 0x15c */
+
+/* 7. other*/
+#define BONITO_TIMECFG          (0x60 >> 2)      /* 0x160 */
+#define BONITO_CPUCFG           (0x64 >> 2)      /* 0x164 */
+#define BONITO_DQCFG            (0x68 >> 2)      /* 0x168 */
+#define BONITO_MEMSIZE          (0x6C >> 2)      /* 0x16c */
+
+#define BONITO_REGS             (0x70 >> 2)
+
+/* PCI config for south bridge. type 0 */
+#define BONITO_PCICONF_IDSEL_MASK      0xfffff800     /* [31:11] */
+#define BONITO_PCICONF_IDSEL_OFFSET    11
+#define BONITO_PCICONF_FUN_MASK        0x700    /* [10:8] */
+#define BONITO_PCICONF_FUN_OFFSET      8
+#define BONITO_PCICONF_REG_MASK        0xFC
+#define BONITO_PCICONF_REG_OFFSET      0
+
+
+/* idsel BIT = pci slot number +12 */
+#define PCI_SLOT_BASE              12
+#define PCI_IDSEL_VIA686B_BIT      (17)
+#define PCI_IDSEL_VIA686B          (1<<PCI_IDSEL_VIA686B_BIT)
+
+#define PCI_ADDR(busno,devno,funno,regno)  \
+    ((((busno)<<16)&0xff0000) + (((devno)<<11)&0xf800) + (((funno)<<8)&0x700) + (regno))
+
+typedef PCIHostState BonitoState;
+
+typedef struct PCIBonitoState
+{
+    PCIDevice dev;
+    BonitoState *pcihost;
+    uint32_t regs[BONITO_REGS];
+
+    struct bonldma {
+        uint32_t ldmactrl;
+        uint32_t ldmastat;
+        uint32_t ldmaaddr;
+        uint32_t ldmago;
+    } bonldma;
+
+    /* Based at 1fe00300, bonito Copier */
+    struct boncop {
+        uint32_t copctrl;
+        uint32_t copstat;
+        uint32_t coppaddr;
+        uint32_t copgo;
+    } boncop;
+
+    /* north brige pci config */
+    uint8_t config[256];
+
+    /* Bonito registers */
+    target_phys_addr_t bonito_reg_start;
+    target_phys_addr_t bonito_reg_length;
+    int bonito_reg_handle;
+
+    target_phys_addr_t bonito_pciconf_start;
+    target_phys_addr_t bonito_pciconf_length;
+    int bonito_pciconf_handle;
+
+    target_phys_addr_t bonito_spciconf_start;
+    target_phys_addr_t bonito_spciconf_length;
+    int bonito_spciconf_handle;
+
+    target_phys_addr_t bonito_pciio_start;
+    target_phys_addr_t bonito_pciio_length;
+    int bonito_pciio_handle;
+
+    target_phys_addr_t bonito_localio_start;
+    target_phys_addr_t bonito_localio_length;
+    int bonito_localio_handle;
+
+    target_phys_addr_t bonito_ldma_start;
+    target_phys_addr_t bonito_ldma_length;
+    int bonito_ldma_handle;
+
+    target_phys_addr_t bonito_cop_start;
+    target_phys_addr_t bonito_cop_length;
+    int bonito_cop_handle;
+
+} PCIBonitoState;
+
+PCIBonitoState * bonito_state;
+
+static void bonito_writeb(void *opaque, target_phys_addr_t addr, uint32_t val)
+{
+    DPRINTF("bonito_writeb "TARGET_FMT_plx" val %x  \n", addr, val);
+}
+
+static void bonito_writew(void *opaque, target_phys_addr_t addr, uint32_t val)
+{
+    DPRINTF("bonito_writew "TARGET_FMT_plx" val %x  \n", addr, val);
+}
+
+static void bonito_writel(void *opaque, target_phys_addr_t addr, uint32_t val)
+{
+    PCIBonitoState *s = opaque;
+    uint32_t saddr;
+    int reset = 0;
+
+    saddr = (addr - 0x100) >> 2;
+
+    DPRINTF("bonito_writel "TARGET_FMT_plx" val %x saddr %x \n", addr, val, saddr);
+    switch (saddr) {
+    case BONITO_BONPONCFG:
+    case BONITO_IODEVCFG:
+    case BONITO_SDCFG:
+    case BONITO_PCIMAP:
+    case BONITO_PCIMEMBASECFG:
+    case BONITO_PCIMAP_CFG:
+    case BONITO_GPIODATA:
+    case BONITO_GPIOIE:
+    case BONITO_INTEDGE:
+    case BONITO_INTSTEER:
+    case BONITO_INTPOL:
+    case BONITO_PCIMAIL0:
+    case BONITO_PCIMAIL1:
+    case BONITO_PCIMAIL2:
+    case BONITO_PCIMAIL3:
+    case BONITO_PCICACHECTRL:
+    case BONITO_PCICACHETAG:
+    case BONITO_PCIBADADDR:
+    case BONITO_PCIMSTAT:
+    case BONITO_TIMECFG:
+    case BONITO_CPUCFG:
+    case BONITO_DQCFG:
+    case BONITO_MEMSIZE:
+        s->regs[saddr] = val;
+        break;
+    case BONITO_BONGENCFG:
+        if (!(s->regs[saddr] & 0x04) && (val & 0x04)) {
+            reset = 1; /* bit 2 jump from 0 to 1 cause reset */
+        }
+        s->regs[saddr] = val;
+        if (reset) {
+            qemu_system_reset_request();
+        }
+        break;
+    case BONITO_INTENSET:
+        s->regs[BONITO_INTENSET] = val;
+        s->regs[BONITO_INTEN] |= val;
+        break;
+    case BONITO_INTENCLR:
+        s->regs[BONITO_INTENCLR] = val;
+        s->regs[BONITO_INTEN] &= ~val;
+        break;
+    case BONITO_INTEN:
+    case BONITO_INTISR:
+    DPRINTF("write to readonly bonito register %x \n", saddr);
+        break;
+    default:
+    DPRINTF("write to unknown bonito register %x \n", saddr);
+        break;
+    }
+}
+
+static uint32_t bonito_readb(void *opaque, target_phys_addr_t addr)
+{
+    DPRINTF("bonito_readb "TARGET_FMT_plx"  \n", addr);
+    return 0;
+}
+
+static uint32_t bonito_readw(void *opaque, target_phys_addr_t addr)
+{
+    DPRINTF("bonito_readw "TARGET_FMT_plx"  \n", addr);
+    return 0;
+}
+
+static uint32_t bonito_readl(void *opaque, target_phys_addr_t addr)
+{
+    PCIBonitoState *s = opaque;
+    uint32_t saddr;
+
+    saddr = (addr - 0x100) >> 2;
+
+    DPRINTF("bonito_readl "TARGET_FMT_plx"  \n", addr);
+    switch (saddr) {
+    case BONITO_INTISR:
+        return s->regs[saddr];
+    default:
+        return s->regs[saddr];
+    }
+}
+
+static CPUWriteMemoryFunc * const bonito_write[] = {
+    bonito_writeb,
+    bonito_writew,
+    bonito_writel,
+};
+
+static CPUReadMemoryFunc * const bonito_read[] = {
+    bonito_readb,
+    bonito_readw,
+    bonito_readl,
+};
+
+static void bonito_pciconf_writeb(void *opaque, target_phys_addr_t addr,
+                                  uint32_t val)
+{
+    DPRINTF("bonito_pciconf_writeb "TARGET_FMT_plx" val %x \n", addr, val);
+}
+
+static void bonito_pciconf_writew(void *opaque, target_phys_addr_t addr,
+                                  uint32_t val)
+{
+    DPRINTF("bonito_pciconf_writew "TARGET_FMT_plx" val %x \n", addr, val);
+}
+
+static void bonito_pciconf_writel(void *opaque, target_phys_addr_t addr,
+                                  uint32_t val)
+{
+    PCIBonitoState *s = opaque;
+    uint32_t saddr;
+    uint32_t *ptr = (uint32_t *) s->config;
+
+    saddr = (addr) >> 2;
+    DPRINTF("bonito_pciconf_writel "TARGET_FMT_plx" val %x \n", addr, val);
+    ptr += saddr;
+    *ptr = val;
+}
+
+static uint32_t bonito_pciconf_readb(void *opaque, target_phys_addr_t addr)
+{
+    DPRINTF("bonito_pciconf_readb "TARGET_FMT_plx"\n", addr);
+    return 0;
+}
+static uint32_t bonito_pciconf_readw(void *opaque, target_phys_addr_t addr)
+{
+    DPRINTF("bonito_pciconf_readw "TARGET_FMT_plx"\n", addr);
+    return 0;
+}
+
+static uint32_t bonito_pciconf_readl(void *opaque, target_phys_addr_t addr)
+{
+
+    PCIBonitoState *s = opaque;
+    uint32_t saddr;
+    uint32_t *ptr = (uint32_t *) s->config;
+
+    saddr = (addr) >> 2;
+    DPRINTF("bonito_pciconf_readl "TARGET_FMT_plx"\n", addr);
+    ptr += saddr;
+
+    return (*ptr);
+}
+
+/* north bridge PCI configure space. 0x1fe0 0000 - 0x1fe0 00ff */
+static CPUWriteMemoryFunc * const bonito_pciconf_write[] = {
+    bonito_pciconf_writeb,
+    bonito_pciconf_writew,
+    bonito_pciconf_writel,
+};
+
+static CPUReadMemoryFunc * const bonito_pciconf_read[] = {
+    bonito_pciconf_readb,
+    bonito_pciconf_readw,
+    bonito_pciconf_readl,
+};
+
+static uint32_t bonito_localio_readb(void *opaque, target_phys_addr_t addr)
+{
+    uint32_t val;
+
+    DPRINTF("bonito_localio_readb "TARGET_FMT_plx"\n", addr);
+    val = cpu_inb(addr & 0xffff);
+    return val;
+}
+
+static uint32_t bonito_localio_readw(void *opaque, target_phys_addr_t addr)
+{
+    uint32_t val;
+
+    DPRINTF("bonito_localio_readw "TARGET_FMT_plx"\n", addr);
+    val = cpu_inw(addr & 0xffff);
+#ifdef TARGET_WORDS_BIGENDIAN
+    val = bswap16(val);
+#endif
+    return val;
+}
+
+static uint32_t bonito_localio_readl(void *opaque, target_phys_addr_t addr)
+{
+    uint32_t val;
+
+    DPRINTF("bonito_localio_readl "TARGET_FMT_plx"\n", addr);
+    val = cpu_inl(addr & 0xffff);
+#ifdef TARGET_WORDS_BIGENDIAN
+    val = bswap32(val);
+#endif
+    return val;
+}
+
+static void bonito_localio_writeb(void *opaque, target_phys_addr_t addr,
+                                  uint32_t val)
+{
+    DPRINTF("bonito_localio_writeb "TARGET_FMT_plx"\n", addr);
+    cpu_outb(addr & 0xffff, val);
+}
+
+static void bonito_localio_writew(void *opaque, target_phys_addr_t addr,
+                                  uint32_t val)
+{
+    DPRINTF("bonito_localio_writew "TARGET_FMT_plx"\n", addr);
+#ifdef TARGET_WORDS_BIGENDIAN
+    val = bswap16(val);
+#endif
+    cpu_outw(addr & 0xffff, val);
+}
+
+static void bonito_localio_writel(void *opaque, target_phys_addr_t addr,
+                                  uint32_t val)
+{
+    DPRINTF("bonito_localio_writel "TARGET_FMT_plx"\n", addr);
+#ifdef TARGET_WORDS_BIGENDIAN
+    val = bswap32(val);
+#endif
+    cpu_outl(addr & 0xffff, val);
+}
+
+static CPUReadMemoryFunc * const bonito_localio_read[] = {
+    bonito_localio_readb,
+    bonito_localio_readw,
+    bonito_localio_readl,
+};
+
+static CPUWriteMemoryFunc * const bonito_localio_write[] = {
+    bonito_localio_writeb,
+    bonito_localio_writew,
+    bonito_localio_writel,
+};
+
+static uint32_t bonito_ldma_readl(void *opaque, target_phys_addr_t addr)
+{
+    uint32_t val;
+    PCIBonitoState *s = opaque;
+
+    val = ((uint32_t *)(&s->bonldma))[addr/sizeof(uint32_t)];
+
+    return val;
+}
+
+static void bonito_ldma_writel(void *opaque, target_phys_addr_t addr,
+                               uint32_t val)
+{
+    PCIBonitoState *s = opaque;
+
+    ((uint32_t *)(&s->bonldma))[addr/sizeof(uint32_t)] = val & 0xffffffff;
+}
+
+static CPUWriteMemoryFunc * const bonito_ldma_write[] = {
+    bonito_ldma_writel,
+    bonito_ldma_writel,
+    bonito_ldma_writel,
+};
+
+static CPUReadMemoryFunc * const bonito_ldma_read[] = {
+    bonito_ldma_readl,
+    bonito_ldma_readl,
+    bonito_ldma_readl,
+};
+
+static uint32_t bonito_cop_readl(void *opaque, target_phys_addr_t addr)
+{
+    uint32_t val;
+    PCIBonitoState *s = opaque;
+
+    val = ((uint32_t *)(&s->boncop))[addr/sizeof(uint32_t)];
+
+    return val;
+}
+
+static void bonito_cop_writel(void *opaque, target_phys_addr_t addr,
+                              uint32_t val)
+{
+    PCIBonitoState *s = opaque;
+
+    ((uint32_t *)(&s->boncop))[addr/sizeof(uint32_t)] = val & 0xffffffff;
+}
+
+static CPUWriteMemoryFunc * const bonito_cop_write[] = {
+    bonito_cop_writel,
+    bonito_cop_writel,
+    bonito_cop_writel,
+};
+
+static CPUReadMemoryFunc * const bonito_cop_read[] = {
+    bonito_cop_readl,
+    bonito_cop_readl,
+    bonito_cop_readl,
+};
+
+static uint32_t bonito_sbridge_pciaddr(void *opaque, target_phys_addr_t addr)
+{
+    PCIBonitoState *s = opaque;
+    uint32_t cfgaddr;
+    uint32_t idsel;
+    uint32_t devno;
+    uint32_t funno;
+    uint32_t regno;
+    uint32_t pciaddr;
+
+    /* support type0 pci config */
+    if ((s->regs[BONITO_PCIMAP_CFG] & 0x10000) != 0x0) {
+        return 0xffffffff;
+    }
+
+    cfgaddr = addr & 0xffff;
+    cfgaddr |= (s->regs[BONITO_PCIMAP_CFG] & 0xffff) << 16;
+
+    idsel = (cfgaddr & BONITO_PCICONF_IDSEL_MASK) >> BONITO_PCICONF_IDSEL_OFFSET;
+    devno = ffs(idsel) - 1;
+    funno = (cfgaddr & BONITO_PCICONF_FUN_MASK) >> BONITO_PCICONF_FUN_OFFSET;
+    regno = (cfgaddr & BONITO_PCICONF_REG_MASK) >> BONITO_PCICONF_REG_OFFSET;
+
+    if (idsel == 0) {
+        fprintf(stderr, "error in bonito pci config address" TARGET_FMT_plx
+            ",pcimap_cfg=%x\n", addr, s->regs[BONITO_PCIMAP_CFG]);
+        exit(1);
+    }
+    pciaddr = PCI_ADDR(pci_bus_num(s->pcihost->bus), devno, funno, regno);
+    DPRINTF("cfgaddr %x pciaddr %x busno %x devno %d funno %d regno %d \n",
+        cfgaddr, pciaddr, pci_bus_num(s->pcihost->bus), devno, funno, regno);
+
+    return pciaddr;
+}
+
+static void bonito_spciconf_writeb(void *opaque, target_phys_addr_t addr,
+                                   uint32_t val)
+{
+    PCIBonitoState *s = opaque;
+    uint32_t pciaddr;
+    uint16_t status;
+
+    DPRINTF("bonito_spciconf_writeb "TARGET_FMT_plx" val %x \n", addr, val);
+    pciaddr = bonito_sbridge_pciaddr(s, addr);
+
+    if (pciaddr == 0xffffffff) {
+        return;
+    }
+
+    /* set the pci address in s->config_reg */
+    s->pcihost->config_reg = (pciaddr) | (1u << 31);
+    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val & 0xff, 1);
+
+    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
+    status = pci_get_word(s->config + PCI_STATUS);
+    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
+    pci_set_word(s->config + PCI_STATUS, status);
+}
+
+static void bonito_spciconf_writew(void *opaque, target_phys_addr_t addr,
+                                   uint32_t val)
+{
+    PCIBonitoState *s = opaque;
+    uint32_t pciaddr;
+    uint16_t status;
+
+    DPRINTF("bonito_spciconf_writew "TARGET_FMT_plx" val %x \n", addr, val);
+    assert((addr&0x1)==0);
+
+    pciaddr = bonito_sbridge_pciaddr(s, addr);
+
+    if (pciaddr == 0xffffffff) {
+        return;
+    }
+
+    /* set the pci address in s->config_reg */
+    s->pcihost->config_reg = (pciaddr) | (1u << 31);
+    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val, 2);
+
+    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
+    status = pci_get_word(s->config + PCI_STATUS);
+    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
+    pci_set_word(s->config + PCI_STATUS, status);
+}
+
+static void bonito_spciconf_writel(void *opaque, target_phys_addr_t addr,
+                                   uint32_t val)
+{
+    PCIBonitoState *s = opaque;
+    uint32_t pciaddr;
+    uint16_t status;
+
+    DPRINTF("bonito_spciconf_writel "TARGET_FMT_plx" val %x \n", addr, val);
+    assert((addr&0x3)==0);
+
+    pciaddr = bonito_sbridge_pciaddr(s, addr);
+
+    if (pciaddr == 0xffffffff) {
+        return;
+    }
+
+    /* set the pci address in s->config_reg */
+    s->pcihost->config_reg = (pciaddr) | (1u << 31);
+    pci_data_write(s->pcihost->bus, s->pcihost->config_reg, val, 4);
+
+    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
+    status = pci_get_word(s->config + PCI_STATUS);
+    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
+    pci_set_word(s->config + PCI_STATUS, status);
+}
+
+static uint32_t bonito_spciconf_readb(void *opaque, target_phys_addr_t addr)
+{
+    PCIBonitoState *s = opaque;
+    uint32_t pciaddr;
+    uint16_t status;
+
+    DPRINTF("bonito_spciconf_readb "TARGET_FMT_plx"  \n", addr);
+    pciaddr = bonito_sbridge_pciaddr(s, addr);
+
+    if (pciaddr == 0xffffffff) {
+        return 0xff;
+    }
+
+    /* set the pci address in s->config_reg */
+    s->pcihost->config_reg = (pciaddr) | (1u << 31);
+
+    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
+    status = pci_get_word(s->config + PCI_STATUS);
+    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
+    pci_set_word(s->config + PCI_STATUS, status);
+
+    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 1);
+}
+
+static uint32_t bonito_spciconf_readw(void *opaque, target_phys_addr_t addr)
+{
+    PCIBonitoState *s = opaque;
+    uint32_t pciaddr;
+    uint16_t status;
+
+    DPRINTF("bonito_spciconf_readw "TARGET_FMT_plx"  \n", addr);
+    assert((addr&0x1)==0);
+
+    pciaddr = bonito_sbridge_pciaddr(s, addr);
+
+    if (pciaddr == 0xffffffff) {
+        return 0xffff;
+    }
+
+    /* set the pci address in s->config_reg */
+    s->pcihost->config_reg = (pciaddr) | (1u << 31);
+
+    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
+    status = pci_get_word(s->config + PCI_STATUS);
+    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
+    pci_set_word(s->config + PCI_STATUS, status);
+
+    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 2);
+}
+
+static uint32_t bonito_spciconf_readl(void *opaque, target_phys_addr_t addr)
+{
+    PCIBonitoState *s = opaque;
+    uint32_t pciaddr;
+    uint16_t status;
+
+    DPRINTF("bonito_spciconf_readl "TARGET_FMT_plx"  \n", addr);
+    assert((addr&0x3) == 0);
+
+    pciaddr = bonito_sbridge_pciaddr(s, addr);
+
+    if (pciaddr == 0xffffffff) {
+        return 0xffffffff;
+    }
+
+    /* set the pci address in s->config_reg */
+    s->pcihost->config_reg = (pciaddr) | (1u << 31);
+
+    /* clear PCI_STATUS_REC_MASTER_ABORT and PCI_STATUS_REC_TARGET_ABORT */
+    status = pci_get_word(s->config + PCI_STATUS);
+    status &= ~(PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_REC_TARGET_ABORT);
+    pci_set_word(s->config + PCI_STATUS, status);
+
+    return pci_data_read(s->pcihost->bus, s->pcihost->config_reg, 4);
+}
+
+/* south bridge PCI configure space. 0x1fe8 0000 - 0x1fef ffff */
+static CPUWriteMemoryFunc * const bonito_spciconf_write[] = {
+    bonito_spciconf_writeb,
+    bonito_spciconf_writew,
+    bonito_spciconf_writel,
+};
+
+static CPUReadMemoryFunc * const bonito_spciconf_read[] = {
+    bonito_spciconf_readb,
+    bonito_spciconf_readw,
+    bonito_spciconf_readl,
+};
+
+#define BONITO_IRQ_BASE 32
+
+static void pci_bonito_set_irq(void *opaque, int irq_num, int level)
+{
+    qemu_irq pic = opaque;
+    int internal_irq = irq_num - BONITO_IRQ_BASE;
+
+    if (bonito_state->regs[BONITO_INTEDGE] & (1<<internal_irq)) {
+        qemu_irq_pulse(pic);
+    } else {   /* level triggered */
+        if (bonito_state->regs[BONITO_INTPOL] & (1<<internal_irq)) {
+            qemu_irq_raise(pic);
+        } else {
+            qemu_irq_lower(pic);
+        }
+    }
+}
+
+/* map the original irq (0~3) to bonito irq (16~47, but 16~31 are unused) */
+static int pci_bonito_map_irq(PCIDevice * pci_dev, int irq_num)
+{
+    int slot;
+
+    slot = (pci_dev->devfn >> 3);
+
+    switch (slot) {
+    case 5:   /* FULONG2E_VIA_SLOT, SouthBridge, IDE, USB, ACPI, AC97, MC97 */
+        return irq_num % 4 + BONITO_IRQ_BASE;
+    case 6:   /* FULONG2E_ATI_SLOT, VGA */
+        return 4 + BONITO_IRQ_BASE;
+    case 7:   /* FULONG2E_RTL_SLOT, RTL8139 */
+        return 5 + BONITO_IRQ_BASE;
+    case 8 ... 12: /* PCI slot 1 to 4 */
+        return (slot - 8 + irq_num) + 6 + BONITO_IRQ_BASE;
+    default:  /* Unknown device, don't do any translation */
+        return irq_num;
+    }
+}
+
+static void bonito_reset(void *opaque)
+{
+    PCIBonitoState *s = opaque;
+
+    /* set the default value of north bridge pci config */
+    s->config[0x04] = 0x00;
+    s->config[0x05] = 0x00;
+    s->config[0x06] = 0x00;
+    s->config[0x07] = 0x00;
+
+    s->config[0x08] = 0x01;
+    s->config[0x09] = 0x00;
+    s->config[0x0a] = 0x00;
+    s->config[0x0b] = 0x06;
+
+    s->config[0x2c] = 0x00;
+    s->config[0x2d] = 0x00;
+    s->config[0x2e] = 0x00;
+    s->config[0x2f] = 0x00;
+
+    s->config[0x3c] = 0x00;
+    s->config[0x3d] = 0x01;
+    s->config[0x3e] = 0x3c;
+    s->config[0x3f] = 0x00;
+
+    /* set the default value of north bridge registers */
+
+    s->regs[BONITO_BONPONCFG] = 0xc40;
+    s->regs[BONITO_BONGENCFG] = 0x1384;
+    s->regs[BONITO_IODEVCFG] = 0x2bff8010;
+    s->regs[BONITO_SDCFG] = 0x255e0091;
+
+    s->regs[BONITO_GPIODATA] = 0x1ff;
+    s->regs[BONITO_GPIOIE] = 0x1ff;
+    s->regs[BONITO_DQCFG] = 0x8;
+    s->regs[BONITO_MEMSIZE] = 0x10000000;
+    s->regs[BONITO_PCIMAP] = 0x6140;
+}
+
+static const VMStateDescription vmstate_bonito = {
+    .name = "Bonito",
+    .version_id = 1,
+    .minimum_version_id = 1,
+    .minimum_version_id_old = 1,
+    .fields      = (VMStateField []) {
+        VMSTATE_PCI_DEVICE(dev, PCIBonitoState),
+        VMSTATE_END_OF_LIST()
+    }
+};
+
+static int bonito_pcihost_initfn(SysBusDevice *dev)
+{
+    return 0;
+}
+
+static int bonito_initfn(PCIDevice *dev)
+{
+    PCIBonitoState *s = DO_UPCAST(PCIBonitoState, dev, dev);
+
+    /* Bonito North Bridge, built on FPGA, VENDOR_ID/DEVICE_ID are "undefined" */
+    pci_config_set_vendor_id(dev->config, 0xdf53);
+    pci_config_set_device_id(dev->config, 0x00d5);
+    pci_config_set_class(dev->config, PCI_CLASS_BRIDGE_HOST);
+
+    /* set the north bridge register mapping */
+    s->bonito_reg_handle = cpu_register_io_memory(bonito_read, bonito_write, s);
+    s->bonito_reg_start = BONITO_INTERNAL_REG_BASE;
+    s->bonito_reg_length = BONITO_INTERNAL_REG_SIZE;
+    cpu_register_physical_memory(s->bonito_reg_start, s->bonito_reg_length,
+                                 s->bonito_reg_handle);
+
+    /* set the north bridge pci configure  mapping */
+    s->bonito_pciconf_handle = cpu_register_io_memory(bonito_pciconf_read,
+                                                      bonito_pciconf_write, s);
+    s->bonito_pciconf_start = BONITO_PCICONFIG_BASE;
+    s->bonito_pciconf_length = BONITO_PCICONFIG_SIZE;
+    cpu_register_physical_memory(s->bonito_pciconf_start, s->bonito_pciconf_length,
+                                 s->bonito_pciconf_handle);
+
+    /* set the south bridge pci configure  mapping */
+    s->bonito_spciconf_handle = cpu_register_io_memory(bonito_spciconf_read,
+                                                       bonito_spciconf_write, s);
+    s->bonito_spciconf_start = BONITO_SPCICONFIG_BASE;
+    s->bonito_spciconf_length = BONITO_SPCICONFIG_SIZE;
+    cpu_register_physical_memory(s->bonito_spciconf_start, s->bonito_spciconf_length,
+                                 s->bonito_spciconf_handle);
+
+    /* add pci local io mapping */
+    s->bonito_localio_handle = cpu_register_io_memory(bonito_localio_read,
+                                                      bonito_localio_write, s);
+    s->bonito_localio_start = BONITO_DEV_BASE;
+    s->bonito_localio_length = BONITO_DEV_SIZE;
+    cpu_register_physical_memory(s->bonito_localio_start, s->bonito_localio_length,
+                                 s->bonito_localio_handle);
+
+    s->bonito_ldma_handle = cpu_register_io_memory(bonito_ldma_read,
+                                                   bonito_ldma_write, s);
+    s->bonito_ldma_start = 0xbfe00200;
+    s->bonito_ldma_length = 0x100;
+    cpu_register_physical_memory(s->bonito_ldma_start, s->bonito_ldma_length,
+                                 s->bonito_ldma_handle);
+
+    s->bonito_cop_handle = cpu_register_io_memory(bonito_cop_read,
+                                                  bonito_cop_write, s);
+    s->bonito_cop_start = 0xbfe00300;
+    s->bonito_cop_length = 0x100;
+    cpu_register_physical_memory(s->bonito_cop_start, s->bonito_cop_length,
+                                 s->bonito_cop_handle);
+
+    /* Map PCI IO Space  0x1fd0 0000 - 0x1fd1 0000 */
+    s->bonito_pciio_start = BONITO_PCIIO_BASE;
+    s->bonito_pciio_length = BONITO_PCIIO_SIZE;
+    isa_mem_base = s->bonito_pciio_start;
+    isa_mmio_init(s->bonito_pciio_start, s->bonito_pciio_length, 0);
+
+    qemu_register_reset(bonito_reset, s);
+
+    return 0;
+}
+
+PCIBus *bonito_init(qemu_irq pic)
+{
+    DeviceState *dev;
+    PCIBus *b;
+    BonitoState *pcihost;
+    PCIBonitoState *s;
+    PCIDevice *d;
+
+    dev = qdev_create(NULL, "Bonito-pcihost");
+    pcihost = FROM_SYSBUS(BonitoState, sysbus_from_qdev(dev));
+    b = pci_register_bus(&pcihost->busdev.qdev, NULL, pci_bonito_set_irq,
+                         pci_bonito_map_irq, pic, 0x28, 32);
+    pcihost->bus = b;
+    qdev_init_nofail(dev);
+    pci_bus_set_mem_base(pcihost->bus, 0x10000000);
+
+    d = pci_create_simple(b, 0, "Bonito");
+    s = DO_UPCAST(PCIBonitoState, dev, d);
+    s->pcihost = pcihost;
+    bonito_state = s;
+
+    return b;
+}
+
+static PCIDeviceInfo bonito_info = {
+    .qdev.name    = "Bonito",
+    .qdev.desc    = "Host bridge",
+    .qdev.size    = sizeof(PCIBonitoState),
+    .qdev.vmsd    = &vmstate_bonito,
+    .qdev.no_user = 1,
+    .init         = bonito_initfn,
+};
+
+static SysBusDeviceInfo bonito_pcihost_info = {
+    .init         = bonito_pcihost_initfn,
+    .qdev.name    = "Bonito-pcihost",
+    .qdev.size    = sizeof(BonitoState),
+    .qdev.no_user = 1,
+};
+
+static void bonito_register(void)
+{
+    sysbus_register_withprop(&bonito_pcihost_info);
+    pci_qdev_register(&bonito_info);
+}
+device_init(bonito_register);
diff --git a/hw/mips.h b/hw/mips.h
index 30791a8..cd4fdf8 100644
--- a/hw/mips.h
+++ b/hw/mips.h
@@ -5,6 +5,9 @@ 
 /* gt64xxx.c */
 PCIBus *pci_gt64120_init(qemu_irq *pic);
 
+/* bonito.c */
+PCIBus *bonito_init(qemu_irq pic);
+
 /* ds1225y.c */
 void *ds1225y_init(target_phys_addr_t mem_base, const char *filename);
 void ds1225y_set_protection(void *opaque, int protection);