| Message ID | 1444754783-26975-4-git-send-email-vivien.didelot@savoirfairelinux.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 13/10/15 09:46, Vivien Didelot wrote: > There is no need to write the MAC address before every Get Next > operation, since ATU MAC registers are not cleared between calls. > > Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext > so future code could call ATU Get Next multiple times and save a few > register access. Missing SoB tag here.
On Oct. Tuesday 13 (42) 10:35 AM, Florian Fainelli wrote: > On 13/10/15 09:46, Vivien Didelot wrote: > > There is no need to write the MAC address before every Get Next > > operation, since ATU MAC registers are not cleared between calls. > > > > Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext > > so future code could call ATU Get Next multiple times and save a few > > register access. > > Missing SoB tag here. Damn, good catch. Can I add it in reply to the patch, or should I send a v3? Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 13/10/15 11:11, Vivien Didelot wrote: > On Oct. Tuesday 13 (42) 10:35 AM, Florian Fainelli wrote: >> On 13/10/15 09:46, Vivien Didelot wrote: >>> There is no need to write the MAC address before every Get Next >>> operation, since ATU MAC registers are not cleared between calls. >>> >>> Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext >>> so future code could call ATU Get Next multiple times and save a few >>> register access. >> >> Missing SoB tag here. > > Damn, good catch. Can I add it in reply to the patch, or should I send a > v3? I am fairly positive patchwork should be able to pick it up, so replying to your patch might just do it fine.
On Oct. Tuesday 13 (42) 12:46 PM, Vivien Didelot wrote: > There is no need to write the MAC address before every Get Next > operation, since ATU MAC registers are not cleared between calls. > > Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext > so future code could call ATU Get Next multiple times and save a few > register access. Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c index 8c87b03..7b15b98 100644 --- a/drivers/net/dsa/mv88e6xxx.c +++ b/drivers/net/dsa/mv88e6xxx.c @@ -1751,7 +1751,6 @@ int mv88e6xxx_port_fdb_del(struct dsa_switch *ds, int port, } static int _mv88e6xxx_atu_getnext(struct dsa_switch *ds, u16 fid, - const unsigned char *addr, struct mv88e6xxx_atu_entry *entry) { struct mv88e6xxx_atu_entry next = { 0 }; @@ -1763,10 +1762,6 @@ static int _mv88e6xxx_atu_getnext(struct dsa_switch *ds, u16 fid, if (ret < 0) return ret; - ret = _mv88e6xxx_atu_mac_write(ds, addr); - if (ret < 0) - return ret; - ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, GLOBAL_ATU_FID, fid); if (ret < 0) return ret; @@ -1827,7 +1822,11 @@ int mv88e6xxx_port_fdb_getnext(struct dsa_switch *ds, int port, fid = vtu.fid; } - ret = _mv88e6xxx_atu_getnext(ds, fid, addr, &next); + ret = _mv88e6xxx_atu_mac_write(ds, addr); + if (ret < 0) + goto unlock; + + ret = _mv88e6xxx_atu_getnext(ds, fid, &next); if (ret < 0) goto unlock;