| Message ID | 1444735761-1510-1-git-send-email-B48286@freescale.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Scott Wood |
| Headers | show |
On Tue, 2015-10-13 at 19:29 +0800, Zhiqiang Hou wrote: > From: Harninder Rai <harninder.rai@freescale.com> > > Signed-off-by: Harninder Rai <harninder.rai@freescale.com> > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com> > Change-Id: I4355add4a92d1fcf514843aea5ecadd2e2517969 > Reviewed-on: http://git.am.freescale.net:8181/2454 > Reviewed-by: Zang Tiefei-R61911 <tie-fei.zang@freescale.com> > Reviewed-by: Kushwaha Prabhakar-B32579 <prabhakar@freescale.com> > Reviewed-by: Fleming Andrew-AFLEMING <AFLEMING@freescale.com> > Tested-by: Fleming Andrew-AFLEMING <AFLEMING@freescale.com> Get rid of the gerrit stuff. And where is your signoff? > diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi > b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi > index c723071..78c8f1c 100644 > --- a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi > +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi > @@ -40,6 +40,35 @@ > interrupts = <16 2 0 0 20 2 0 0>; > }; > > +/* controller at 0xa000 */ > +&pci0 { > + compatible = "fsl,bsc9132-pcie", "fsl,qoriq-pcie-v2.2"; > + device_type = "pci"; > + #size-cells = <2>; > + #address-cells = <3>; > + bus-range = <0 255>; > + clock-frequency = <33333333>; > + interrupts = <16 2 0 0>; This clock-frequency is not correct for PCIe. Just remove it. -Scott
> -----Original Message----- > From: Wood Scott-B07421 > Sent: 2015年10月15日 4:36 > To: Hou Zhiqiang-B48286 > Cc: linuxppc-dev@lists.ozlabs.org; galak@kernel.crashing.org; > benh@kernel.crashing.org; paulus@samba.org; mpe@ellerman.id.au; > devicetree@vger.kernel.org; robh+dt@kernel.org; pawel.moll@arm.com; > mark.rutland@arm.com; ijc+devicetree@hellion.org.uk; Rai Harninder-B01044; > Lian Minghuan-B31939; Hu Mingkai-B21284 > Subject: Re: [PATCH 1/2] powerpc/fsl: Add PCI node in device tree of > bsc9132qds > > On Tue, 2015-10-13 at 19:29 +0800, Zhiqiang Hou wrote: > > From: Harninder Rai <harninder.rai@freescale.com> > > > > Signed-off-by: Harninder Rai <harninder.rai@freescale.com> > > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com> > > Change-Id: I4355add4a92d1fcf514843aea5ecadd2e2517969 > > Reviewed-on: http://git.am.freescale.net:8181/2454 > > Reviewed-by: Zang Tiefei-R61911 <tie-fei.zang@freescale.com> > > Reviewed-by: Kushwaha Prabhakar-B32579 <prabhakar@freescale.com> > > Reviewed-by: Fleming Andrew-AFLEMING <AFLEMING@freescale.com> > > Tested-by: Fleming Andrew-AFLEMING <AFLEMING@freescale.com> > > Get rid of the gerrit stuff. And where is your signoff? > > > diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi > > b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi > > index c723071..78c8f1c 100644 > > --- a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi > > +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi > > @@ -40,6 +40,35 @@ > > interrupts = <16 2 0 0 20 2 0 0>; }; > > > > +/* controller at 0xa000 */ > > +&pci0 { > > + compatible = "fsl,bsc9132-pcie", "fsl,qoriq-pcie-v2.2"; > > + device_type = "pci"; > > + #size-cells = <2>; > > + #address-cells = <3>; > > + bus-range = <0 255>; > > + clock-frequency = <33333333>; > > + interrupts = <16 2 0 0>; > > This clock-frequency is not correct for PCIe. Just remove it. > Ok, thanks for your correction. Thanks, Zhiqiang
diff --git a/arch/powerpc/boot/dts/bsc9132qds.dts b/arch/powerpc/boot/dts/bsc9132qds.dts index 6cab106..940d719 100644 --- a/arch/powerpc/boot/dts/bsc9132qds.dts +++ b/arch/powerpc/boot/dts/bsc9132qds.dts @@ -29,6 +29,21 @@ soc: soc@ff700000 { ranges = <0x0 0x0 0xff700000 0x100000>; }; + + pci0: pcie@ff70a000 { + reg = <0 0xff70a000 0 0x1000>; + ranges = <0x2000000 0x0 0x90000000 0 0x90000000 0x0 0x20000000 + 0x1000000 0x0 0x00000000 0 0xc0010000 0x0 0x10000>; + pcie@0 { + ranges = <0x2000000 0x0 0x90000000 + 0x2000000 0x0 0x90000000 + 0x0 0x20000000 + + 0x1000000 0x0 0x0 + 0x1000000 0x0 0x0 + 0x0 0x100000>; + }; + }; }; /include/ "bsc9132qds.dtsi" diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi index c723071..78c8f1c 100644 --- a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi @@ -40,6 +40,35 @@ interrupts = <16 2 0 0 20 2 0 0>; }; +/* controller at 0xa000 */ +&pci0 { + compatible = "fsl,bsc9132-pcie", "fsl,qoriq-pcie-v2.2"; + device_type = "pci"; + #size-cells = <2>; + #address-cells = <3>; + bus-range = <0 255>; + clock-frequency = <33333333>; + interrupts = <16 2 0 0>; + + pcie@0 { + reg = <0 0 0 0 0>; + #interrupt-cells = <1>; + #size-cells = <2>; + #address-cells = <3>; + device_type = "pci"; + interrupts = <16 2 0 0>; + interrupt-map-mask = <0xf800 0 0 7>; + + interrupt-map = < + /* IDSEL 0x0 */ + 0000 0x0 0x0 0x1 &mpic 0x0 0x2 0x0 0x0 + 0000 0x0 0x0 0x2 &mpic 0x1 0x2 0x0 0x0 + 0000 0x0 0x0 0x3 &mpic 0x2 0x2 0x0 0x0 + 0000 0x0 0x0 0x4 &mpic 0x3 0x2 0x0 0x0 + >; + }; +}; + &soc { #address-cells = <1>; #size-cells = <1>; diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi index 301a9db..90f7949 100644 --- a/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-pre.dtsi @@ -45,6 +45,7 @@ serial0 = &serial0; ethernet0 = &enet0; ethernet1 = &enet1; + pci0 = &pci0; }; cpus {