From patchwork Wed May 19 07:24:02 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v3,02/12] vnc: explain why set_encodings loop is reversed From: Corentin Chary X-Patchwork-Id: 52955 Message-Id: <1274253852-16068-3-git-send-email-corentincj@iksaif.net> To: qemu-devel@nongnu.org Cc: Corentin Chary , Anthony Liguori , Alexander Graf , Adam Litke Date: Wed, 19 May 2010 09:24:02 +0200 Add a small comment to explain why we need to start from the end of the array to set the right prefered encoding. Signed-off-by: Corentin Chary --- vnc.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/vnc.c b/vnc.c index b1a3fdb..d0402b9 100644 --- a/vnc.c +++ b/vnc.c @@ -1599,6 +1599,11 @@ static void set_encodings(VncState *vs, int32_t *encodings, size_t n_encodings) vs->tight_quality = 9; vs->absolute = -1; + /* + * Start from the end because the encodings are sent in order of preference. + * This way the prefered encoding (first encoding defined in the array) + * will be set at the end of the loop. + */ for (i = n_encodings - 1; i >= 0; i--) { enc = encodings[i]; switch (enc) {