Patchwork [v2,10/10] vnc: update copyrights for vnc-encoding-tight.c

login
register
mail settings
Submitter Corentin Chary
Date May 18, 2010, 12:49 p.m.
Message ID <1274186986-26878-11-git-send-email-corentincj@iksaif.net>
Download mbox | patch
Permalink /patch/52878/
State New
Headers show

Comments

Corentin Chary - May 18, 2010, 12:49 p.m.
Add missing copyrights in vnc-encoding-tight.c, since the code is
mostly inspired from libvncserver/tight.c.

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 vnc-encoding-tight.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
Anthony Liguori - May 18, 2010, 1:37 p.m.
On 05/18/2010 07:49 AM, Corentin Chary wrote:
> Add missing copyrights in vnc-encoding-tight.c, since the code is
> mostly inspired from libvncserver/tight.c.
>
> Signed-off-by: Corentin Chary<corentincj@iksaif.net>
> ---
>   vnc-encoding-tight.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
> index b836569..0c661a9 100644
> --- a/vnc-encoding-tight.c
> +++ b/vnc-encoding-tight.c
> @@ -1,9 +1,14 @@
>   /*
>    * QEMU VNC display driver: tight encoding
>    *
> + * From libvncserver/tight.c
> + * Copyright (C) 1999 AT&T Laboratories Cambridge.  All Rights Reserved.
> + * Copyright (C) 2000, 2001 Const Kaplinsky.  All Rights Reserved.
> + *
>    * Copyright (C) 2006 Anthony Liguori<anthony@codemonkey.ws>
>    * Copyright (C) 2006 Fabrice Bellard
>    * Copyright (C) 2009 Red Hat, Inc
> + * Copyright (C) 2019 Corentin Chary<corentin.chary@gmail.com>
>    *
>    * Permission is hereby granted, free of charge, to any person obtaining a copy
>    * of this software and associated documentation files (the "Software"), to deal
>    

This should come earlier in the series and also needs to carry a LICENSE.

If it's truly under 'All Rights Reserved', then we cannot incorporate 
this code into QEMU.

Regards,

Anthony Liguori
Krumme, Chris - May 18, 2010, 1:47 p.m.
On 05/18/2010 08:37 AM, Anthony Liguori wrote:
> On 05/18/2010 07:49 AM, Corentin Chary wrote:
>> Add missing copyrights in vnc-encoding-tight.c, since the code is
>> mostly inspired from libvncserver/tight.c.
>>
>> Signed-off-by: Corentin Chary<corentincj@iksaif.net>
>> ---
>>   vnc-encoding-tight.c |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
>> index b836569..0c661a9 100644
>> --- a/vnc-encoding-tight.c
>> +++ b/vnc-encoding-tight.c
>> @@ -1,9 +1,14 @@
>>   /*
>>    * QEMU VNC display driver: tight encoding
>>    *
>> + * From libvncserver/tight.c
>> + * Copyright (C) 1999 AT&T Laboratories Cambridge.  All Rights 
>> Reserved.
>> + * Copyright (C) 2000, 2001 Const Kaplinsky.  All Rights Reserved.
>> + *
>>    * Copyright (C) 2006 Anthony Liguori<anthony@codemonkey.ws>
>>    * Copyright (C) 2006 Fabrice Bellard
>>    * Copyright (C) 2009 Red Hat, Inc
>> + * Copyright (C) 2019 Corentin Chary<corentin.chary@gmail.com>

Maybe the laws are different in our future. 9 years from now this whole 
IP issue may be resolved.  (or you may want to correct the year also.)

Thanks

Chris

>>    *
>>    * Permission is hereby granted, free of charge, to any person 
>> obtaining a copy
>>    * of this software and associated documentation files (the 
>> "Software"), to deal
>
> This should come earlier in the series and also needs to carry a LICENSE.
>
> If it's truly under 'All Rights Reserved', then we cannot incorporate 
> this code into QEMU.
>
> Regards,
>
> Anthony Liguori
>
Blue Swirl - May 18, 2010, 5:26 p.m.
On 5/18/10, Anthony Liguori <aliguori@linux.vnet.ibm.com> wrote:
> On 05/18/2010 07:49 AM, Corentin Chary wrote:
>
> > Add missing copyrights in vnc-encoding-tight.c, since the code is
> > mostly inspired from libvncserver/tight.c.
> >
> > Signed-off-by: Corentin Chary<corentincj@iksaif.net>
> > ---
> >  vnc-encoding-tight.c |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
> > index b836569..0c661a9 100644
> > --- a/vnc-encoding-tight.c
> > +++ b/vnc-encoding-tight.c
> > @@ -1,9 +1,14 @@
> >  /*
> >   * QEMU VNC display driver: tight encoding
> >   *
> > + * From libvncserver/tight.c
> > + * Copyright (C) 1999 AT&T Laboratories Cambridge.  All Rights Reserved.
> > + * Copyright (C) 2000, 2001 Const Kaplinsky.  All Rights Reserved.
> > + *
> >   * Copyright (C) 2006 Anthony Liguori<anthony@codemonkey.ws>
> >   * Copyright (C) 2006 Fabrice Bellard
> >   * Copyright (C) 2009 Red Hat, Inc
> > + * Copyright (C) 2019 Corentin
> Chary<corentin.chary@gmail.com>
> >   *
> >   * Permission is hereby granted, free of charge, to any person obtaining
> a copy
> >   * of this software and associated documentation files (the "Software"),
> to deal
> >
> >
>
>  This should come earlier in the series and also needs to carry a LICENSE.
>
>  If it's truly under 'All Rights Reserved', then we cannot incorporate this
> code into QEMU.

Yes we can. I made the same mistake earlier:
http://lists.gnu.org/archive/html/qemu-devel/2009-02/msg01105.html

http://en.wikipedia.org/wiki/All_rights_reserved

Patch

diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
index b836569..0c661a9 100644
--- a/vnc-encoding-tight.c
+++ b/vnc-encoding-tight.c
@@ -1,9 +1,14 @@ 
 /*
  * QEMU VNC display driver: tight encoding
  *
+ * From libvncserver/tight.c
+ * Copyright (C) 1999 AT&T Laboratories Cambridge.  All Rights Reserved.
+ * Copyright (C) 2000, 2001 Const Kaplinsky.  All Rights Reserved.
+ *
  * Copyright (C) 2006 Anthony Liguori <anthony@codemonkey.ws>
  * Copyright (C) 2006 Fabrice Bellard
  * Copyright (C) 2009 Red Hat, Inc
+ * Copyright (C) 2019 Corentin Chary <corentin.chary@gmail.com>
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal