Patchwork mtd-utils: Support 4096+64 page sizes.

login
register
mail settings
Submitter Enric Balletbò i Serra
Date May 18, 2010, 9:53 a.m.
Message ID <1274176439-22351-1-git-send-email-eballetbo@gmail.com>
Download mbox | patch
Permalink /patch/52858/
State Accepted
Commit 772f5e08faa9d2b5677aa6e01fce06860186a49f
Headers show

Comments

Enric Balletbò i Serra - May 18, 2010, 9:53 a.m.
From: Enric Balletbo i Serra <eballetbo@iseebcn.com>

Add support for oobsize 64 and writesize 4096 in nanddump & nandwrite.

Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
---
 nanddump.c  |    1 +
 nandwrite.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
Artem Bityutskiy - May 22, 2010, 5:30 a.m.
On Tue, 2010-05-18 at 11:53 +0200, Enric Balletbo i Serra wrote:
> +                       !(meminfo.oobsize == 64 && meminfo.writesize
> == 4096) &&

Are there flashes with the 4096 page / 64 spare combination? Could you
refer to one? May be any URL? I thought 4096 comes with 128.
Enric Balletbò i Serra - May 23, 2010, 5:39 p.m.
Hello,

2010/5/22 Artem Bityutskiy <dedekind1@gmail.com>:
> On Tue, 2010-05-18 at 11:53 +0200, Enric Balletbo i Serra wrote:
>> +                       !(meminfo.oobsize == 64 && meminfo.writesize
>> == 4096) &&
>
> Are there flashes with the 4096 page / 64 spare combination? Could you
> refer to one? May be any URL? I thought 4096 comes with 128.

Much to my regret I can't provide a URL because is not public. IGEP v2
board has a Onenand with two dice of 2048/64 spare combination but mtd
views 4096/64. The minimal write page is 4K (2K from first dice and 2K
from second dice).

Best regards,

Enric

>
> --
> Best Regards,
> Artem Bityutskiy (Артём Битюцкий)
>
>
Artem Bityutskiy - June 12, 2010, 11:43 a.m.
On Tue, 2010-05-18 at 11:53 +0200, Enric Balletbo i Serra wrote:
> From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
> 
> Add support for oobsize 64 and writesize 4096 in nanddump & nandwrite.
> 
> Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
> ---
>  nanddump.c  |    1 +
>  nandwrite.c |    1 +

Pushed to mtd-utils.git, thank you!

Patch

diff --git a/nanddump.c b/nanddump.c
index ae0e425..e44ab36 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -212,6 +212,7 @@  int main(int argc, char * const argv[])
 	if (!(meminfo.oobsize == 224 && meminfo.writesize == 4096) &&
 			!(meminfo.oobsize == 218 && meminfo.writesize == 4096) &&
 			!(meminfo.oobsize == 128 && meminfo.writesize == 4096) &&
+			!(meminfo.oobsize == 64 && meminfo.writesize == 4096) &&
 			!(meminfo.oobsize == 64 && meminfo.writesize == 2048) &&
 			!(meminfo.oobsize == 32 && meminfo.writesize == 1024) &&
 			!(meminfo.oobsize == 16 && meminfo.writesize == 512) &&
diff --git a/nandwrite.c b/nandwrite.c
index b77edd6..bd45879 100644
--- a/nandwrite.c
+++ b/nandwrite.c
@@ -294,6 +294,7 @@  int main(int argc, char * const argv[])
 	if (!(meminfo.oobsize == 16 && meminfo.writesize == 512) &&
 			!(meminfo.oobsize == 8 && meminfo.writesize == 256) &&
 			!(meminfo.oobsize == 64 && meminfo.writesize == 2048) &&
+			!(meminfo.oobsize == 64 && meminfo.writesize == 4096) &&
 			!(meminfo.oobsize == 128 && meminfo.writesize == 4096)) {
 		fprintf(stderr, "Unknown flash (not normal NAND)\n");
 		close(fd);