diff mbox

[U-Boot,3/4] x86: fsp: Make hob command a sub-command to fsp

Message ID 1444466879-24281-3-git-send-email-bmeng.cn@gmail.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Bin Meng Oct. 10, 2015, 8:47 a.m. UTC 
Introduce a new fsp command and make the existing hob command a
sub-command to fsp for future extension. Also move cmd_hob.c to
the dedicated fsp sub-directory in arch/x86/lib.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 arch/x86/lib/Makefile                     |  1 -
 arch/x86/lib/fsp/Makefile                 |  1 +
 arch/x86/lib/{cmd_hob.c => fsp/cmd_fsp.c} | 33 +++++++++++++++++++++++++------
 doc/README.x86                            |  5 ++---
 4 files changed, 30 insertions(+), 10 deletions(-)
 rename arch/x86/lib/{cmd_hob.c => fsp/cmd_fsp.c} (65%)

Comments

Simon Glass Oct. 18, 2015, 8:26 p.m. UTC | #1 
On 10 October 2015 at 02:47, Bin Meng <bmeng.cn@gmail.com> wrote:
> Introduce a new fsp command and make the existing hob command a
> sub-command to fsp for future extension. Also move cmd_hob.c to
> the dedicated fsp sub-directory in arch/x86/lib.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  arch/x86/lib/Makefile                     |  1 -
>  arch/x86/lib/fsp/Makefile                 |  1 +
>  arch/x86/lib/{cmd_hob.c => fsp/cmd_fsp.c} | 33 +++++++++++++++++++++++++------
>  doc/README.x86                            |  5 ++---
>  4 files changed, 30 insertions(+), 10 deletions(-)
>  rename arch/x86/lib/{cmd_hob.c => fsp/cmd_fsp.c} (65%)

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass Oct. 18, 2015, 9:38 p.m. UTC | #2 
On 18 October 2015 at 14:26, Simon Glass <sjg@chromium.org> wrote:
> On 10 October 2015 at 02:47, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Introduce a new fsp command and make the existing hob command a
>> sub-command to fsp for future extension. Also move cmd_hob.c to
>> the dedicated fsp sub-directory in arch/x86/lib.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>>  arch/x86/lib/Makefile                     |  1 -
>>  arch/x86/lib/fsp/Makefile                 |  1 +
>>  arch/x86/lib/{cmd_hob.c => fsp/cmd_fsp.c} | 33 +++++++++++++++++++++++++------
>>  doc/README.x86                            |  5 ++---
>>  4 files changed, 30 insertions(+), 10 deletions(-)
>>  rename arch/x86/lib/{cmd_hob.c => fsp/cmd_fsp.c} (65%)
>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-x86, thanks!
diff mbox

Patch

diff --git a/arch/x86/lib/Makefile b/arch/x86/lib/Makefile
index 4ac9956..fa95944 100644
--- a/arch/x86/lib/Makefile
+++ b/arch/x86/lib/Makefile
@@ -10,7 +10,6 @@  obj-y += bios_asm.o
 obj-y += bios_interrupts.o
 obj-$(CONFIG_CMD_BOOTM) += bootm.o
 obj-y	+= cmd_boot.o
-obj-$(CONFIG_HAVE_FSP) += cmd_hob.o
 obj-$(CONFIG_EFI) += efi/
 obj-y	+= e820.o
 obj-y	+= gcc.o
diff --git a/arch/x86/lib/fsp/Makefile b/arch/x86/lib/fsp/Makefile
index 5b12c12..3ea4880 100644
--- a/arch/x86/lib/fsp/Makefile
+++ b/arch/x86/lib/fsp/Makefile
@@ -4,6 +4,7 @@ 
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
+obj-y += cmd_fsp.o
 obj-y += fsp_car.o
 obj-y += fsp_common.o
 obj-y += fsp_dram.o
diff --git a/arch/x86/lib/cmd_hob.c b/arch/x86/lib/fsp/cmd_fsp.c
similarity index 65%
rename from arch/x86/lib/cmd_hob.c
rename to arch/x86/lib/fsp/cmd_fsp.c
index 4a29aee..b0b1875 100644
--- a/arch/x86/lib/cmd_hob.c
+++ b/arch/x86/lib/fsp/cmd_fsp.c
@@ -1,12 +1,11 @@ 
 /*
- * Copyright (C) 2014, Bin Meng <bmeng.cn@gmail.com>
+ * Copyright (C) 2014-2015, Bin Meng <bmeng.cn@gmail.com>
  *
  * SPDX-License-Identifier:	GPL-2.0+
  */
 
 #include <common.h>
 #include <command.h>
-#include <linux/compiler.h>
 #include <asm/fsp/fsp_support.h>
 
 DECLARE_GLOBAL_DATA_PTR;
@@ -26,7 +25,7 @@  static char *hob_type[] = {
 	"Capsule",
 };
 
-int do_hob(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+static int do_hob(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 	const struct hob_header *hdr;
 	uint type;
@@ -74,8 +73,30 @@  int do_hob(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	return 0;
 }
 
+static cmd_tbl_t fsp_commands[] = {
+	U_BOOT_CMD_MKENT(hob, 0, 1, do_hob, "", ""),
+};
+
+static int do_fsp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+{
+	cmd_tbl_t *fsp_cmd;
+	int ret;
+
+	if (argc < 2)
+		return CMD_RET_USAGE;
+	fsp_cmd = find_cmd_tbl(argv[1], fsp_commands, ARRAY_SIZE(fsp_commands));
+	argc -= 2;
+	argv += 2;
+	if (!fsp_cmd || argc > fsp_cmd->maxargs)
+		return CMD_RET_USAGE;
+
+	ret = fsp_cmd->cmd(fsp_cmd, flag, argc, argv);
+
+	return cmd_process_error(fsp_cmd, ret);
+}
+
 U_BOOT_CMD(
-	hob,	1,	1,	do_hob,
-	"print Firmware Support Package (FSP) Hand-Off Block information",
-	""
+	fsp,	2,	1,	do_fsp,
+	"Show Intel Firmware Support Package (FSP) related information",
+	"hob - Print FSP Hand-Off Block (HOB) information"
 );
diff --git a/doc/README.x86 b/doc/README.x86
index 18fed82..a9d0e0f 100644
--- a/doc/README.x86
+++ b/doc/README.x86
@@ -332,9 +332,8 @@  In keeping with the U-Boot philosophy of providing functions to check and
 adjust internal settings, there are several x86-specific commands that may be
 useful:
 
-hob  - Display information about Firmware Support Package (FSP) Hand-off
-	 Block. This is only available on platforms which use FSP, mostly
-	 Atom.
+fsp  - Display information about Intel Firmware Support Package (FSP).
+	 This is only available on platforms which use FSP, mostly Atom.
 iod  - Display I/O memory
 iow  - Write I/O memory
 mtrr - List and set the Memory Type Range Registers (MTRR). These are used to