Patchwork netfilter: fix description of expected checkentry return code on xt_target

login
register
mail settings
Submitter Luciano Coelho
Date May 17, 2010, 8 p.m.
Message ID <1274126430-13744-1-git-send-email-luciano.coelho@nokia.com>
Download mbox | patch
Permalink /patch/52811/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Luciano Coelho - May 17, 2010, 8 p.m.
The text describing the return codes that are expected on calls to
checkentry() was incorrect.  Instead of returning true or false, or an error
code, it should return 0 or an error code.

Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
---
 include/linux/netfilter/x_tables.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Patrick McHardy - May 20, 2010, 1:59 p.m.
Luciano Coelho wrote:
> The text describing the return codes that are expected on calls to
> checkentry() was incorrect.  Instead of returning true or false, or an error
> code, it should return 0 or an error code.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h
index c2ee5d8..c00cc0c 100644
--- a/include/linux/netfilter/x_tables.h
+++ b/include/linux/netfilter/x_tables.h
@@ -333,7 +333,7 @@  struct xt_target {
 	/* Called when user tries to insert an entry of this type:
            hook_mask is a bitmask of hooks from which it can be
            called. */
-	/* Should return true or false, or an error code (-Exxxx). */
+	/* Should return 0 on success or an error code otherwise (-Exxxx). */
 	int (*checkentry)(const struct xt_tgchk_param *);
 
 	/* Called when entry of this type deleted. */