From patchwork Mon May 17 12:20:21 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Antipov X-Patchwork-Id: 52790 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 484F1B7DA7 for ; Mon, 17 May 2010 22:28:59 +1000 (EST) Received: from localhost ([127.0.0.1]:39301 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ODzRI-0002ay-KB for incoming@patchwork.ozlabs.org; Mon, 17 May 2010 08:28:56 -0400 Received: from [140.186.70.92] (port=42201 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ODzPu-0001uF-QO for qemu-devel@nongnu.org; Mon, 17 May 2010 08:27:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ODzPs-0000Xz-0F for qemu-devel@nongnu.org; Mon, 17 May 2010 08:27:30 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:48438) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ODzPr-0000X3-R6 for qemu-devel@nongnu.org; Mon, 17 May 2010 08:27:27 -0400 Received: by wyb39 with SMTP id 39so469291wyb.4 for ; Mon, 17 May 2010 05:27:23 -0700 (PDT) Received: by 10.227.152.69 with SMTP id f5mr4777966wbw.73.1274099243190; Mon, 17 May 2010 05:27:23 -0700 (PDT) Received: from antipov.dev.rtsoft.ru ([213.79.90.226]) by mx.google.com with ESMTPS id h22sm17091692wbh.15.2010.05.17.05.27.21 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 17 May 2010 05:27:22 -0700 (PDT) Message-ID: <4BF13485.8000903@mvista.com> Date: Mon, 17 May 2010 16:20:21 +0400 From: Dmitry Antipov User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 MIME-Version: 1.0 To: qemu-devel Subject: [Qemu-devel] [PATCH] MIPS DINSU X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Hello, shouldn't it be in that way? Dmitry Signed-off-by: line? --- qemu-0.12.4/target-mips/translate.c 2010-05-17 16:12:58.048661610 +0400 +++ qemu-0.12.4/target-mips/translate.c 2010-05-17 16:13:12.281656754 +0400 @@ -2761,7 +2761,7 @@ case OPC_DINSU: if (lsb > msb) goto fail; - mask = ((1ULL << (msb - lsb + 1)) - 1) << lsb; + mask = ((1ULL << (msb - lsb + 1)) - 1) << (lsb + 32); gen_load_gpr(t0, rt); tcg_gen_andi_tl(t0, t0, ~mask); tcg_gen_shli_tl(t1, t1, lsb + 32);