From patchwork Mon May 17 12:20:21 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: MIPS DINSU Date: Mon, 17 May 2010 02:20:21 -0000 From: Dmitry Antipov X-Patchwork-Id: 52790 Message-Id: <4BF13485.8000903@mvista.com> To: qemu-devel Hello, shouldn't it be in that way? Dmitry Signed-off-by: line? --- qemu-0.12.4/target-mips/translate.c 2010-05-17 16:12:58.048661610 +0400 +++ qemu-0.12.4/target-mips/translate.c 2010-05-17 16:13:12.281656754 +0400 @@ -2761,7 +2761,7 @@ case OPC_DINSU: if (lsb > msb) goto fail; - mask = ((1ULL << (msb - lsb + 1)) - 1) << lsb; + mask = ((1ULL << (msb - lsb + 1)) - 1) << (lsb + 32); gen_load_gpr(t0, rt); tcg_gen_andi_tl(t0, t0, ~mask); tcg_gen_shli_tl(t1, t1, lsb + 32);