diff mbox

[PULL,01/19] Add .dir-locals.el file to configure emacs coding style

Message ID 91288a58a550be4dc80628456d5e1d2e91424827.1444323071.git.mjt@msgid.tls.msk.ru
State New
Headers show

Commit Message

Michael Tokarev Oct. 8, 2015, 4:52 p.m. UTC
From: "Daniel P. Berrange" <berrange@redhat.com>

Some default emacs setups indent by 2 spaces and uses tabs
which is counter to the QEMU coding style rules. Adding a
.dir-locals.el file in the top level of the GIT repo will
inform emacs about the QEMU coding style, and so assist
contributors in avoiding common style mistakes before
they submit patches.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 .dir-locals.el | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 .dir-locals.el

Comments

Marc-André Lureau Oct. 9, 2015, 12:25 p.m. UTC | #1
Hi

Similar to this file, I proposed a clang-format file. I also use
emacs, but clang-format is way better at dealing with reformating,
especially on a given region without touching the rest:

https://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg01278.html

On Thu, Oct 8, 2015 at 6:52 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
> From: "Daniel P. Berrange" <berrange@redhat.com>
>
> Some default emacs setups indent by 2 spaces and uses tabs
> which is counter to the QEMU coding style rules. Adding a
> .dir-locals.el file in the top level of the GIT repo will
> inform emacs about the QEMU coding style, and so assist
> contributors in avoiding common style mistakes before
> they submit patches.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  .dir-locals.el | 2 ++
>  1 file changed, 2 insertions(+)
>  create mode 100644 .dir-locals.el
>
> diff --git a/.dir-locals.el b/.dir-locals.el
> new file mode 100644
> index 0000000..3ac0cfc
> --- /dev/null
> +++ b/.dir-locals.el
> @@ -0,0 +1,2 @@
> +((c-mode . ((c-file-style . "stroustrup")
> +           (indent-tabs-mode . nil))))
> --
> 2.1.4
>
>
diff mbox

Patch

diff --git a/.dir-locals.el b/.dir-locals.el
new file mode 100644
index 0000000..3ac0cfc
--- /dev/null
+++ b/.dir-locals.el
@@ -0,0 +1,2 @@ 
+((c-mode . ((c-file-style . "stroustrup")
+	    (indent-tabs-mode . nil))))