Patchwork [2/3] cifs: don't update uniqueid in cifs_fattr_to_inode

login
register
mail settings
Submitter Jeff Layton
Date May 17, 2010, 11:18 a.m.
Message ID <1274095138-3386-3-git-send-email-jlayton@redhat.com>
Download mbox | patch
Permalink /patch/52786/
State New
Headers show

Comments

Jeff Layton - May 17, 2010, 11:18 a.m.
We use this value to find an inode within the hash bucket, so we can't
change this without re-hashing the inode. For now, treat this value
as immutable.

Eventually, we should probably use an inode number change on a path
based operation to indicate that the lookup cache is invalid, but that's
a bit more code to deal with.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 fs/cifs/inode.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Patch

diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index f52161a..ae9a4cf 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -137,7 +137,6 @@  cifs_fattr_to_inode(struct inode *inode, struct cifs_fattr *fattr)
 		inode->i_mode = fattr->cf_mode;
 
 	cifs_i->cifsAttrs = fattr->cf_cifsattrs;
-	cifs_i->uniqueid = fattr->cf_uniqueid;
 
 	if (fattr->cf_flags & CIFS_FATTR_NEED_REVAL)
 		cifs_i->time = 0;