Patchwork [34/37] drivers/mtd: Use kmemdup

login
register
mail settings
Submitter Julia Lawall
Date May 15, 2010, 9:23 p.m.
Message ID <Pine.LNX.4.64.1005152323150.21345@ask.diku.dk>
Download mbox | patch
Permalink /patch/52737/
State Accepted
Commit d80f2666b5373f195deae57c9f33a5abb8053d37
Headers show

Comments

Julia Lawall - May 15, 2010, 9:23 p.m.
From: Julia Lawall <julia@diku.dk>

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/mtd/mtdconcat.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch

diff -u -p a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c
--- a/drivers/mtd/mtdconcat.c
+++ b/drivers/mtd/mtdconcat.c
@@ -183,10 +183,9 @@  concat_writev(struct mtd_info *mtd, cons
 	}
 
 	/* make a copy of vecs */
-	vecs_copy = kmalloc(sizeof(struct kvec) * count, GFP_KERNEL);
+	vecs_copy = kmemdup(vecs, sizeof(struct kvec) * count, GFP_KERNEL);
 	if (!vecs_copy)
 		return -ENOMEM;
-	memcpy(vecs_copy, vecs, sizeof(struct kvec) * count);
 
 	entry_low = 0;
 	for (i = 0; i < concat->num_subdev; i++) {