| Message ID | 1444231059-14830-1-git-send-email-dsa@cumulusnetworks.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Oct 7, 2015 at 11:17 AM, David Ahern <dsa@cumulusnetworks.com> wrote: > Currently, all ipv6 addresses are flushed when the interface is configured > down, including global, static addresses: : > > Add a new sysctl to make this behavior optional. The new setting defaults to > flush all addresses to maintain backwards compatibility. When the setting is > reset global addresses with no expire times are not flushed: does src addr selection also need to be modified to know if/when it can/cannot use this static address as a source addr? Or does the TENTATIVE flag make it Do The Right Thing per rfc 3484? --Sowmini -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/7/15 9:43 AM, Sowmini Varadhan wrote: > On Wed, Oct 7, 2015 at 11:17 AM, David Ahern <dsa@cumulusnetworks.com> wrote: >> Currently, all ipv6 addresses are flushed when the interface is configured >> down, including global, static addresses: > : >> >> Add a new sysctl to make this behavior optional. The new setting defaults to >> flush all addresses to maintain backwards compatibility. When the setting is >> reset global addresses with no expire times are not flushed: > > does src addr selection also need to be modified to know if/when it can/cannot > use this static address as a source addr? Or does the TENTATIVE flag > make it Do The Right Thing per rfc 3484? > When the device is set 'down' (admin state) all routes (including cached ones) for the device are cleared so there should not be any way to select the source address that is saved. i.e, ipv6_dev_get_saddr() should not get invoked for the device. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi David, David Ahern <dsa@cumulusnetworks.com> writes: > Currently, all ipv6 addresses are flushed when the interface is configured > down, including global, static addresses: > > $ ip -6 addr add dev eth1 2000:11:1:1::1/64 > $ ip addr show dev eth1 > 3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000 > link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff > inet6 2000:11:1:1::1/64 scope global tentative > valid_lft forever preferred_lft forever > $ ip link set dev eth1 up > $ ip link set dev eth1 down > $ ip addr show dev eth1 > 3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000 > link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff > > Add a new sysctl to make this behavior optional. The new setting defaults to > flush all addresses to maintain backwards compatibility. When the setting is > reset global addresses with no expire times are not flushed: > > $ echo 0 > /proc/sys/net/ipv6/conf/eth1/flush_addr_on_down > $ ip -6 addr add dev eth1 2000:11:1:1::1/64 > $ ip addr show dev eth1 > 3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000 > link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff > inet6 2000:11:1:1::1/64 scope global tentative > valid_lft forever preferred_lft forever > $ ip link set dev eth1 up > $ ip link set dev eth1 down > $ ip addr show dev eth1 > 3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000 > link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff > inet6 2000:11:1:1::1/64 scope global > valid_lft forever preferred_lft forever > inet6 fe80::4:11ff:fe22:3301/64 scope link > valid_lft forever preferred_lft forever > > Signed-off-by: David Ahern <dsa@cumulusnetworks.com> > --- > It has been 8 months since the last version: > http://lists.openwall.net/netdev/2015/02/12/33 > > but wanted to revive it. This current version addresses the last round of > comments and verifies all routes are deleted and re-added correctly > > Nicolas: I ran 'ip monitor' on a link down and link up cycle and you can > see the neighbor and route deletes on a down and routes added on > an up. > > v4: > - rebased to top of tree > > - updated to clear all routes on admin down and re-added on admin up > > - verified the route tables (main and local) on a link down have *no* > remnants of the configured, global address. On a link up all routes > are restored -- multicast, linklocal, local routes and connected. > > v3: > - fix local variable ordering and comment style per Dave's comment > - consistency in DEVCONF naming per Brian Haley's comment > - added entry to Documentation/networking/ip-sysctl.txt > > v2: > - only keep static addresses as suggested by Hannes > - added new managed flag to track configured addresses > - on ifdown do not remove from configured address from inet6_addr_lst > - on ifdown reset the TENTATIVE flag and set state to DAD so that DAD is > redone when link is brought up again > > Documentation/networking/ip-sysctl.txt | 6 +++ > include/linux/ipv6.h | 1 + > include/net/if_inet6.h | 1 + > include/uapi/linux/ipv6.h | 1 + > net/ipv6/addrconf.c | 91 +++++++++++++++++++++++++++++----- > 5 files changed, 87 insertions(+), 13 deletions(-) > > diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt > index ebe94f2cab98..51c60f58f7ec 100644 > --- a/Documentation/networking/ip-sysctl.txt > +++ b/Documentation/networking/ip-sysctl.txt > @@ -1432,6 +1432,12 @@ dad_transmits - INTEGER > The amount of Duplicate Address Detection probes to send. > Default: 1 > > +flush_addr_on_down - BOOLEAN > + Flush all IPv6 addresses on an interface down event. If disabled > + static global addresses with no expiration time are not flushed. > + > + Default: enabled > + > forwarding - INTEGER > Configure interface-specific Host/Router behaviour. > > diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h > index 0ef2a97ccdb5..112a18940ab2 100644 > --- a/include/linux/ipv6.h > +++ b/include/linux/ipv6.h > @@ -60,6 +60,7 @@ struct ipv6_devconf { > struct in6_addr secret; > } stable_secret; > __s32 use_oif_addrs_only; > + __s32 flush_addr_on_down; > void *sysctl; > }; > > diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h > index 1c8b6820b694..f190a14148ab 100644 > --- a/include/net/if_inet6.h > +++ b/include/net/if_inet6.h > @@ -72,6 +72,7 @@ struct inet6_ifaddr { > int regen_count; > > bool tokenized; > + bool managed; IMHO the naming of the bool is a bit too vague. ;) Would you mind renaming it to something like puuh... user_managed, non_autoconf, manual_conf etc.? 'managed' seems so often used in the context of temporary addresses, I first thought about that. enum { USER_SPACE, KERNEL_AUTOCONF } managed_by; > > struct rcu_head rcu; > struct in6_addr peer_addr; > diff --git a/include/uapi/linux/ipv6.h b/include/uapi/linux/ipv6.h > index 38b4fef20219..7c514f7cd209 100644 > --- a/include/uapi/linux/ipv6.h > +++ b/include/uapi/linux/ipv6.h > @@ -174,6 +174,7 @@ enum { > DEVCONF_USE_OIF_ADDRS_ONLY, > DEVCONF_ACCEPT_RA_MIN_HOP_LIMIT, > DEVCONF_IGNORE_ROUTES_WITH_LINKDOWN, > + DEVCONF_FLUSH_ADDR_ON_DOWN, > DEVCONF_MAX > }; > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index f0326aae7a02..e07b1fb52131 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -216,6 +216,7 @@ static struct ipv6_devconf ipv6_devconf __read_mostly = { > }, > .use_oif_addrs_only = 0, > .ignore_routes_with_linkdown = 0, > + .flush_addr_on_down = 1, > }; > > static struct ipv6_devconf ipv6_devconf_dflt __read_mostly = { > @@ -260,6 +261,7 @@ static struct ipv6_devconf ipv6_devconf_dflt __read_mostly = { > }, > .use_oif_addrs_only = 0, > .ignore_routes_with_linkdown = 0, > + .flush_addr_on_down = 1, > }; > > /* Check if a valid qdisc is available */ > @@ -955,6 +957,7 @@ ipv6_add_addr(struct inet6_dev *idev, const struct in6_addr *addr, > ifa->prefered_lft = prefered_lft; > ifa->cstamp = ifa->tstamp = jiffies; > ifa->tokenized = false; > + ifa->managed = false; > > ifa->rt = rt; > > @@ -2689,6 +2692,9 @@ static int inet6_addr_add(struct net *net, int ifindex, > valid_lft, prefered_lft); > > if (!IS_ERR(ifp)) { > + if (!expires) > + ifp->managed = true; > + This assumes that user space managed addresses don't time out. This is in fact not true. I am not sure if it matters a lot, as most addresses added from user space with a timeout most probably will be added because of autoconf, but they are not managed by kernel autoconf. Not sure if we want to make this more explicit, certainly it would avoid surprises. Otherwise the patch looks fine and useful! Thanks, Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Hannes: On 10/8/15 1:25 PM, Hannes Frederic Sowa wrote: >> diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h >> index 1c8b6820b694..f190a14148ab 100644 >> --- a/include/net/if_inet6.h >> +++ b/include/net/if_inet6.h >> @@ -72,6 +72,7 @@ struct inet6_ifaddr { >> int regen_count; >> >> bool tokenized; >> + bool managed; > > IMHO the naming of the bool is a bit too vague. ;) Would you mind > renaming it to something like puuh... user_managed, non_autoconf, > manual_conf etc.? 'managed' seems so often used in the context of > temporary addresses, I first thought about that. > > enum { USER_SPACE, KERNEL_AUTOCONF } managed_by; I have no preference on naming; unless other preferences are stated I'll do v5 with it renamed to 'user_managed'. >> @@ -2689,6 +2692,9 @@ static int inet6_addr_add(struct net *net, int ifindex, >> valid_lft, prefered_lft); >> >> if (!IS_ERR(ifp)) { >> + if (!expires) >> + ifp->managed = true; >> + > > This assumes that user space managed addresses don't time out. This is > in fact not true. I am not sure if it matters a lot, as most addresses > added from user space with a timeout most probably will be added because > of autoconf, but they are not managed by kernel autoconf. Not sure if we > want to make this more explicit, certainly it would avoid surprises. Not exactly. I'm taking the easy way out and saying only addresses with no expiration time fall into the 'user managed' category and retained on an ifdown. Trying to accommodate lifetimes is a PITA. I mentioned that in the documentation: "static global addresses with no expiration time are not flushed" Thanks for the review, David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi David, David Ahern <dsa@cumulusnetworks.com> writes: > On 10/8/15 1:25 PM, Hannes Frederic Sowa wrote: >>> diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h >>> index 1c8b6820b694..f190a14148ab 100644 >>> --- a/include/net/if_inet6.h >>> +++ b/include/net/if_inet6.h >>> @@ -72,6 +72,7 @@ struct inet6_ifaddr { >>> int regen_count; >>> >>> bool tokenized; >>> + bool managed; >> >> IMHO the naming of the bool is a bit too vague. ;) Would you mind >> renaming it to something like puuh... user_managed, non_autoconf, >> manual_conf etc.? 'managed' seems so often used in the context of >> temporary addresses, I first thought about that. >> >> enum { USER_SPACE, KERNEL_AUTOCONF } managed_by; > > I have no preference on naming; unless other preferences are stated I'll > do v5 with it renamed to 'user_managed'. I think this is more appropriate. Thanks! >>> @@ -2689,6 +2692,9 @@ static int inet6_addr_add(struct net *net, int ifindex, >>> valid_lft, prefered_lft); >>> >>> if (!IS_ERR(ifp)) { >>> + if (!expires) >>> + ifp->managed = true; >>> + >> >> This assumes that user space managed addresses don't time out. This is >> in fact not true. I am not sure if it matters a lot, as most addresses >> added from user space with a timeout most probably will be added because >> of autoconf, but they are not managed by kernel autoconf. Not sure if we >> want to make this more explicit, certainly it would avoid surprises. > > Not exactly. I'm taking the easy way out and saying only addresses with > no expiration time fall into the 'user managed' category and retained on > an ifdown. Trying to accommodate lifetimes is a PITA. I mentioned that > in the documentation: > "static global addresses with no expiration time are not flushed" Hmm, I thought a call to addrconf_verify on up would be sufficient but haven't looked into that too closely. Anyway, this logic actually only makes sense with addresses which don't expire. Thanks, Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: David Ahern <dsa@cumulusnetworks.com> Date: Wed, 7 Oct 2015 08:17:39 -0700 > +static void fixup_managed_addr(struct inet6_dev *idev, struct inet6_ifaddr *ifp) > +{ > + if (!ifp->rt) > + ifp->rt = addrconf_dst_alloc(idev, &ifp->addr, false); This potentially leaves an error pointer dangling in ifp->rt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index ebe94f2cab98..51c60f58f7ec 100644 --- a/Documentation/networking/ip-sysctl.txt +++ b/Documentation/networking/ip-sysctl.txt @@ -1432,6 +1432,12 @@ dad_transmits - INTEGER The amount of Duplicate Address Detection probes to send. Default: 1 +flush_addr_on_down - BOOLEAN + Flush all IPv6 addresses on an interface down event. If disabled + static global addresses with no expiration time are not flushed. + + Default: enabled + forwarding - INTEGER Configure interface-specific Host/Router behaviour. diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h index 0ef2a97ccdb5..112a18940ab2 100644 --- a/include/linux/ipv6.h +++ b/include/linux/ipv6.h @@ -60,6 +60,7 @@ struct ipv6_devconf { struct in6_addr secret; } stable_secret; __s32 use_oif_addrs_only; + __s32 flush_addr_on_down; void *sysctl; }; diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h index 1c8b6820b694..f190a14148ab 100644 --- a/include/net/if_inet6.h +++ b/include/net/if_inet6.h @@ -72,6 +72,7 @@ struct inet6_ifaddr { int regen_count; bool tokenized; + bool managed; struct rcu_head rcu; struct in6_addr peer_addr; diff --git a/include/uapi/linux/ipv6.h b/include/uapi/linux/ipv6.h index 38b4fef20219..7c514f7cd209 100644 --- a/include/uapi/linux/ipv6.h +++ b/include/uapi/linux/ipv6.h @@ -174,6 +174,7 @@ enum { DEVCONF_USE_OIF_ADDRS_ONLY, DEVCONF_ACCEPT_RA_MIN_HOP_LIMIT, DEVCONF_IGNORE_ROUTES_WITH_LINKDOWN, + DEVCONF_FLUSH_ADDR_ON_DOWN, DEVCONF_MAX }; diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index f0326aae7a02..e07b1fb52131 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -216,6 +216,7 @@ static struct ipv6_devconf ipv6_devconf __read_mostly = { }, .use_oif_addrs_only = 0, .ignore_routes_with_linkdown = 0, + .flush_addr_on_down = 1, }; static struct ipv6_devconf ipv6_devconf_dflt __read_mostly = { @@ -260,6 +261,7 @@ static struct ipv6_devconf ipv6_devconf_dflt __read_mostly = { }, .use_oif_addrs_only = 0, .ignore_routes_with_linkdown = 0, + .flush_addr_on_down = 1, }; /* Check if a valid qdisc is available */ @@ -955,6 +957,7 @@ ipv6_add_addr(struct inet6_dev *idev, const struct in6_addr *addr, ifa->prefered_lft = prefered_lft; ifa->cstamp = ifa->tstamp = jiffies; ifa->tokenized = false; + ifa->managed = false; ifa->rt = rt; @@ -2689,6 +2692,9 @@ static int inet6_addr_add(struct net *net, int ifindex, valid_lft, prefered_lft); if (!IS_ERR(ifp)) { + if (!expires) + ifp->managed = true; + if (!(ifa_flags & IFA_F_NOPREFIXROUTE)) { addrconf_prefix_route(&ifp->addr, ifp->prefix_len, dev, expires, flags); @@ -3128,6 +3134,34 @@ static void addrconf_gre_config(struct net_device *dev) } #endif +static void fixup_managed_addr(struct inet6_dev *idev, struct inet6_ifaddr *ifp) +{ + if (!ifp->rt) + ifp->rt = addrconf_dst_alloc(idev, &ifp->addr, false); + + if (!(ifp->flags & IFA_F_NOPREFIXROUTE)) { + addrconf_prefix_route(&ifp->addr, ifp->prefix_len, + idev->dev, 0, 0); + } + + addrconf_dad_start(ifp); +} + +static void addrconf_managed_addr(struct net_device *dev) +{ + struct inet6_ifaddr *ifp; + struct inet6_dev *idev; + + idev = __in6_dev_get(dev); + if (!idev) + return; + + list_for_each_entry(ifp, &idev->addr_list, if_list) { + if (ifp->managed) + fixup_managed_addr(idev, ifp); + } +} + static int addrconf_notify(struct notifier_block *this, unsigned long event, void *ptr) { @@ -3187,6 +3221,8 @@ static int addrconf_notify(struct notifier_block *this, unsigned long event, run_pending = 1; } + addrconf_managed_addr(dev); + switch (dev->type) { #if IS_ENABLED(CONFIG_IPV6_SIT) case ARPHRD_SIT: @@ -3307,7 +3343,8 @@ static int addrconf_ifdown(struct net_device *dev, int how) { struct net *net = dev_net(dev); struct inet6_dev *idev; - struct inet6_ifaddr *ifa; + struct inet6_ifaddr *ifa, *tmp; + struct list_head del_list; int state, i; ASSERT_RTNL(); @@ -3342,9 +3379,13 @@ static int addrconf_ifdown(struct net_device *dev, int how) restart: hlist_for_each_entry_rcu(ifa, h, addr_lst) { if (ifa->idev == idev) { - hlist_del_init_rcu(&ifa->addr_lst); addrconf_del_dad_work(ifa); - goto restart; + if (how || idev->cnf.flush_addr_on_down || + !ifa->managed) { + hlist_del_init_rcu(&ifa->addr_lst); + goto restart; + } + } } spin_unlock_bh(&addrconf_hash_lock); @@ -3378,13 +3419,10 @@ static int addrconf_ifdown(struct net_device *dev, int how) write_lock_bh(&idev->lock); } - while (!list_empty(&idev->addr_list)) { - ifa = list_first_entry(&idev->addr_list, - struct inet6_ifaddr, if_list); + INIT_LIST_HEAD(&del_list); + list_for_each_entry_safe(ifa, tmp, &idev->addr_list, if_list) { addrconf_del_dad_work(ifa); - list_del(&ifa->if_list); - write_unlock_bh(&idev->lock); spin_lock_bh(&ifa->lock); @@ -3396,13 +3434,29 @@ static int addrconf_ifdown(struct net_device *dev, int how) __ipv6_ifa_notify(RTM_DELADDR, ifa); inet6addr_notifier_call_chain(NETDEV_DOWN, ifa); } - in6_ifa_put(ifa); - write_lock_bh(&idev->lock); + if (!how && !idev->cnf.flush_addr_on_down && ifa->managed) { + ifa->state = 0; + if (!(ifa->flags & IFA_F_NODAD)) + ifa->flags |= IFA_F_TENTATIVE; + } else { + list_del(&ifa->if_list); + list_add(&ifa->if_list, &del_list); + } + + write_lock_bh(&idev->lock); } write_unlock_bh(&idev->lock); + while (!list_empty(&del_list)) { + ifa = list_first_entry(&del_list, + struct inet6_ifaddr, if_list); + list_del(&ifa->if_list); + + in6_ifa_put(ifa); + } + /* Step 5: Discard anycast and multicast list */ if (how) { ipv6_ac_destroy_dev(idev); @@ -4662,6 +4716,7 @@ static inline void ipv6_store_devconf(struct ipv6_devconf *cnf, array[DEVCONF_IGNORE_ROUTES_WITH_LINKDOWN] = cnf->ignore_routes_with_linkdown; /* we omit DEVCONF_STABLE_SECRET for now */ array[DEVCONF_USE_OIF_ADDRS_ONLY] = cnf->use_oif_addrs_only; + array[DEVCONF_FLUSH_ADDR_ON_DOWN] = cnf->flush_addr_on_down; } static inline size_t inet6_ifla6_size(void) @@ -5141,10 +5196,12 @@ static void __ipv6_ifa_notify(int event, struct inet6_ifaddr *ifp) if (rt) ip6_del_rt(rt); } - dst_hold(&ifp->rt->dst); - - ip6_del_rt(ifp->rt); + if (ifp->rt) { + dst_hold(&ifp->rt->dst); + ip6_del_rt(ifp->rt); + ifp->rt = NULL; + } rt_genid_bump_ipv6(net); break; } @@ -5723,6 +5780,14 @@ static struct addrconf_sysctl_table .proc_handler = addrconf_sysctl_ignore_routes_with_linkdown, }, { + .procname = "flush_addr_on_down", + .data = &ipv6_devconf.flush_addr_on_down, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = proc_dointvec, + + }, + { /* sentinel */ } },
Currently, all ipv6 addresses are flushed when the interface is configured down, including global, static addresses: $ ip -6 addr add dev eth1 2000:11:1:1::1/64 $ ip addr show dev eth1 3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000 link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff inet6 2000:11:1:1::1/64 scope global tentative valid_lft forever preferred_lft forever $ ip link set dev eth1 up $ ip link set dev eth1 down $ ip addr show dev eth1 3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000 link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff Add a new sysctl to make this behavior optional. The new setting defaults to flush all addresses to maintain backwards compatibility. When the setting is reset global addresses with no expire times are not flushed: $ echo 0 > /proc/sys/net/ipv6/conf/eth1/flush_addr_on_down $ ip -6 addr add dev eth1 2000:11:1:1::1/64 $ ip addr show dev eth1 3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000 link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff inet6 2000:11:1:1::1/64 scope global tentative valid_lft forever preferred_lft forever $ ip link set dev eth1 up $ ip link set dev eth1 down $ ip addr show dev eth1 3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000 link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff inet6 2000:11:1:1::1/64 scope global valid_lft forever preferred_lft forever inet6 fe80::4:11ff:fe22:3301/64 scope link valid_lft forever preferred_lft forever Signed-off-by: David Ahern <dsa@cumulusnetworks.com> --- It has been 8 months since the last version: http://lists.openwall.net/netdev/2015/02/12/33 but wanted to revive it. This current version addresses the last round of comments and verifies all routes are deleted and re-added correctly Nicolas: I ran 'ip monitor' on a link down and link up cycle and you can see the neighbor and route deletes on a down and routes added on an up. v4: - rebased to top of tree - updated to clear all routes on admin down and re-added on admin up - verified the route tables (main and local) on a link down have *no* remnants of the configured, global address. On a link up all routes are restored -- multicast, linklocal, local routes and connected. v3: - fix local variable ordering and comment style per Dave's comment - consistency in DEVCONF naming per Brian Haley's comment - added entry to Documentation/networking/ip-sysctl.txt v2: - only keep static addresses as suggested by Hannes - added new managed flag to track configured addresses - on ifdown do not remove from configured address from inet6_addr_lst - on ifdown reset the TENTATIVE flag and set state to DAD so that DAD is redone when link is brought up again Documentation/networking/ip-sysctl.txt | 6 +++ include/linux/ipv6.h | 1 + include/net/if_inet6.h | 1 + include/uapi/linux/ipv6.h | 1 + net/ipv6/addrconf.c | 91 +++++++++++++++++++++++++++++----- 5 files changed, 87 insertions(+), 13 deletions(-)