mbox

[PULL,0/5] s390x: Fixes and features

Message ID 1444128065-87628-1-git-send-email-borntraeger@de.ibm.com
State New
Headers show

Pull-request

git://github.com/borntraeger/qemu.git tags/s390x-20151006

Message

Christian Borntraeger Oct. 6, 2015, 10:41 a.m. UTC 
Peter,

here are some fixes (and a small feature) for s390x.

The following changes since commit b2312c680084ea18cd55fa7093397cad2224ec14:

  Merge remote-tracking branch 'remotes/amit-migration/tags/for-juan-201509' into staging (2015-09-29 12:41:19 +0100)

are available in the git repository at:

  git://github.com/borntraeger/qemu.git tags/s390x-20151006

for you to fetch changes up to d9f090ec7794d433b8f222ae8c8f95601369a4a5:

  s390x: rename io_subsystem_reset -> subsystem_reset (2015-10-02 13:31:52 +0200)

----------------------------------------------------------------
s390: fixes

Some fixes all over the place:
- ccw bios and gcc 5.1 (avoid floating point ops)
- properly print vector registers
- sclp and sclp-event-facility no longer hang on object_unref(object_new(T))
- better name for io_subsystem_reset

One feature
- the gdb server now exposes several virtualization specific register

----------------------------------------------------------------
Christian Borntraeger (2):
      pc-bios/s390-ccw: avoid floating point operations
      s390x/info registers: print vector registers properly

David Hildenbrand (3):
      s390x/gdb: expose virtualization specific registers
      s390x: set missing parent for hotplug and quiesce events
      s390x: rename io_subsystem_reset -> subsystem_reset

 configure                  |  2 +-
 gdb-xml/s390-virt.xml      | 18 ++++++++++
 hw/s390x/event-facility.c  | 20 +++++------
 hw/s390x/s390-virtio-ccw.c |  2 +-
 pc-bios/s390-ccw/Makefile  |  3 +-
 target-s390x/cpu.h         |  2 +-
 target-s390x/gdbstub.c     | 82 ++++++++++++++++++++++++++++++++++++++++++++++
 target-s390x/misc_helper.c |  4 +--
 target-s390x/translate.c   |  2 +-
 9 files changed, 118 insertions(+), 17 deletions(-)
 create mode 100644 gdb-xml/s390-virt.xml

Comments

Christian Borntraeger Oct. 6, 2015, 10:58 a.m. UTC | #1 
Am 06.10.2015 um 12:41 schrieb Christian Borntraeger:
> Peter,
> 
> here are some fixes (and a small feature) for s390x.
> 
> The following changes since commit b2312c680084ea18cd55fa7093397cad2224ec14:
> 
>   Merge remote-tracking branch 'remotes/amit-migration/tags/for-juan-201509' into staging (2015-09-29 12:41:19 +0100)
> 
> are available in the git repository at:
> 
>   git://github.com/borntraeger/qemu.git tags/s390x-20151006
> 
> for you to fetch changes up to d9f090ec7794d433b8f222ae8c8f95601369a4a5:
> 
>   s390x: rename io_subsystem_reset -> subsystem_reset (2015-10-02 13:31:52 +0200)
> 


[...]
>       s390x: set missing parent for hotplug and quiesce events

Markus this patch should fix the introspection issues that you have seen for sclp
and s390-sclp-event-facility.

Christian
Markus Armbruster Oct. 6, 2015, 1:38 p.m. UTC | #2 
Christian Borntraeger <borntraeger@de.ibm.com> writes:

> Am 06.10.2015 um 12:41 schrieb Christian Borntraeger:
>> Peter,
>> 
>> here are some fixes (and a small feature) for s390x.
>> 
>> The following changes since commit b2312c680084ea18cd55fa7093397cad2224ec14:
>> 
>>   Merge remote-tracking branch
>> 'remotes/amit-migration/tags/for-juan-201509' into staging
>> (2015-09-29 12:41:19 +0100)
>> 
>> are available in the git repository at:
>> 
>>   git://github.com/borntraeger/qemu.git tags/s390x-20151006
>> 
>> for you to fetch changes up to d9f090ec7794d433b8f222ae8c8f95601369a4a5:
>> 
>>   s390x: rename io_subsystem_reset -> subsystem_reset (2015-10-02
>> 13:31:52 +0200)
>> 
>
>
> [...]
>>       s390x: set missing parent for hotplug and quiesce events
>
> Markus this patch should fix the introspection issues that you have
> seen for sclp
> and s390-sclp-event-facility.

It does, thanks!  I'll update my patches accordingly.
Peter Maydell Oct. 7, 2015, 8:55 p.m. UTC | #3 
On 6 October 2015 at 11:41, Christian Borntraeger
<borntraeger@de.ibm.com> wrote:
> Peter,
>
> here are some fixes (and a small feature) for s390x.
>
> The following changes since commit b2312c680084ea18cd55fa7093397cad2224ec14:
>
>   Merge remote-tracking branch 'remotes/amit-migration/tags/for-juan-201509' into staging (2015-09-29 12:41:19 +0100)
>
> are available in the git repository at:
>
>   git://github.com/borntraeger/qemu.git tags/s390x-20151006
>
> for you to fetch changes up to d9f090ec7794d433b8f222ae8c8f95601369a4a5:
>
>   s390x: rename io_subsystem_reset -> subsystem_reset (2015-10-02 13:31:52 +0200)
>
> ----------------------------------------------------------------
> s390: fixes
>
> Some fixes all over the place:
> - ccw bios and gcc 5.1 (avoid floating point ops)
> - properly print vector registers
> - sclp and sclp-event-facility no longer hang on object_unref(object_new(T))
> - better name for io_subsystem_reset
>
> One feature
> - the gdb server now exposes several virtualization specific register
>
> ----------------------------------------------------------------
> Christian Borntraeger (2):
>       pc-bios/s390-ccw: avoid floating point operations
>       s390x/info registers: print vector registers properly
>
> David Hildenbrand (3):
>       s390x/gdb: expose virtualization specific registers
>       s390x: set missing parent for hotplug and quiesce events
>       s390x: rename io_subsystem_reset -> subsystem_reset
>
>  configure                  |  2 +-
>  gdb-xml/s390-virt.xml      | 18 ++++++++++
>  hw/s390x/event-facility.c  | 20 +++++------
>  hw/s390x/s390-virtio-ccw.c |  2 +-
>  pc-bios/s390-ccw/Makefile  |  3 +-
>  target-s390x/cpu.h         |  2 +-
>  target-s390x/gdbstub.c     | 82 ++++++++++++++++++++++++++++++++++++++++++++++
>  target-s390x/misc_helper.c |  4 +--
>  target-s390x/translate.c   |  2 +-
>  9 files changed, 118 insertions(+), 17 deletions(-)
>  create mode 100644 gdb-xml/s390-virt.xml

Just to check before I apply this -- given the change to
pc-bios/s390-ccw/Makefile, is there a missing update to the
compiled s390-ccw.img itself?

thanks
-- PMM
Christian Borntraeger Oct. 7, 2015, 9:21 p.m. UTC | #4 
Am 07.10.2015 um 22:55 schrieb Peter Maydell:
> On 6 October 2015 at 11:41, Christian Borntraeger
> <borntraeger@de.ibm.com> wrote:
>> Peter,
>>
>> here are some fixes (and a small feature) for s390x.
>>
>> The following changes since commit b2312c680084ea18cd55fa7093397cad2224ec14:
>>
>>   Merge remote-tracking branch 'remotes/amit-migration/tags/for-juan-201509' into staging (2015-09-29 12:41:19 +0100)
>>
>> are available in the git repository at:
>>
>>   git://github.com/borntraeger/qemu.git tags/s390x-20151006
>>
>> for you to fetch changes up to d9f090ec7794d433b8f222ae8c8f95601369a4a5:
>>
>>   s390x: rename io_subsystem_reset -> subsystem_reset (2015-10-02 13:31:52 +0200)
>>
>> ----------------------------------------------------------------
>> s390: fixes
>>
>> Some fixes all over the place:
>> - ccw bios and gcc 5.1 (avoid floating point ops)
>> - properly print vector registers
>> - sclp and sclp-event-facility no longer hang on object_unref(object_new(T))
>> - better name for io_subsystem_reset
>>
>> One feature
>> - the gdb server now exposes several virtualization specific register
>>
>> ----------------------------------------------------------------
>> Christian Borntraeger (2):
>>       pc-bios/s390-ccw: avoid floating point operations
>>       s390x/info registers: print vector registers properly
>>
>> David Hildenbrand (3):
>>       s390x/gdb: expose virtualization specific registers
>>       s390x: set missing parent for hotplug and quiesce events
>>       s390x: rename io_subsystem_reset -> subsystem_reset
>>
>>  configure                  |  2 +-
>>  gdb-xml/s390-virt.xml      | 18 ++++++++++
>>  hw/s390x/event-facility.c  | 20 +++++------
>>  hw/s390x/s390-virtio-ccw.c |  2 +-
>>  pc-bios/s390-ccw/Makefile  |  3 +-
>>  target-s390x/cpu.h         |  2 +-
>>  target-s390x/gdbstub.c     | 82 ++++++++++++++++++++++++++++++++++++++++++++++
>>  target-s390x/misc_helper.c |  4 +--
>>  target-s390x/translate.c   |  2 +-
>>  9 files changed, 118 insertions(+), 17 deletions(-)
>>  create mode 100644 gdb-xml/s390-virt.xml
> 
> Just to check before I apply this -- given the change to
> pc-bios/s390-ccw/Makefile, is there a missing update to the
> compiled s390-ccw.img itself?

No, the current compiled s390-ccw.img is fine. The patch is just to avoid
"miscompiles" with gcc 5.1 which tends to do a lot of spilling/filling into/from
floating point registers.

Christian
Peter Maydell Oct. 8, 2015, 10:27 a.m. UTC | #5 
On 7 October 2015 at 22:21, Christian Borntraeger
<borntraeger@de.ibm.com> wrote:
> Am 07.10.2015 um 22:55 schrieb Peter Maydell:
>> On 6 October 2015 at 11:41, Christian Borntraeger
>> <borntraeger@de.ibm.com> wrote:
>>> Peter,
>>>
>>> here are some fixes (and a small feature) for s390x.
>>>
>>> The following changes since commit b2312c680084ea18cd55fa7093397cad2224ec14:
>>>
>>>   Merge remote-tracking branch 'remotes/amit-migration/tags/for-juan-201509' into staging (2015-09-29 12:41:19 +0100)
>>>
>>> are available in the git repository at:
>>>
>>>   git://github.com/borntraeger/qemu.git tags/s390x-20151006
>>>
>>> for you to fetch changes up to d9f090ec7794d433b8f222ae8c8f95601369a4a5:
>>>
>>>   s390x: rename io_subsystem_reset -> subsystem_reset (2015-10-02 13:31:52 +0200)
>>>
>>> ----------------------------------------------------------------
>>> s390: fixes
>>>
>>> Some fixes all over the place:
>>> - ccw bios and gcc 5.1 (avoid floating point ops)
>>> - properly print vector registers
>>> - sclp and sclp-event-facility no longer hang on object_unref(object_new(T))
>>> - better name for io_subsystem_reset
>>>
>>> One feature
>>> - the gdb server now exposes several virtualization specific register
>>>
>>> ----------------------------------------------------------------
>>> Christian Borntraeger (2):
>>>       pc-bios/s390-ccw: avoid floating point operations
>>>       s390x/info registers: print vector registers properly
>>>
>>> David Hildenbrand (3):
>>>       s390x/gdb: expose virtualization specific registers
>>>       s390x: set missing parent for hotplug and quiesce events
>>>       s390x: rename io_subsystem_reset -> subsystem_reset
>>>
>>>  configure                  |  2 +-
>>>  gdb-xml/s390-virt.xml      | 18 ++++++++++
>>>  hw/s390x/event-facility.c  | 20 +++++------
>>>  hw/s390x/s390-virtio-ccw.c |  2 +-
>>>  pc-bios/s390-ccw/Makefile  |  3 +-
>>>  target-s390x/cpu.h         |  2 +-
>>>  target-s390x/gdbstub.c     | 82 ++++++++++++++++++++++++++++++++++++++++++++++
>>>  target-s390x/misc_helper.c |  4 +--
>>>  target-s390x/translate.c   |  2 +-
>>>  9 files changed, 118 insertions(+), 17 deletions(-)
>>>  create mode 100644 gdb-xml/s390-virt.xml
>>
>> Just to check before I apply this -- given the change to
>> pc-bios/s390-ccw/Makefile, is there a missing update to the
>> compiled s390-ccw.img itself?
>
> No, the current compiled s390-ccw.img is fine. The patch is just to avoid
> "miscompiles" with gcc 5.1 which tends to do a lot of spilling/filling into/from
> floating point registers.

OK, thanks for the confirmation. Applied to master.

-- PMM