[i386,AVX-512] Update extract_even_odd w/ AVX-512BW insns.

Message ID	CAFULd4ZiYkt6BuSje6oORzCYzWvF3Oz5AGv+pYVS2o4tutSNcQ@mail.gmail.com
State	New
Headers	show Return-Path: <gcc-patches-return-409119-incoming=patchwork.ozlabs.org@gcc.gnu.org> DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=fr47DrBnfziMR/g90B apwOqJsibmJVdr//IgeRH36vR4/iIuweaBrK+802CCLgb0jnNYlm5CeOLNZypyKb vRhK5H2Nti5pzCqhzev9xtIZkhX3ApbqJ5ATu2gn+U8W99DH+o0uCwhflqoDOkiI L6goBRUixKSPgufE5ViuEpkmk= Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org MIME-Version: 1.0 In-Reply-To: <D52A9F69-FE0A-4BF1-B6E7-1C3C458A36AA@lps.ens.fr> References: <D52A9F69-FE0A-4BF1-B6E7-1C3C458A36AA@lps.ens.fr> Date: Sun, 4 Oct 2015 16:04:36 +0200 Message-ID: <CAFULd4ZiYkt6BuSje6oORzCYzWvF3Oz5AGv+pYVS2o4tutSNcQ@mail.gmail.com> Subject: Re: [PATCH, i386, AVX-512] Update extract_even_odd w/ AVX-512BW insns. From: Uros Bizjak <ubizjak@gmail.com> To: =?UTF-8?Q?Dominique_d=27Humi=C3=A8res?= <dominiq@lps.ens.fr> Cc: Kirill Yukhin <kirill.yukhin@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org> Content-Type: multipart/mixed; boundary=001a113dc8b8827866052147e012

Message ID

CAFULd4ZiYkt6BuSje6oORzCYzWvF3Oz5AGv+pYVS2o4tutSNcQ@mail.gmail.com

State

New

Headers

DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id
	:list-unsubscribe:list-archive:list-post:list-help:sender
	:mime-version:in-reply-to:references:date:message-id:subject
	:from:to:cc:content-type; q=dns; s=default; b=fr47DrBnfziMR/g90B
	apwOqJsibmJVdr//IgeRH36vR4/iIuweaBrK+802CCLgb0jnNYlm5CeOLNZypyKb
	vRhK5H2Nti5pzCqhzev9xtIZkhX3ApbqJ5ATu2gn+U8W99DH+o0uCwhflqoDOkiI
	L6goBRUixKSPgufE5ViuEpkmk=
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
Sender: gcc-patches-owner@gcc.gnu.org
MIME-Version: 1.0
In-Reply-To: <D52A9F69-FE0A-4BF1-B6E7-1C3C458A36AA@lps.ens.fr>
References: <D52A9F69-FE0A-4BF1-B6E7-1C3C458A36AA@lps.ens.fr>
Date: Sun, 4 Oct 2015 16:04:36 +0200
Message-ID: <CAFULd4ZiYkt6BuSje6oORzCYzWvF3Oz5AGv+pYVS2o4tutSNcQ@mail.gmail.com>
Subject: Re: [PATCH, i386,
	AVX-512] Update extract_even_odd w/ AVX-512BW insns.
From: Uros Bizjak <ubizjak@gmail.com>
To: =?UTF-8?Q?Dominique_d=27Humi=C3=A8res?= <dominiq@lps.ens.fr>
Cc: Kirill Yukhin <kirill.yukhin@gmail.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: multipart/mixed; boundary=001a113dc8b8827866052147e012

Commit Message

Uros Bizjak Oct. 4, 2015, 2:04 p.m. UTC

On Sat, Oct 3, 2015 at 12:49 PM, Dominique d'Humières
<dominiq@lps.ens.fr> wrote:
> Kirill,
>
> The new tests fail on x86_64-apple-darwin14:
>
> FAIL: gcc.target/i386/vect-pack-trunc-1.c (test for excess errors)
> UNRESOLVED: gcc.target/i386/vect-pack-trunc-1.c compilation failed to produce executable
> FAIL: gcc.target/i386/vect-pack-trunc-2.c (test for excess errors)
> UNRESOLVED: gcc.target/i386/vect-pack-trunc-2.c compilation failed to produce executable
> FAIL: gcc.target/i386/vect-perm-even-1.c (test for excess errors)
> UNRESOLVED: gcc.target/i386/vect-perm-even-1.c compilation failed to produce executable
> FAIL: gcc.target/i386/vect-perm-odd-1.c (test for excess errors)
> UNRESOLVED: gcc.target/i386/vect-perm-odd-1.c compilation failed to produce executable
> FAIL: gcc.target/i386/vect-unpack-1.c (test for excess errors)
> UNRESOLVED: gcc.target/i386/vect-unpack-1.c compilation failed to produce executable
> FAIL: gcc.target/i386/vect-unpack-2.c (test for excess errors)
> UNRESOLVED: gcc.target/i386/vect-unpack-2.c compilation failed to produce executable
>
> I think the tests should be protected with
>
> /* { dg-require-effective-target avx512bw } */

You are correct.  Fixed by attached patch.

2015-10-04  Uros Bizjak  <ubizjak@gmail.com>

    * gcc.target/i386/vect-pack-trunc-1.c: Require avx512bw
    effective target.
    * gcc.target/i386/vect-pack-trunc-2.c: Ditto.
    * gcc.target/i386/vect-perm-even-1.c: Ditto.
    * gcc.target/i386/vect-perm-odd-1.c: Ditto.
    * gcc.target/i386/vect-unpack-1.c: Ditto.
    * gcc.target/i386/vect-unpack-2.c: Ditto.

Tested on x86_64-linux-gnu {,-m32}  and committed to mainline SVN.

> Note also that the options '-fno-diagnostics-show-caret -fdiagnostics-color=never -O2’ are not obeyed:
>
> ^[[1mvect-pack-trunc-1.s:67:2: ^[[0;1;31merror: ^[[0m^[[1minstruction requires: AVX-512 ISA
> ^[[0m        vmovdqa64       LC0-L1$pb(%ebx), %zmm0
> ^[[0;1;32m        ^
> ^[[0m^[[1mvect-pack-trunc-1.s:68:2: ^[[0;1;31merror: ^[[0m^[[1minstruction requires: AVX-512 ISA
> ^[[0m        vmovdqa64       LC1-L1$pb(%ebx), %zmm4
> ^[[0;1;32m        ^

This error is not from the compiler.

Uros.

Index: gcc.target/i386/vect-pack-trunc-1.c
===================================================================
--- gcc.target/i386/vect-pack-trunc-1.c	(revision 228455)
+++ gcc.target/i386/vect-pack-trunc-1.c	(working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-options "-O2 -ftree-vectorize -ffast-math -mavx512bw -save-temps" } */
+/* { dg-require-effective-target avx512bw } */
 
 #include "avx512bw-check.h"
 
Index: gcc.target/i386/vect-pack-trunc-2.c
===================================================================
--- gcc.target/i386/vect-pack-trunc-2.c	(revision 228455)
+++ gcc.target/i386/vect-pack-trunc-2.c	(working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-options "-O2 -ftree-vectorize -ffast-math -mavx512bw -save-temps" } */
+/* { dg-require-effective-target avx512bw } */
 
 #include "avx512bw-check.h"
 
Index: gcc.target/i386/vect-perm-even-1.c
===================================================================
--- gcc.target/i386/vect-perm-even-1.c	(revision 228455)
+++ gcc.target/i386/vect-perm-even-1.c	(working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-options "-O2 -ftree-vectorize -ffast-math -mavx512bw -save-temps" } */
+/* { dg-require-effective-target avx512bw } */
 
 #include "avx512bw-check.h"
 
Index: gcc.target/i386/vect-perm-odd-1.c
===================================================================
--- gcc.target/i386/vect-perm-odd-1.c	(revision 228455)
+++ gcc.target/i386/vect-perm-odd-1.c	(working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-options "-O2 -ftree-vectorize -ffast-math -mavx512bw -save-temps" } */
+/* { dg-require-effective-target avx512bw } */
 
 #include "avx512bw-check.h"
 
Index: gcc.target/i386/vect-unpack-1.c
===================================================================
--- gcc.target/i386/vect-unpack-1.c	(revision 228455)
+++ gcc.target/i386/vect-unpack-1.c	(working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-options "-O2 -ftree-vectorize -ffast-math -mavx512bw -save-temps" } */
+/* { dg-require-effective-target avx512bw } */
 
 #include "avx512bw-check.h"
 
Index: gcc.target/i386/vect-unpack-2.c
===================================================================
--- gcc.target/i386/vect-unpack-2.c	(revision 228455)
+++ gcc.target/i386/vect-unpack-2.c	(working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-options "-O2 -ftree-vectorize -ffast-math -mavx512bw -save-temps" } */
+/* { dg-require-effective-target avx512bw } */
 
 #include "avx512bw-check.h"