diff mbox

[3/3] signal: remove jffs2_garbage_collect_thread()->allow_signal(SIGCONT)

Message ID 20151003181341.GA1064@redhat.com
State Accepted
Headers show

Commit Message

Oleg Nesterov Oct. 3, 2015, 6:13 p.m. UTC 
jffs2_garbage_collect_thread() does allow_signal(SIGCONT) for no reason,
SIGCONT will wake a stopped task up even if it is ignored.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 fs/jffs2/background.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Tejun Heo Oct. 4, 2015, 5:28 p.m. UTC | #1 
On Sat, Oct 03, 2015 at 08:13:41PM +0200, Oleg Nesterov wrote:
> jffs2_garbage_collect_thread() does allow_signal(SIGCONT) for no reason,
> SIGCONT will wake a stopped task up even if it is ignored.
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Reviewed-by: Tejun Heo <tj@kernel.org>

Thanks.
diff mbox

Patch

diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
index 53cc735..e5c1783 100644
--- a/fs/jffs2/background.c
+++ b/fs/jffs2/background.c
@@ -80,7 +80,6 @@  static int jffs2_garbage_collect_thread(void *_c)
 	siginitset(&hupmask, sigmask(SIGHUP));
 	allow_signal(SIGKILL);
 	allow_signal(SIGSTOP);
-	allow_signal(SIGCONT);
 	allow_signal(SIGHUP);
 
 	c->gc_task = current;